mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Joe Perches <joe@perches.com>,
	kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	Casey Schaufler <casey@schaufler-ca.com>,
	Christoph Hellwig <hch@lst.de>,
	David Howells <dhowells@redhat.com>,
	David Laight <David.Laight@ACULAB.COM>,
	Ian Kent <raven@themaw.net>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] checkpatch/coding-style: Allow 100 column lines
Date: Sat, 30 May 2020 13:40:53 +0200	[thread overview]
Message-ID: <a45357fe-6570-ef20-ed0e-494cdf7a6f1d@web.de> (raw)

> Change the maximum allowed line length to 100 from 80.
>
> Miscellanea:
>
> o to avoid unnecessary whitespace changes in files,
>   checkpatch will no longer emit a warning about line length
>   when scanning files unless --strict is also used
> o Add a bit to coding-style about alignment to open parenthesis

I suggest to convert this patch into a patch series with three update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=86852175b016f0c6873dcbc24b93d12b7b246612#n138> +++ b/Documentation/process/coding-style.rst
> @@ -84,15 +84,22 @@ …
> +… and are
> +are placed …

Please avoid a word duplication here.


> +… to a function open parenthesis.

Wording alternatives:

+is to align descendants to an open parenthesis of a function call.


> +These same rules are …

+The same rules are applied to function headers with a long argument list.


Regards,
Markus

             reply	other threads:[~2020-05-30 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 11:40 Markus Elfring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-05-28 18:51 clean up kernel_{read,write} & friends v2 Linus Torvalds
2020-05-28  5:40 ` Christoph Hellwig
2020-05-28 20:17   ` David Howells
2020-05-28 21:20     ` Casey Schaufler
2020-05-29 13:08       ` David Laight
2020-05-29 19:19         ` Linus Torvalds
2020-05-29 23:12           ` [PATCH] checkpatch/coding-style: Allow 100 column lines Joe Perches
2020-05-30 22:14             ` Andreas Dilger
2020-05-30 23:15               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a45357fe-6570-ef20-ed0e-494cdf7a6f1d@web.de \
    --to=markus.elfring@web.de \
    --cc=David.Laight@ACULAB.COM \
    --cc=casey@schaufler-ca.com \
    --cc=dhowells@redhat.com \
    --cc=hch@lst.de \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=raven@themaw.net \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®