From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3A7C433FF for ; Wed, 31 Jul 2019 07:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63DC320693 for ; Wed, 31 Jul 2019 07:46:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727296AbfGaHqc (ORCPT ); Wed, 31 Jul 2019 03:46:32 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:42650 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725866AbfGaHqb (ORCPT ); Wed, 31 Jul 2019 03:46:31 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 47C65C714FCE4F69CE1B; Wed, 31 Jul 2019 15:46:29 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 15:46:18 +0800 Subject: Re: [PATCH 10/22] staging: erofs: kill sbi->dev_name To: Gao Xiang , Greg Kroah-Hartman , CC: , LKML , , Miao Xie References: <20190729065159.62378-1-gaoxiang25@huawei.com> <20190729065159.62378-11-gaoxiang25@huawei.com> From: Chao Yu Message-ID: Date: Wed, 31 Jul 2019 15:46:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190729065159.62378-11-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/29 14:51, Gao Xiang wrote: > As Al said, "the only use of sbi->dev_name is debugging > printks and all of those have sb->s_id available, with > device name stored in there. Which makes the whole > thing bloody weird". > > sbi->dev_name was used for our debugging use and it's > better to just use s_id in community and delete > the whole erofs_mount_private stuff. > > Suggested-by: Al Viro > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,