mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nandor Han <nandor.han@vaisala.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: "Vesa Jääskeläinen" <vesa.jaaskelainen@vaisala.com>,
	"Tomas Melin" <tomas.melin@vaisala.com>
Subject: Re: [PATCH v4 2/4] nvmem: bootcount: add bootcount driver
Date: Tue, 1 Jun 2021 10:58:59 +0300	[thread overview]
Message-ID: <a456396b-3950-7bd2-8f5c-af2699276f82@vaisala.com> (raw)
In-Reply-To: <b973f433-5aa6-5c93-4d60-1017495ae0a7@linaro.org>

Hi and thanks for your answers.


On 5/28/21 11:23 AM, Srinivas Kandagatla wrote:
> 
> 
> On 05/05/2021 11:42, Nandor Han wrote:
>> In order to have a robust system we want to be able to identify and take
>> actions if a boot loop occurs. This is possible by using the bootcount
>> feature, which can be used to identify the number of times device has
>> booted since bootcount was last time reset. Bootcount feature (1)
>> requires a collaboration between bootloader and user-space, where
>> the bootloader will increase a counter and user-space reset it.
>> If the counter is not reset and a pre-established threshold is reached,
>> bootloader can react and take action.
>>
>> This is the kernel side implementation, which can be used to
>> identify the number of times device has booted since bootcount was
>> last time reset.
>>
> 
> If I understand this correctly, this driver is basically exposing a 
> nvmem cell via sysfs.
> 
> Firstly, This sounds like totally a generic functionality that needs to 
> go into nvmem core rather than individual drivers.
> 
> Do you see any reason for this not be in core?

I agree that exposing a NVMEM cell via sysfs does look as a generic 
functionality. However, the bootcount feature contains also a magic
value that needs to be taken in consideration when extracting the
bootcount value. The size of the field storing the magic and value combo
is configurable as well. The driver will handle this values 
transparentlry for the user and expose only the validated
bootcount value. In case we will only use a generic implementation for
exposing a NVMEM cell via sysfs the aformention functionality will have
to be handled by userspace and this will force the userspace to have
knolwdge about bootcount value format and magic since they will have
to implement it's own functionality about this. In the current solution
the user only have to reset the value to 0 and that's it, the driver
will take care of the rest.

> 
> Secondly, creating sysfs entries like this in probe will race with 
> userspace udev. udev might not notice this new entry in such cases.

Thanks for point this out. I will have a look how to fix this. I'll 
appriciate any advice.

> 
> Thirdly, You would need to document this in Documentation/ABI/
> 

I'll do that.


> Finally I noticed that the changes to snvs_lpgpr.c  have not been cced 
> to the original author.
> 

Sorry, my mistake. I will add it in the next patch-set.
<snip>

-- 
Regards,
    Nandor

  reply	other threads:[~2021-06-01  7:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 10:42 [PATCH v4 0/4] Bootcount driver using NVMEM cell as backend Nandor Han
2021-05-05 10:42 ` [PATCH v4 1/4] dt-bindings: nvmem: Add bootcount-nvmem Nandor Han
2021-05-05 10:42 ` [PATCH v4 2/4] nvmem: bootcount: add bootcount driver Nandor Han
2021-05-28  8:23   ` Srinivas Kandagatla
2021-06-01  7:58     ` Nandor Han [this message]
2021-06-03  8:03       ` Srinivas Kandagatla
2021-06-23 10:55         ` Vesa Jääskeläinen
2021-05-05 10:42 ` [PATCH v4 3/4] nvmem: snvs_lpgpr: use cell stride for regmap size calculation Nandor Han
2021-05-05 10:42 ` [PATCH v4 4/4] nvmem: snvs_lpgpr: support two bytes NVMEM cell size Nandor Han
2021-05-27 10:44 ` [PATCH v4 0/4] Bootcount driver using NVMEM cell as backend Nandor Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a456396b-3950-7bd2-8f5c-af2699276f82@vaisala.com \
    --to=nandor.han@vaisala.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tomas.melin@vaisala.com \
    --cc=vesa.jaaskelainen@vaisala.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®