mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Zink <j.zink@pengutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, daniel@ffwll.ch, sam@ravnborg.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org,
	airlied@gmail.com, kernel@pengutronix.de,
	patchwork-jzi@pengutronix.de
Subject: Re: [PATCH 1/2] dt-bindings: display: simple: support non-default data-mapping
Date: Thu, 4 May 2023 09:35:59 +0200	[thread overview]
Message-ID: <a45ac6da-8e29-9b2d-6172-8bc043afc415@pengutronix.de> (raw)
In-Reply-To: <b4cb0a91-26f9-94d6-4bde-87cfc9ba2a47@pengutronix.de>

Hi Rob,

On 4/19/23 08:29, Johannes Zink wrote:
[snip]


>>
>> Why do you duplicate what's in display/lvds.yaml?
> 
> I don't think any of the other properties from display/lvds.yaml 
> currently make any sense to be put into simple-panel, thus I selectively 
> picked this one.
> 
> If there is a way to selectively pick only the data_mapping, please let 
> me know and I send a V2
> 
>>
>> This also just made 'data-mapping' valid on non-LVDS panels.
> 
> what is the canonical way of restricting the data-mapping property to 
> LVDS panels only? Or ist the proper way to go to move the panel I use 
> (innolux,g101ice-l01) to its own yaml file, include panel-simple.yaml 
> and leave the others alone? I think other LVDS panels might benefit from 
> this series though, which is why I think it makes sense to add the 
> property to all LVDS panels.
> 

gentle ping. How do you suggest should I proceed here? Maybe pulling the 
data-mapping definition in a separate file and include it in both files?

Can I enable the property selectively, e.g. only on the 
innolux,g101ice-l01 panel, in order not to enable it on non-LVDS panels 
or on LVDS-panels which might not support it?

Best regards
Johannes

[snip]
-- 
Pengutronix e.K.                | Johannes Zink                  |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |


  reply	other threads:[~2023-05-04  7:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 16:11 [PATCH 0/2] Support non-default LVDS data mapping for simple Johannes Zink
2023-04-14 16:11 ` [PATCH 1/2] dt-bindings: display: simple: support non-default data-mapping Johannes Zink
2023-04-18 21:20   ` Rob Herring
2023-04-19  6:29     ` Johannes Zink
2023-05-04  7:35       ` Johannes Zink [this message]
2023-04-14 16:11 ` [PATCH 2/2] drm/panel-simple: allow LVDS format override Johannes Zink
2023-04-17  4:46   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a45ac6da-8e29-9b2d-6172-8bc043afc415@pengutronix.de \
    --to=j.zink@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patchwork-jzi@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®