From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbdAZVsz (ORCPT ); Thu, 26 Jan 2017 16:48:55 -0500 Received: from mout.web.de ([217.72.192.78]:52981 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbdAZVsu (ORCPT ); Thu, 26 Jan 2017 16:48:50 -0500 Subject: [PATCH 3/3] virtio_ring: Use kmalloc_array() in alloc_indirect() To: virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" References: <61829748-a13d-42e4-8f6c-103ee5ca2c88@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Thu, 26 Jan 2017 22:47:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <61829748-a13d-42e4-8f6c-103ee5ca2c88@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:VWrq7qCQDKZiKmCoYGZJhyAQSZuiHzc8S+TYdfMUuRh+VxkGiBK +EwMiq8bmoBXNoNRPMeVcRv2K7SPhcFMT8/rtO/tTpLnMKItgZt3FI7c+42UQ+7hREZcSeZ Rq45dxiC+aytl5zgh35719QaxfjBhMN230FT24zMLHFGf8tp3JwFwIf7tvpnWd8/NivjsWX mlKNNO1gckdAW3K6mxGfQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:jVfGD8ACakQ=:ZYU+nSzLFpkvvwfr+OqH+N /2JpZR96KOyBi4q7QoxZvzWtbRZyP8sht1mriL65jhuB1DnSSaMPGv5FbSlHACs8k1touarjM ZTL0LabWzWopF8AVXLyUaoAdt6AHuaNYYwkSOZ0ABpY1xN0WkAPon8r2cMhu1duXHXaTYPCUq 4J/LOCb0hy3YbTk1cBohornMpPXJgaoB8GjiWjHxHtN+GomEmK/kUflBbzo1GW6DA0Dc384DQ SDzU2GFBZv/bYp1MnIl5yLe0yhf75T8Z2uwuiYiodJzzBwW2tvVVNwhI+AQlk7OrLEehSSq96 eCRYrRbVB45suxJUNubwcAQwhb4o6LOYXvvzFiPb11S59x2fxQ9+tFLQ3ilFCRyGgoFa4Y3O4 LT5HusTJywr82zCNhw9ak2ht7z+w6WAn5U08TnFv9SHbipaTCQTe4A3SjKLNZCAzAKihfwbgN D/wlh66R0tYV/iOTCjU6vWynYwXFaH/K/V2c6gDB0etXBhDH5SYo/RhQ68t93v0cQ70eRND3z sggPE/d56FYSxahEXIj30FRBWpCLRYOo9+bmsQ1uuwAAQzvCNkPkV2ra1t8VHkwle++cQLmuu m2kaIF34cOPDD9HosCfG0NKTO6szjKfG/aBkdr1K4KAooN0ELhBumrRvkHiC7Vwk/2Zelpitr AAaQ+olV72dD/te/ZMaC3NqxH0KzWDIVIvWgoUbGx3+J8QTp/hdh6wbWPuiWAO2VR53/j8Y8X USoLzUFOwR6L999U80YJwo6sOA1ZpxYORC66j8/dPcCvkqdSEwWJpQ+Vqj6xAFijdI+r0AFTF Oy+7ElY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 26 Jan 2017 22:30:45 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/virtio/virtio_ring.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 409aeaa49246..34b6b694298c 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -247,8 +247,7 @@ static struct vring_desc *alloc_indirect(struct virtqueue *_vq, * virtqueue. */ gfp &= ~__GFP_HIGHMEM; - - desc = kmalloc(total_sg * sizeof(struct vring_desc), gfp); + desc = kmalloc_array(total_sg, sizeof(*desc), gfp); if (!desc) return NULL; -- 2.11.0