From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932762AbcGLBvx (ORCPT ); Mon, 11 Jul 2016 21:51:53 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:50288 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932542AbcGLBvt (ORCPT ); Mon, 11 Jul 2016 21:51:49 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: devicetree@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <89b815cb461f167e93185909edde11d5> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 3/3] Documentation: mmc: add description for new no-sd* and no-mmc To: Rob Herring References: <1467359130-11409-1-git-send-email-shawn.lin@rock-chips.com> <1467359130-11409-4-git-send-email-shawn.lin@rock-chips.com> <20160711135735.GA18339@rob-hp-laptop> Cc: shawn.lin@rock-chips.com, Ulf Hansson , Adrian Hunter , Jaehoon Chung , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , devicetree@vger.kernel.org From: Shawn Lin Message-ID: Date: Tue, 12 Jul 2016 09:51:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160711135735.GA18339@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2016/7/11 21:57, Rob Herring WROTE: > On Fri, Jul 01, 2016 at 03:45:30PM +0800, Shawn Lin wrote: >> This patch adds description for no-sd, no-sdio, no-mmc. We >> expect the specific boards adds these in DT to improve >> the initialization. For instance, for a soldered eMMC slot, >> we could skip sending SDIO and SD commands to probe its card >> types as it's always should be the type fo MMC card. >> >> Signed-off-by: Shawn Lin >> --- >> >> Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt >> index ecc007a..b2046c6 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc.txt >> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt >> @@ -49,6 +49,9 @@ Optional properties: >> - mmc-hs400-enhanced-strobe: eMMC HS400 enhanced strobe mode is supported >> - dsr: Value the card's (optional) Driver Stage Register (DSR) should be >> programmed with. Valid range: [0 .. 0xffff]. >> +- no-sdio: skip sending sdio cmd during initialization >> +- no-sd: skip sending sd cmd during initialization >> +- no-mmc: skip sending mmc cmd during initialization > > I still have issue with the description for these properties and the > commit msg. They are fine if described as controller limitations as Ulf > described. If folks want to (ab)use the properties for just skipping > init, then that's their problem. Sounds like it's okay for you if I amend the commit msg and drscription to emphasize that these properties are intent to describe the limitations of controllers rather than to skip init. I will fix them. Thanks. > > Rob > > > -- Best Regards Shawn Lin