From: Andrew Lunn <andrew@lunn.ch>
To: Jay Monkman <jtm@lopingdog.com>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
Arndt Schuebel <Arndt.Schuebel@onsemi.com>
Subject: Re: [PATCH 1/4] dt-bindings: net: Add bindings for onsemi NCN26000 PHY
Date: Mon, 18 Sep 2023 18:31:13 +0200 [thread overview]
Message-ID: <a467d803-3c71-4008-8d6e-7bb03128ea44@lunn.ch> (raw)
In-Reply-To: <ZQf1LMnICzEnt9XK@lopingdog.com>
> +properties:
> + description: |
> + Sets the transmitter amplitude gain. If not specified,
> + gain is set to 1.0V (1v0)
> + tx-gain:
> + enum:
> + - 1v1
> + - 1v0
> + - 0v9
> + - 0v8
How is a gain in volts? Isn't gain just a multiplier, so it unitless?
> + tx-slew:
> + description: |
> + Sets the slew rate of the TX line driver output. Defaults
> + to slow if not set.
> + enum:
> + - fast
> + - slow
How does this map to a standard? I would expect the standard to
specify the slew. So why is this needed?
> + dig-slew:
> + description: |
> + Sets the slew rate of the digital output pins. Defaults
> + to slow if not set.
By Digital output pins, do you them the GPO pins you are adding a GPIO
driver for?
> + cmc-comp:
> + description: |
> + Sets the common mode choke resistance (CMC compensation).
> + Defaults to 0-0.5 ohm (0p25) if not set.
> + enum:
> + - 0p25
> + - 1p38
> + - 3p00
> + - 3p37
What is the mapping between 0-0.5 ohm and 0p25? Can we just use ohms
here?
> + plca-precedence:
> + description: |
> + Enables PLCA precedence mode. Defaults to off if not
> + set.
> + type: boolean
What is PLCA precedence? Should this be an ethtool parameter, along
side all the other PLCA controls?
> + eni-mode:
> + description: |
> + Enables Enhanced Noise Immunity mode. Defaults to off if
> + not set.
> + enum:
> + - force-on
> + - force-off
> + - auto
phy tunable?
> +
> + tx-pkt-loop:
> + description: |
> + Enables packet loopback mode. Defaults to off is not set.
> + type: boolean
How does this differ from struct phy_driver::set_loopback()?
> + unjab-tmr-disable:
> + description: |
> + Disables the Unjab Timer. When disabled, device transmission
> + will be stopped due to a jabber error and only restarted on
> + device reset. If not set, this defaults to enabled.
> + type: boolean
> +
> + col-disable:
> + description: |
> + Disables collision masking. Defaults to enabled if not set.
> + type: boolean
I could be wrong, but this feels like an SDK dump of all the features
the device has, but nobody will ever user in reality. We need some
justification why all these properties are really needed, and ideally
a .dts file for a board actually using them. If there is no user, i
suggest waiting until somebody really does need them.
Andrew
prev parent reply other threads:[~2023-09-18 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 6:58 Jay Monkman
2023-09-18 16:31 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a467d803-3c71-4008-8d6e-7bb03128ea44@lunn.ch \
--to=andrew@lunn.ch \
--cc=Arndt.Schuebel@onsemi.com \
--cc=devicetree@vger.kernel.org \
--cc=jtm@lopingdog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®