From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99F2338B7C1 for ; Mon, 2 Mar 2026 09:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772442532; cv=none; b=RML6RwAjAU0bLhgwgKUYAKfFpNsIxPK+vrOKrza3Ql91M+opLFYw0KVHKy75lmqyJGrB6o6C4Us6jTLXkCzh8AaQYzPshZR7rq3mpZi6GDAWEn6tQxnU+902ya2Us0WnIwa7zIjd8anxUfSV+ZYJuXiQZTagsAThRA15rZh5zjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772442532; c=relaxed/simple; bh=m79/X+bzTpXZL9AiiyjJ6wo5Md/bncCfMY3V5a10w4Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sqIclxCxWaAwbatlTc5bG323lIOHqMlTsdEkJnj2eEslNWJg802acI8+Yrtk261oBkS6VGDGF4c6bDkcEoTjf9BNaZ6llK5b/05lSSsOBdFMP6+xUDCWBLcceFPupSshCgrGNeO96hMxEGmU9XWLpBneWruF9ZY02EBv9M38m9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ls3MwxnS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A0qYREoQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ls3MwxnS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A0qYREoQ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6227qbuq2185340 for ; Mon, 2 Mar 2026 09:08:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gwaj2fAAVlaePOzG7WDXhDqR0zvBqc8L7FKmuItcwFw=; b=Ls3MwxnSvG7BIlnK IyfnLH5p9oe0dLepe1a+nqOGmpRu/4qG+sSO2gKmIHFKo06/ya1XPUOlwIW8eJLo 2pI6ZrmU7TWboPLUzkOpLJrZS0MdecFq3rnqNKndUzd3HTHAzh2h05tEBXCHKNWw UUnXHYIFMOHVnoduZQXFCNyXoMdMckQOumOzGjKlJMap5hlsoeJjDo95nd5KKVrk MLS5arA2twyVRrIQrypnewUMTD/4e7RD6eerC/2c4QVVBBTiAfeeZg5qDvJoZUCv 4ZHwYUF9OM8jLqjubqvJqSVdZEqjaym+yMXm0R4xenGrRwgqPN/2Bum3YHPUdqNR Hf4F2A== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksg74ty2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 09:08:50 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b630b4d8d52so2760259a12.3 for ; Mon, 02 Mar 2026 01:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772442529; x=1773047329; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gwaj2fAAVlaePOzG7WDXhDqR0zvBqc8L7FKmuItcwFw=; b=A0qYREoQARxtPBKXuwQB13IAp/GOvAXMjy66p/XI8tqvlimQDTXILK+uA7M1lOQ61h 4HkpuWfJqjQlSdkzhTmR++lZYswMo5uapdAjUXy0eezz6rTYAOkpM00RYFNefDZhme04 d3cDmitIFjn9hZC8i/VYoIfI8Z9MlcWX+d8OJVen77DJEPnRZqMoUamPuuvLpR9rMftR 36bouWF0XJ3b0ciIkKtfbse7u6EyFt/jhK5v8XztN+EYkz8N8Ih4tTKqYhTs9hMv9QxE 0fgDtJ4ZQ3OX1Nrvl31IakbRGw3EflgHbxWViGdzznl4bpZkay95ij3ukKWVhnFN2gAP yiRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772442530; x=1773047330; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gwaj2fAAVlaePOzG7WDXhDqR0zvBqc8L7FKmuItcwFw=; b=bTMzxLccn09NntWYaXdBEV7/wVpSlPZbW10UHtHcDOORCDdNBDmYnVH3d0bCKD2oep N31m+fBsnWA6eqWxDeMh1+zamMSK/HI0f/0mZn7qcRpm50j/Gq4pGjq9UicaKoGRFck3 gpvaStWaIFW4e4nSYPXh7kXyzggxqt1oFEQVL5ZcQdjxcGNKNV+9CPRON8RJc3pxecai p1F5m07Z8/AGaJtv396nvFEMH/fNNfY2UwluCOskkwteAPqd5KwTLCIsOavhNZYyvFwM F9CfOs85Tc3PlVGJiYlhg9f+Y1UqhwUbJfygD1uHg3+gTCAe/4IvlPMvfxxVEPRhYZGV X73A== X-Forwarded-Encrypted: i=1; AJvYcCV125Uk3wBEty2scBDuEjOmrfxguEgTMl0wb3QbmR3sgf33uUh0jLVh8ybthw0aFehWyIMDe88im7A3lok=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ4TxMAX/eYoEGOk5q5Yf5SwLJmLV4zWanNIzp0e/Ll/3wm0+L 7DCHa7+qcZkIxHI/C19AHl53kBNbKWQQ/Fg7XbgQvqjqbCjnFGXmpl7t2OE8knHxI+JUeHH5fug YcXFhWKeue/nIT5tyZDQXUNXMGnh9KC8HTIOmy6IdxAu0mrbk4laJK8pisjRNfKvnSoI= X-Gm-Gg: ATEYQzz86m7bYP9qbKhD6AWTFzoS/DR8ABxx/YwzO6NcaNA4UuCnAITPiNU62dU0ZG3 KlOc+oE7JomHriRS7Auz5a4ENezBHlDNh9zXl/BS7PcyGO8XO7o9RIleS03IBUCHxQyNuoz77pL tmN062wq6Ikj8mpYToFfRalCK45DnMGM1hYyiI8W2KCZW5b8nkbyy8DFKocaw9JoycSOtx1xt+w 188uLc5Un2RsbXLLtodeGKkG0u5g3YcxN/f3Hx3xUJ5kV6GPqmk4J4XCzycJjZH8E17YsCvP7S+ uUxnkR3lmiHVa/d0CVU3s8vuTJVH04DZNpr02xndOMFFaggCcKa70SZzNFv6MGa5YtOhcVWz2Gl iVLk5E4m8Z8XgLrDH+jiLGc25sMdtIc7XhZaooIGKgg3HPfuQBg== X-Received: by 2002:a05:6a00:22d2:b0:81f:5238:5560 with SMTP id d2e1a72fcca58-8274d93af23mr10970989b3a.13.1772442529568; Mon, 02 Mar 2026 01:08:49 -0800 (PST) X-Received: by 2002:a05:6a00:22d2:b0:81f:5238:5560 with SMTP id d2e1a72fcca58-8274d93af23mr10970955b3a.13.1772442529070; Mon, 02 Mar 2026 01:08:49 -0800 (PST) Received: from [10.206.99.28] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff1c9esm13696576b3a.32.2026.03.02.01.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 01:08:48 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 14:38:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 11/18] accel/qda: Add GEM_CREATE and GEM_MMAP_OFFSET IOCTLs To: =?UTF-8?Q?Christian_K=C3=B6nig?= , Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Dmitry Baryshkov , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-11-fe46a9c1a046@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 7RwsF7uYBvC1452a20_p4aHzdYKKe9VS X-Proofpoint-GUID: 7RwsF7uYBvC1452a20_p4aHzdYKKe9VS X-Authority-Analysis: v=2.4 cv=FaA6BZ+6 c=1 sm=1 tr=0 ts=69a553a2 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=ukUgU1k7PXLouMuqi7QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3OCBTYWx0ZWRfX1NdP0lv1CrZw QXrcMotpd45Mn8X9giDBsEugTBx4goX/vfc4yrGF2BTw+IuYoKTWtl6m+BfOIrFOcoHMSORCe14 a5/JRB5OlUwMXheLDz9JZ85i/aD0Vt3LNppwgtG50dsMVUm0cJVRuM/Eg3yr+WR0VGBtDEGhQZC grEV4Gkl6DSAVQqL3m8qAqjD/YxplFk46XhR2s+5SGjhKLKiIEa7NCOES/sRb4K1FlCK6bjZ2wd 3iw3xmxsX1SIs3fjhyXZFNEvHwArvgYPPfB7KBLPDCB/R3XpO0GjgfzEXNg4oPLEQm8Yvt71Zpn GL2/emHkA1RZWOB9HixZLJYzk2WDHhBLGe5yRd+2/k+pNuxF2SNCKcCyOWyUPJzENi7dVc43oKj 0SHARaBvJksCNoGujQBLcUp5NgBxAaPXm5yBEXDL65cUkmhQSVv3TJpqIcNWMOGeNupb2I+JJiM OLPuOJgGlbEM2yL3FlQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020078 On 2/24/2026 2:35 PM, Christian König wrote: > On 2/23/26 20:09, Ekansh Gupta wrote: > ... >> +int qda_ioctl_gem_mmap_offset(struct drm_device *dev, void *data, struct drm_file *file_priv) >> +{ >> + struct drm_qda_gem_mmap_offset *args = data; >> + struct drm_gem_object *gem_obj; >> + int ret; >> + >> + gem_obj = qda_gem_lookup_object(file_priv, args->handle); >> + if (IS_ERR(gem_obj)) >> + return PTR_ERR(gem_obj); >> + >> + ret = drm_gem_create_mmap_offset(gem_obj); >> + if (ret == 0) >> + args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node); >> + >> + drm_gem_object_put(gem_obj); >> + return ret; > You should probably use drm_gem_dumb_map_offset() instead of open coding this. > > Otherwise you allow mmap() of imported objects which is not allowed at all. Thanks for pointing this, Christian. I'll read more about this and fix as per your suggestion. > > Regards, > Christian.