From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755433AbdEHPJE (ORCPT ); Mon, 8 May 2017 11:09:04 -0400 Received: from mout.web.de ([212.227.17.12]:64958 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754865AbdEHPJC (ORCPT ); Mon, 8 May 2017 11:09:02 -0400 Subject: [PATCH 1/3] mtdswap: Reduce function calls for sequence output in mtdswap_show() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger Cc: LKML , kernel-janitors@vger.kernel.org References: <82e905b5-3958-be81-b0ee-d0a2805154df@users.sourceforge.net> Message-ID: Date: Mon, 8 May 2017 17:08:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <82e905b5-3958-be81-b0ee-d0a2805154df@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:49CWe67ntQhU2Hfa5mB7voOSlpjmyOAaL89iXpZfc0HV+oMl6bI ADiy8kBiDvl7I+tdWrcud5k4cJOUIYu1jMa58nVPnEe17jMwNI5pNtIBZhCP3WGzV/tV9bR U6sfFGdkXjzVDqzH0GRx6gQnrEmR5YeXDGNNWUwomJaRqBkBkqWT2hYhklzioryVu/Q0Z2i 8XrgVemtT2zwcFLOCQPvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:3eh1TRqV13I=:HWjfpSlHAhUam6B+FTsnm3 3RlLfY2mU/Y+WVx+EnaK7R9GxEscoUAe7jN0xcS5M8+fpx50Q9no6VUOcOxhIoKzjvN5Kk1ve QvQrPsmjX14aztFFvbzFbYKLQ6mbFsNxk8W7xFcVqsa8UMBT2+p6bYKKzuq9YfnxEORmQhbWo r91o1NhaaRrZORK5SjPelpDpynWzNtuE4OFEqxdh8dDu0C1GCgQZvNp2Pg0Hdgy/eVx0Rei8b VmVai3tUxy7Cw5plrZbp4LkhRXkY0N0GnRbadSApZGiRmHhmd+d7RHO7H5Kzf5mL13jO70Yar 2AfFMDMQtpfwQVe+THFzjWq9rCvTgWItGpPUyI2i0ET9pXQyCdZvJuEbniuvxTccctdFnY3h2 3qqTcEfcvXAC2rmj+YDhWVG9HMnLAiB25+RXKTt70Y6IHcNAus81d56XRVovdCpuqPtzs4fbZ hbWiOSyrfIbdSVsL86fYrLhA94Y0owdTpVLBEPU4rJKkm6lT1ryXqDyAQHo+5pfvaosrqkDJ6 alU2AEWT0QTVv8nZaDr4ktoEZehgw25NsPSWiqrjfxXGRNFAJSZz6rxU4M6yJQ6ipP6WpSuY4 IyYjnZtwcE1eP/sZL1BCuD9g1zJ9vB94U0i3MH4VTrMX6Hse9zI43OM7rI46eJ8mxD6reQWOJ WKJNo3BDSeMA3cmEmrU9/iqaDf22L5JAdBBxCqR4oKcdCVwGzLUehTDFPb601zZFOryQHbdYN 5tKFPzK06Kw98/ogV9ra/+QWEpxab/NaWErMEjcPQkGWLM+AYi8XQyt0POPbh5mOrVM63JraC VQzplED Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 8 May 2017 16:02:34 +0200 Two line breaks were put into a sequence by separate function calls. Print the same data together with adjusted seq_printf() calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/mtdswap.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index f12879a3d4ff..0805f45c5139 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@ -1283,19 +1283,14 @@ static int mtdswap_show(struct seq_file *s, void *data) "erased %u times\n", cwp, d->pages_per_eblk - cwp, cwecount); - seq_printf(s, "total erasures: %lu\n", sum); - - seq_puts(s, "\n"); - + seq_printf(s, "total erasures: %lu\n\n", sum); seq_printf(s, "mtdswap_readsect count: %llu\n", d->sect_read_count); seq_printf(s, "mtdswap_writesect count: %llu\n", d->sect_write_count); seq_printf(s, "mtdswap_discard count: %llu\n", d->discard_count); seq_printf(s, "mtd read count: %llu\n", d->mtd_read_count); seq_printf(s, "mtd write count: %llu\n", d->mtd_write_count); seq_printf(s, "discarded pages count: %llu\n", d->discard_page_count); - - seq_puts(s, "\n"); - seq_printf(s, "total pages: %u\n", pages); + seq_printf(s, "\ntotal pages: %u\n", pages); seq_printf(s, "pages mapped: %u\n", mapped); return 0; -- 2.12.2