Re: [PATCH] params: Add support for static keys

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 10/05/2025 à 23:01, Kent Overstreet a écrit :
> Static keys can now be a module parameter, e.g.
> 
> module_param_named(foo, foo.key, static_key_t, 0644)
> 
> bcachefs is now using this.
> 
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Petr Pavlu <petr.pavlu@suse.com>
> Cc: Sami Tolvanen <samitolvanen@google.com>
> Cc: Daniel Gomez <da.gomez@samsung.com>
> Cc: linux-modules@vger.kernel.org
> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
> ---
>   include/linux/jump_label.h  |  2 ++
>   include/linux/moduleparam.h |  6 ++++++
>   kernel/params.c             | 35 +++++++++++++++++++++++++++++++++++
>   3 files changed, 43 insertions(+)
> 
> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> index fdb79dd1ebd8..0fc9b71db56f 100644
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -107,6 +107,8 @@ struct static_key {
>   #endif	/* CONFIG_JUMP_LABEL */
>   };
>   
> +typedef struct static_key static_key_t;
> +

Please read https://docs.kernel.org/process/coding-style.html#typedefs

I can't see the reason for a new typedef here. If there is a valid 
reason please explain in the commit message.

Christophe