From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C416307481 for ; Wed, 15 Jul 2026 14:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784125135; cv=none; b=QhTT4QGqtqQjMm151xY1GpIIzdocvFbmPtUhr5Hp4Cj3k1H22JvhTaQwInKn8geCpk4siEPcN/YrbKtarDMWqDN1WiiDSiCrgTIwkKmyTXb1eMGlDUx2VyW0WTGKHZNRCjBAncAWfh9D9d8COzaZd66FKas7O3uTEdDMXolRufQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784125135; c=relaxed/simple; bh=4pQVkM9WBlO2vZEiiX+bLHbTyBfnEvBkqXZimCFqLzk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=OfjbLTsIhMDLZmpaFaqp/L80pNXJvgIw0zxw1DgDp+JLnMgHW995YuI4Ju+0fDjno/pqxtq66ehHo8pyVPzwRRdGBVP8NrK21sShhs7XkozJAJ4mXx9yunJURrZSPL7kRwZ3IeQztn5/IkBDS3DfyOwxg2L7+g/v+v2Z1veRMBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NSqFZan9; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NSqFZan9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784125134; x=1815661134; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=4pQVkM9WBlO2vZEiiX+bLHbTyBfnEvBkqXZimCFqLzk=; b=NSqFZan9XJqhoENFsVTZA2tgDZidK7Ba05PGOXtxbO0avRt/9xajxUxS N+hZfZB/M5D5E+cAO62F1f5p2/DeRLnd3j+6D2HqLI0i9XCLT7VVW3FQO lKS4M2/X1XS0q8dN6rpBZNJJLlLW5YFCtZEmMleuNzcAddcziJF5e9AGz POgppNc9viV14ovRl0POSZgfiyZi1szw8FnwrL/t9H2o+kaFKfWYqoGKM bjtWRAnBoymnsLIOiX5VqK4cxubWrlGYxMDLeA0tyV1uizWtR0qtmfNGw CZmlCNkU7LSlYSfCXZiuNsDuj3p6E3n3ioNNzw2mNNVWpgqANiDK7L8lN A==; X-CSE-ConnectionGUID: azl5R9b8TyCSd76aYmZMjQ== X-CSE-MsgGUID: G88tWjC2QaCaOwcqxb+pVw== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="95364452" X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="95364452" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 07:18:53 -0700 X-CSE-ConnectionGUID: +mB4D5dkQ8+P3dLhZmOkfQ== X-CSE-MsgGUID: g4UT7WH3Tm2EgfctWuLglw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="259783028" Received: from jakomppa-mobl.ger.corp.intel.com (HELO [10.246.16.242]) ([10.246.16.242]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 07:18:51 -0700 Message-ID: Date: Wed, 15 Jul 2026 16:18:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] accel/ivpu: Reject firmware log with size smaller than header From: "Wachowski, Karol" To: Jhonraushan , Andrzej Kacprowski , Oded Gabbay Cc: Jacek Lawrynowicz , Stanislaw Gruszka , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260715074206.867712-1-raushan.jhon@gmail.com> <68d6db92-5e48-477f-ba97-d116480e0636@linux.intel.com> Content-Language: en-US In-Reply-To: <68d6db92-5e48-477f-ba97-d116480e0636@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15-Jul-26 10:21, Wachowski, Karol wrote: > On 15-Jul-26 9:42, Jhonraushan wrote: >> fw_log_from_bo() validates the tracing buffer header_size and that the >> log fits within the BO, but never checks that log->size is at least >> log->header_size. fw_log_print_buffer() then computes: >> >>    u32 data_size = log->size - log->header_size; >> >> which underflows to a near-U32_MAX value when firmware reports a log >> whose >> size is smaller than its header. That huge data_size defeats the >> log_start/log_end bounds clamps added by commit dd1311bcf0e6 ("accel/ >> ivpu: >> Add bounds checks for firmware log indices"), so fw_log_print_lines() >> reads >> far past the small real data region of the BO. A size of 0 also makes >> fw_log_from_bo() advance the offset by 0, causing the callers to loop >> forever on the same header. >> >> Reject logs whose size is smaller than the header (which also rejects >> size == 0). >> >> Fixes: d4e4257afa6e ("accel/ivpu: Add firmware tracing support") >> Cc: stable@vger.kernel.org >> Signed-off-by: Jhonraushan >> --- >>   drivers/accel/ivpu/ivpu_fw_log.c | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/drivers/accel/ivpu/ivpu_fw_log.c b/drivers/accel/ivpu/ >> ivpu_fw_log.c >> index 275baf844b56..716467aa3156 100644 >> --- a/drivers/accel/ivpu/ivpu_fw_log.c >> +++ b/drivers/accel/ivpu/ivpu_fw_log.c >> @@ -43,6 +43,10 @@ static int fw_log_from_bo(struct ivpu_device *vdev, >> struct ivpu_bo *bo, u32 *off >>           ivpu_dbg(vdev, FW_BOOT, "Invalid header size 0x%x\n", log- >> >header_size); >>           return -EINVAL; >>       } >> +    if (log->size < log->header_size) { >> +        ivpu_dbg(vdev, FW_BOOT, "Invalid log size 0x%x\n", log->size); >> +        return -EINVAL; >> +    } >>       if ((char *)log + log->size > (char *)ivpu_bo_vaddr(bo) + >> ivpu_bo_size(bo)) { >>           ivpu_dbg(vdev, FW_BOOT, "Invalid log size 0x%x\n", log->size); >>           return -EINVAL; > > Thanks for submission. > > Reviewed-by: Karol Wachowski Applied to drm-misc-fixes.