From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5548176AAE for ; Wed, 18 Sep 2024 09:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726652432; cv=none; b=GSHJ4+G0USKZDsNbwGISwjITyXfmm8WuPrVqVLYL2YiJ9MDhmu/DvmCFyKRkGpXeX1MpadE1IG28P/5abPOpDmEuWBszYnbz+kg/6TTIDDfckwG2LTEe8RGCcrhaoR72vY309q3bQs4xXZLbuLRgpzA9CUHuFbd/ma5/8dFZQ54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726652432; c=relaxed/simple; bh=sa/Z3gBxGkduZ21tgEojAUz0JuOfKH3xqjWZecw5e8E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r7SNavH5y/dHUW4KHwJGcipvxKWcefFXcaVrFUUthyI9kyvhldmwwAVIYfXzjL3xGBC1P7AALPxqO5N2tC5I6VZE8PaTf3DbCZs+l2cO+eU42JVVY8tHBr2EdTdHLgN7JcNJ+IihWAo9tD2cXU/r7/tRmETRkZEjMAOYlFnLAZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b=nACpbfgo; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b="nACpbfgo" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a7a81bd549eso789767566b.3 for ; Wed, 18 Sep 2024 02:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1726652429; x=1727257229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lecaVNcmA2JjtTGwgjFCKRgWjf3SejBL7F1D6E+FvJw=; b=nACpbfgoyN/D0eHZdEPaDPBpOMk5p5HbZsnX7ddI64OIh+bPGl4W13mpuSyFFNZzJx fq3XnxCghcqldsLkC+2hwj/iDOvxyQMgXVXqTJZLa6D4HOxQLnxuM8jzz9BmE4EvCkqJ 0HbdE/Q+MtZaCcqbzxaVaWJzNNTTJENw2EZaq/+dY3MXKyijqgF7y9215tInT2z1nw+f yHaiCgikubbrDgKPlLlUWSGFKSCpAGLlERCmctjd4ONCXudWGR0Z7Vv/qfnA3ZJQjeIp WgE8RrjPai89DJVCbn6QmtOqXiorCAI8WooUiyR9kPlgJRlXFLi0HUdLS9GuztOoZBUD DQ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726652429; x=1727257229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lecaVNcmA2JjtTGwgjFCKRgWjf3SejBL7F1D6E+FvJw=; b=L/S276jWh/G433NiVHxu4LL2GZwrQX+4aE4b+BFAW4uVaNbcz5tchYTombm1zQnLz7 qfKkBk1x1tkmLXURPklvmBurZ4XgCGZjpRwYUsvbWiCI35Q47rjbsFwwAAO5MqUj+Km6 rBnLOuWT5JRDsiRw2a+Vupsghi33FRPQEiuvQoKlI4xVaCaygz+KEXi8r/lY2bY7iZ7l YsGWm9LYdNVXacdg9vn2gcv0F1hFDnVXy1zuA4uAKUeXecPADjIoFs6qZDNUHdRX2/HH NoRiiYQUC7kQ929hplLGMGoRO9NTp0+NGWaCnWDDEsmxLOkVEVb6GNNY3fO2CEGMwTd+ WHUA== X-Forwarded-Encrypted: i=1; AJvYcCXWeEnoZouR67q6gV7CjfTb9JQpqwsC/cr/lBxOX7hf4Clpv2gS0q5qjot2QeD+u0J+rIZep1GdwRaZREI=@vger.kernel.org X-Gm-Message-State: AOJu0YzpQuUPAwqpE/0yMq+qqfQJBEyzMV7BH93Sec5XnEyln8R2ylGw gzOGRInsy0XBIeLszTU3EMRjqumSWlL2dqhcP4EkNINFirFf8wT3on6+SweSgDc= X-Google-Smtp-Source: AGHT+IEiDtpcBMns4eThOyjvY7vmtUnEvrsljknDy5RtOY/mIovMESzUzkgE3/KMjtr9ngXAVkLERA== X-Received: by 2002:a17:906:cadc:b0:a8a:7501:de21 with SMTP id a640c23a62f3a-a90294ab552mr2114018966b.12.1726652428674; Wed, 18 Sep 2024 02:40:28 -0700 (PDT) Received: from [192.168.0.245] ([62.73.69.208]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90612e5675sm560870066b.169.2024.09.18.02.40.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Sep 2024 02:40:28 -0700 (PDT) Message-ID: Date: Wed, 18 Sep 2024 12:40:27 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] Bonding: update bond device XFRM features based on current active slave To: Hangbin Liu , netdev@vger.kernel.org Cc: Jay Vosburgh , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jarod Wilson , Simon Horman , linux-kernel@vger.kernel.org References: <20240918083533.21093-1-liuhangbin@gmail.com> Content-Language: en-US From: Nikolay Aleksandrov In-Reply-To: <20240918083533.21093-1-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/09/2024 11:35, Hangbin Liu wrote: > XFRM offload is supported in active-backup mode. However, if the current > active slave does not support it, we should disable it on bond device. > Otherwise, ESP traffic may fail due to the downlink not supporting the > feature. > > Reproducer: > # ip link add bond0 type bond > # ip link add type veth > # ip link set bond0 type bond mode 1 miimon 100 > # ip link set veth0 master bond0 > # ethtool -k veth0 | grep esp > tx-esp-segmentation: off [fixed] > esp-hw-offload: off [fixed] > esp-tx-csum-hw-offload: off [fixed] > # ethtool -k bond0 | grep esp > tx-esp-segmentation: on > esp-hw-offload: on > esp-tx-csum-hw-offload: on > > After fix: > # ethtool -k bond0 | grep esp > tx-esp-segmentation: off [requested on] > esp-hw-offload: off [requested on] > esp-tx-csum-hw-offload: off [requested on] > > Fixes: a3b658cfb664 ("bonding: allow xfrm offload setup post-module-load") > Signed-off-by: Hangbin Liu > --- > drivers/net/bonding/bond_main.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index b560644ee1b1..33f7fde15c65 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -1353,6 +1353,10 @@ void bond_change_active_slave(struct bonding *bond, struct slave *new_active) > call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, > bond->dev); > } > + > +#ifdef CONFIG_XFRM_OFFLOAD > + netdev_update_features(bond->dev); > +#endif /* CONFIG_XFRM_OFFLOAD */ > } > } > > @@ -1524,6 +1528,11 @@ static netdev_features_t bond_fix_features(struct net_device *dev, > features = netdev_increment_features(features, > slave->dev->features, > mask); > +#ifdef CONFIG_XFRM_OFFLOAD > + if (BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP && > + slave == rtnl_dereference(bond->curr_active_slave)) > + features &= slave->dev->features & BOND_XFRM_FEATURES; > +#endif /* CONFIG_XFRM_OFFLOAD */ > } > features = netdev_add_tso_features(features, mask); > Nice catch, Reviewed-by: Nikolay Aleksandrov