From: Marek Vasut <marex@denx.de>
To: Mingwei Zheng <zmw12306@gmail.com>, antonio.borneo@foss.st.com
Cc: linus.walleij@linaro.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, make24@iscas.ac.cn,
peng.fan@nxp.com, fabien.dessenne@foss.st.com,
linux-gpio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: Re: [PATCH v4] pinctrl: stm32: Add check for clk_enable()
Date: Fri, 13 Dec 2024 12:45:19 +0100 [thread overview]
Message-ID: <a47b567d-96a6-4a87-9f60-33a311c281ae@denx.de> (raw)
In-Reply-To: <20241213010948.2623382-1-zmw12306@gmail.com>
On 12/13/24 2:09 AM, Mingwei Zheng wrote:
[...]
> @@ -1397,7 +1397,7 @@ static int stm32_gpiolib_register_bank(struct stm32_pinctrl *pctl, struct fwnode
> return 0;
>
> err_clk:
> - clk_disable_unprepare(bank->clk);
> + clk_disable_unprepare(pctl->clks[pctl->nbanks].clk);
Should this be
-clk_disable_unprepare(pctl->clks[pctl->nbanks].clk);
+clk_disable_unprepare(pctl->clks[bank->bank_nr].clk);
^^^^^^^^^^^^^
?
> return err;
> }
>
> @@ -1617,10 +1617,18 @@ int stm32_pctl_probe(struct platform_device *pdev)
> return -EINVAL;
> }
> pctl->banks = devm_kcalloc(dev, banks, sizeof(*pctl->banks),
> - GFP_KERNEL);
> + GFP_KERNEL);
> if (!pctl->banks)
> return -ENOMEM;
>
> + pctl->clks = devm_kcalloc(dev, banks, sizeof(*pctl->clks),
> + GFP_KERNEL);
> + if (!pctl->clks)
> + return -ENOMEM;
> +
> + for (i = 0; i < banks; ++i)
i++
next prev parent reply other threads:[~2024-12-13 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 1:09 Mingwei Zheng
2024-12-13 11:16 ` [Linux-stm32] " Clement LE GOFFIC
2024-12-13 11:24 ` Antonio Borneo
2024-12-13 11:45 ` Marek Vasut [this message]
2024-12-13 13:43 ` Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a47b567d-96a6-4a87-9f60-33a311c281ae@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=antonio.borneo@foss.st.com \
--cc=fabien.dessenne@foss.st.com \
--cc=jiashengjiangcool@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=make24@iscas.ac.cn \
--cc=mcoquelin.stm32@gmail.com \
--cc=peng.fan@nxp.com \
--cc=zmw12306@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®