From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B66619AD90 for ; Wed, 5 Aug 2026 14:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940959; cv=none; b=KHizv2EdOlzdFbkg3W5ZMwAIY2tk4NZgGTDZ9JKBj5n7QzQIlZOGtpFkcyVuLjZ6wBAukA7aJ9fA7gpIjvweNEhHEq3NvxyCK4MmxUBrdggTbOWsfrE4Q3Lm5XvU7hHrOBooAYgqjc1lNgM/EWaRk9dYzPdQnB4eSx2utn+jpeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940959; c=relaxed/simple; bh=ZGZEVljx/pyqH7mFAASrVQDD3tuyOQrKBWVIRv5+8g0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fwXjIqHLXNhF4s1xMub35qwk2LtPTElFWlqkrr/bAFrdXHTvNdg0jBy/7EvwmdrTT/UNhNCL5rl6xZydmkfpvnsLwhtv5xpACzMQ8jsiK+WQNqxeMjVDNMoo2wYOHCnM+77VnG4vfvfg0FADQnBSV12TfgNtU0bOB7Y5glPgv84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b74pPg2K; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b74pPg2K" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f93b2fe4cso746378f8f.0 for ; Wed, 05 Aug 2026 07:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785940951; x=1786545751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ld+XQ0JcCd/3+XlB4VjbGbKYAZ1iedXZLkBJ6yeGTpE=; b=b74pPg2KqVXzpGPapCnbkLL8ZShOuZIwMEmv+Ca4BtOvfBIxN1zftS2/REMSToyqHn JWg7VCxUT0IrlspMx82Ui3D3Y5hTSuDWsmE8rbRdeHcNgEE9QnFtNuObLc8vw4STbF7k TvU7xIZrxm/iI21pp/NPEsiVpRmP4kJhP/AI0KrZtRznd7LasrneTX1X+NI89RTmm+nQ SaIJ5P34nVFYevGGRtjX+fovT+Lqsy+Y0tmgfxdEQPy2UUVeykX9nnebmGOisR1gPnsA Ex5JAk/tmu1pLziiVerafyyfLAkid9IgyV3TjrlkTPaQuVnTVTO7qynedgLcAEgSluau GmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785940951; x=1786545751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ld+XQ0JcCd/3+XlB4VjbGbKYAZ1iedXZLkBJ6yeGTpE=; b=PlRhRs1nq1jRloyKea51+3MQxVTq7+SA+E1+pYlEPh8k10nSH7jKVGzSNMqCYxB4BA JLxLZ2CyhTldAEvDID8RS5v+nNvQipgQhFjg2H6gYVJ9Xbo01T2sdummwgn1uZhAEDIo peu3s3iLD1TFRrV/4og3yBYcGWoy8mHfD4sfIVVJno3b/hsJ24mE7EpaOlzUj0l3B7lx FAmFRFGobGiOjI6PUgUEoVphH/IqVvNMR7zZOgiMx0h23Kw83dAA4vRRFJptAKg158io 2oiqU4CQljcJTiSzFMlKXY7EdMeTP69o5RfyRAuQYsVilb5/5s7tHMVH8RhallJgwSQD 96Uw== X-Forwarded-Encrypted: i=1; AHgh+RrvFnUc3q1nq3WS1HFSJNrjNZt1caQk3tezjqEgI2oLsOrbFo0jMD7UeXxtXkYaTBYmgccKdUq0Xw85ico=@vger.kernel.org X-Gm-Message-State: AOJu0YwdsNXkBG6e1lNr3Z9dlBRriwQgfs+PjYEGzVb42q/KAraNrw2V ne4eBB59i/UU6AqNUcDjQByy0+12cH8FDZc2/TdbE+plZFfynzIG2i7N X-Gm-Gg: AR+sD11tOChy+JkbkkzLWDxc9LyGWRxieiDbt2XKe2AtKXLfbo539s3uhI4ioq/LR+y XyHrz1OIr/FzpyiL1Zxq60X9O+9FBk6EM2xvZxVHW8YU3S/AS/vyeAqNK5Z3h3UKOVl+4UgxZJ3 I2bvMaD89CL3Kv+NxyEzK0SaQ4rQmSQq/g3eXHHg0822CrfCG22iFKKdQ4mG7751mc1GAN6Zuhu e16+lSMOILXXIANBbPhNtOz8tea1orWk+w2MB504K/IjQVkg7/uwhIFa8LqxiBzXdJGjttgTfP9 iloqosnb1IXlaaMnwF56pBg0lnECORvKoUVbC8YCRNih2ZmvGL01jBpDuxKSOFYo3u1pyO9Bxvz +xrrMKrqNFBo6tSBub8V6sugMXGGBkaj5CeGfpkFI1WvP7EEgdCE3CYp2dZh7/uVC5RuRdlkYZx TweSJQ2+VuUZQL/MCq7Zo3+qHG3ZjN7pjsnT1VJivCJU8SRpdtNZdJ01zrmSr6NWidxLFFVP+H5 4+f0ijar4fM X-Received: by 2002:a05:6000:2489:b0:47f:59ef:bbb2 with SMTP id ffacd0b85a97d-47fec634cecmr11644817f8f.17.1785940951438; Wed, 05 Aug 2026 07:42:31 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:6df7:ffe8:d01:255d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232333sm10094289f8f.18.2026.08.05.07.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 07:42:31 -0700 (PDT) From: Avi Weiss To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Soheil Hassas Yeganeh , Arjun Roy , Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH v2 3/3] mm: return -ENOMEM for page-table allocation failure in insert_pages() Date: Wed, 5 Aug 2026 17:42:19 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit populate_to_pmd() returns NULL only when p4d_alloc(), pud_alloc(), or pmd_alloc() fails. These are page-table allocation failures, but insert_pages() currently reports them as -EFAULT. Return -ENOMEM instead, consistent with the subsequent pte_alloc() failure and with the single-page insert_page() path, which reports failure of the same page-table allocation chain as -ENOMEM. Address and range validation failures in vm_insert_pages() continue to return -EFAULT. Keep the later -EFAULT return for pte_offset_map_lock(), which is not an allocation failure. Signed-off-by: Avi Weiss --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 11bb4fb98761..16093479d341 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2438,7 +2438,7 @@ static int insert_pages(struct vm_area_struct *vma, unsigned long addr, more: pmd = populate_to_pmd(mm, addr); if (!pmd) { - err = -EFAULT; + err = -ENOMEM; goto out; } -- 2.43.0