From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB51329C71 for ; Tue, 11 Aug 2026 07:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786432881; cv=none; b=I93uGJnn6NKOSu4xFaBKoddCcg8NnDkX4cfVfJDc3qIxa03SKf34+kRSWIRrxcFQRh+hYLCLs/ZYblvU+6seEtjW8DsXEsSuEXODhHuHhIovb+8DbNK8wDhhLjQRIo63sLYgCC7VayVeWLViARnpKRxCMeg9CtV09YXe48bnpm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786432881; c=relaxed/simple; bh=+ZcBuBQR/2Scsl7hTuevg6AxrPr8GjtEgQxoxhamLmw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=cpS2nyYG4diD+N5O8PeTVgp+UM2kCQJi1EQhs7o6tILWx+aixUj8laCJOW3Bq3c4HyzTP4Vba3XMKDk4DW4HrBWSMHgHRduP6b282glm0izWaNmr/wxRyT9z44NxNRv6WVCOCUtwkocXFAOFqJOuyTYukHqXJ9Qs3lcn0WZf57k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GwPLC04r; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GwPLC04r" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-472326ca506so312968f8f.2 for ; Tue, 11 Aug 2026 00:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1786432878; x=1787037678; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ePOfulUBVBDfXt5o5ewYatlqaR+8+NY1Odh9u68sfA0=; b=GwPLC04rV153FvcJvQk0cBd7HiV1n/P6FUc6GomVQIqAP8YCEJTlQR/fjaEupBEH9h FIucPtIZbhJcsNZEPdbY4hXk9nuXu4jPXnLVdBwVPLaZDYZaZT073CUic8QPie5NyeQm e7fL1jPgyeaVgoHpZr5qixmxDoKKjaiSAKI49q7Ou7cfwiB8lOsqZeCERz/AqCaDwGtF rZS1ks9zbBBO99WFtt7ElKMC3SUL/DKTco7U3VbBjWW6gRuV6I1/e3ecwyV+ewjWiWR8 UpwPed8utICFN8yL9FiiDeAsjwyPYLyYSZ9rh7efH9jj/K4tkXKg3IHWIyEMogXpterI 0NFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786432878; x=1787037678; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=ePOfulUBVBDfXt5o5ewYatlqaR+8+NY1Odh9u68sfA0=; b=HJRmIZ70uPWeUTZtkm5XRUsBjLHbqKPL5WMqXQCB/u4OMugvQVjA2/cap3bNn1Op0S 3AOpGuBKI2vp17frXCYK8JvM4OzLGt95AZUhI7wW2p8mBe05IuoUYo6qNN/7xszFoGT6 wpm3yFkRmngWdGolshR2+7r1eOJeoG863tcHrYec2eXY1eNoUeNCmxpDsWdjOSKM0Ktn UZ5GtqSrj+ErlTorGCOd/KydlcJHe45hUIMPwibhGNmswvTkwTvs8+s1tsXpYqTLlGl+ MShwgiLH8q+VR5eCPZGZxfGnEc1qRxugbQo9p9Prt8urVnseZKfE3BK0Rgz70BiZChnc oL3Q== X-Forwarded-Encrypted: i=1; AHgh+RobXwR2+2IvD/8l/mOSrvAZnmyAvLUXnq5qK2kTMY1pUDwfMtQN9UAwXPkYRgGPOac6+w5YXGvt7KnxQzU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn9qga5Me1l8wXIj5mcjq3wqIaiIil7THhSBdwX0rVi6PrHMwe 1ys5KWsOQRFMMhiagNLKzQeohqD2EsyWbb2C8a8aZWbCP8HGr6gy9SfUmlSK1kmD8ho= X-Gm-Gg: AR+sD12pNAbK3DJEiKV3dqwdSQZq5jxiMR0swddomsBy4nxZggGWuSmQexJz//LSCAQ jGEfbn/Q0VnLKU3nySUu4zGF8mjyCg+kHS1eZvxivLDZyNB8BlFPc+Fkyt0/MjLpkZZnNyAnCui XfYdc3n349E7gkSGr9twzbazuqqVFWW53gbJja7QG7LdK7dXUTVnTKJ08ctORHCzab1s5RTZHF6 ip6jW5+7obhN1xYVUswkI9ZzvPOA59lwp/UjygwIqCGeuD9lMeRrmeNeKdSQHyObDwhrsNT1O9L Ngg7pBsWTYZ7s3EePGPsRJBS92JcoFubHDsAk8S5hermAa/YdfenxQdEpyCbqpQjRVp31kOxsFE baDuFExhu/8Dy2QYSEwvtNbI8TfFaymsL995w04EQ5WiszRGq4wIhQ50bVRS4aR3JXZpWVTF+EI 6pwRcQ9H83KzTSFJw9eAqm82GUiQZBcoFprcE4VOA1vo6R3S4dIxcpT2g7z3BYANffa6DjNdX45 YILCjP/cJBXHf9uWEVEDb40fKaUoRtMvTWRTZz3iT1h8/xD1ORRqeI= X-Received: by 2002:a05:6000:4702:b0:480:6af8:305f with SMTP id ffacd0b85a97d-4814adcac42mr2003606f8f.20.1786432877509; Tue, 11 Aug 2026 00:21:17 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:370e:5b2f:7205:786f? ([2a01:e0a:106d:1080:370e:5b2f:7205:786f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4814a5ac70dsm2644183f8f.5.2026.08.11.00.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 00:21:17 -0700 (PDT) Message-ID: Date: Tue, 11 Aug 2026 09:21:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2] drm/panel: samsung-s6d16d0: Use mipi_dsi_*_multi(); fix minor bugs To: Akash Sukhavasi , Doug Anderson , Linus Walleij , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260810-mipi-dsi-s6d16d0-multi-v2-1-8fcdfbf9bbd2@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260810-mipi-dsi-s6d16d0-multi-v2-1-8fcdfbf9bbd2@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/11/26 01:45, Akash Sukhavasi wrote: > The mipi_dsi_dcs_*() functions used by this driver are deprecated > in favour of their _multi() counterparts, as noted in > Documentation/gpu/todo.rst. The _multi() variants record the > first error in a context structure and skip subsequent calls once > an error is set, removing the need to check the return value > after each command. They also log failures internally, making the > per-call dev_err() calls redundant. > > Convert prepare(), enable(), disable(), and unprepare() to use > mipi_dsi_dcs_*_multi(). > > unprepare() previously returned an error if > mipi_dsi_dcs_enter_sleep_mode() failed, skipping RESET assertion > and regulator_disable(). Because drm_panel_unprepare() does not > clear panel->prepared when the callback returns an error, > drm_panel_prepare() would then return early on the next call, > leaving the panel powered and unable to be re-initialised. The > converted code always asserts RESET, disables the regulator, and > returns 0. > > Also fix a typo in a comment ("Enabe" -> "Enable"). > > Signed-off-by: Akash Sukhavasi > --- > Compile tested only, no hardware available. checkpatch and a W=1 > build are clean. > --- > Changes in v2: > - Keep intermediate dsi variable for readability, per Neil's review. > - Add comment explaining why accum_err is not checked in unprepare(). > - Simplify prepare() to a single return path. > - Link to v1: https://lore.kernel.org/r/20260807-mipi-dsi-s6d16d0-multi-v1-1-c6179f6f3c98@gmail.com > --- > drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 55 +++++++++------------------ > 1 file changed, 17 insertions(+), 38 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c > index 54a65abf7e89..e734fffa45a4 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c > @@ -48,14 +48,10 @@ static int s6d16d0_unprepare(struct drm_panel *panel) > { > struct s6d16d0 *s6 = panel_to_s6d16d0(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(s6->dev); > - int ret; > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > > - /* Enter sleep mode */ > - ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > - if (ret) { > - dev_err(s6->dev, "failed to enter sleep mode (%d)\n", ret); > - return ret; > - } > + /* Enter sleep mode; error does not prevent power-off */ > + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > > /* Assert RESET */ > gpiod_set_value_cansleep(s6->reset_gpio, 1); > @@ -68,6 +64,7 @@ static int s6d16d0_prepare(struct drm_panel *panel) > { > struct s6d16d0 *s6 = panel_to_s6d16d0(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(s6->dev); > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > int ret; > > ret = regulator_enable(s6->supply); > @@ -83,57 +80,39 @@ static int s6d16d0_prepare(struct drm_panel *panel) > gpiod_set_value_cansleep(s6->reset_gpio, 0); > msleep(120); > > - /* Enabe tearing mode: send TE (tearing effect) at VBLANK */ > - ret = mipi_dsi_dcs_set_tear_on(dsi, > + /* Enable tearing mode: send TE (tearing effect) at VBLANK */ > + mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, > MIPI_DSI_DCS_TEAR_MODE_VBLANK); > - if (ret) { > - dev_err(s6->dev, "failed to enable vblank TE (%d)\n", ret); > - goto err_power_off; > - } > /* Exit sleep mode and power on */ > - ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > - if (ret) { > - dev_err(s6->dev, "failed to exit sleep mode (%d)\n", ret); > - goto err_power_off; > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > + if (dsi_ctx.accum_err) { > + gpiod_set_value_cansleep(s6->reset_gpio, 1); > + regulator_disable(s6->supply); > } > > - return 0; > - > -err_power_off: > - gpiod_set_value_cansleep(s6->reset_gpio, 1); > - regulator_disable(s6->supply); > - > - return ret; > + return dsi_ctx.accum_err; > } > > static int s6d16d0_enable(struct drm_panel *panel) > { > struct s6d16d0 *s6 = panel_to_s6d16d0(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(s6->dev); > - int ret; > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > > - ret = mipi_dsi_dcs_set_display_on(dsi); > - if (ret) { > - dev_err(s6->dev, "failed to turn display on (%d)\n", ret); > - return ret; > - } > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > > - return 0; > + return dsi_ctx.accum_err; > } > > static int s6d16d0_disable(struct drm_panel *panel) > { > struct s6d16d0 *s6 = panel_to_s6d16d0(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(s6->dev); > - int ret; > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > > - ret = mipi_dsi_dcs_set_display_off(dsi); > - if (ret) { > - dev_err(s6->dev, "failed to turn display off (%d)\n", ret); > - return ret; > - } > + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > > - return 0; > + return dsi_ctx.accum_err; > } > > static int s6d16d0_get_modes(struct drm_panel *panel, > > --- > base-commit: dc2f9f7fed1a8ea5290f9f60c6310d497e85e666 > change-id: 20260807-mipi-dsi-s6d16d0-multi-167e236e9666 > > Best regards, Reviewed-by: Neil Armstrong Thanks, Neil