From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Aaron Lawrence <t4rmin@zohomail.com>,
Yogesh Hegde <yogi.kernel@gmail.com>,
linux-staging@lists.linux.dev
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] staging: rtl8192e: rtl819x_HTProc: make arrays const and one static
Date: Thu, 3 Nov 2022 23:02:19 +0100 [thread overview]
Message-ID: <a497e930-00d5-b830-b29c-531c18da800a@gmail.com> (raw)
In-Reply-To: <20221103130619.78413-1-colin.i.king@gmail.com>
On 11/3/22 14:06, Colin Ian King wrote:
> Make two dead-only arrays const. Make array EWC11NHTCap static const
> so it is not populated on the stack, makes the code smaller too.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 62aa8e893c34..84ec8df047d7 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -282,7 +282,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
> memset(posHTCap, 0, *len);
>
> if ((bAssoc) && (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC)) {
> - u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
> + static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
>
> memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
> pCapELE = (struct ht_capab_ele *)&posHTCap[4];
> @@ -515,8 +515,8 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
> u16 nMaxAMSDUSize = 0;
> u8 *pMcsFilter = NULL;
>
> - static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
> - static u8 EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34};
> + static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
> + static const u8 EWC11NHTInfo[] = { 0x00, 0x90, 0x4c, 0x34 };
>
> if (!pHTInfo->bCurrentHTSupport) {
> netdev_warn(ieee->dev, "%s(): HT_DISABLE\n", __func__);
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2022-11-03 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 13:06 Colin Ian King
2022-11-03 22:02 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a497e930-00d5-b830-b29c-531c18da800a@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=t4rmin@zohomail.com \
--cc=yogi.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®