From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E160836681E for ; Mon, 23 Mar 2026 15:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774278507; cv=none; b=BeIyrBOWdwofmpzRexRAUDG/J6avbj3LcrDl0vPWgcpi68TS6psd4YxPkHqrS0eeYwi8BYrwHhsDgrGBpIwbKATH7qYkMLck1ZqeN7zqkMUWtmxF/6a6XO9jF2nG+YfkN+BuzfsnZ3QoyAwAFh4wnqBl9Y1SakxmJSLziAjSJXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774278507; c=relaxed/simple; bh=tQUiKGkowDIu+Tl6dcj/peQHjkWjzNjIUvt5xg5KILQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dVmxMd5aZ6cWJvcztL0inrzrcxgCHK6792QVvczBc0hkXcl6DBSLjmPxuDlo9O7knJuqj6FfzjD7x9kOaGmrvda12DutDRmouFSBMQfkILSZVmz5JVYnT6OBOHODplexvYECo48tsK61b087Qq+i0p5DxFAzsnBKesOrrChnymA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P53A/+4S; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P53A/+4S" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-1279eced0b9so3981723c88.0 for ; Mon, 23 Mar 2026 08:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774278505; x=1774883305; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=kh0mF/JIoDMNORbaWvnSYUV3LP1nFmIWld018Bg3S4o=; b=P53A/+4SFN1OuY/BGEhRzayc8XUqPIC7lvN73f/t0NsXGfEDWTiraUlFkDZX79uwKL dFzD1zlQvlxqIcRTZhhTQ83KFDsGHG9HZA1bKay/z7eE6LmMik1I55usMU1exqKb8DiF L9uKymw4dNv7NELwt5gas9uNILgrLjgXE3JZsC5/0ZBy5ASTbAgQm7d8VBQIhyXbHAKu qj8coqlBNJGpZmPzys8o8iaoEB5DaeSKBE9GN86tl03VbS8wjXBx55Vh/rPPpo5EJz4a XSrU/b0YheMgI4AOGPdwd3X1GjdLBFh8oXhy7BR7DxJAQH6JUsyOp/3jH4Ff1/HIXalW TLWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774278505; x=1774883305; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kh0mF/JIoDMNORbaWvnSYUV3LP1nFmIWld018Bg3S4o=; b=PuLoiNdrvN9EQC5AvrMml0flQGA6y0Nf3EIMSZWmo/oq1RIw1YEX0L5DfX24Y834Hz 6ywnl7UwfOLsk2mjT+5VZfx4OPhtVtNu9tuNj1eOKVXBQzCHR8rJBXnEWD3fVCDkqdfi O4OxysLWSakxNXGVvFkKjD+WNf4g1NIgZJwp14TBcH5WsYGHKPiFj4R507lGqioFhEms ciJbLpHUwQkYh2RtFnJI0phvxLv3xfuqkRvVeCx15f/GiyIYGSRx6fRD5wWmFG/SxeeP sPmpJWZpGbts8zuaTleODvLja61m/XwHZx1I1DokG2AxDvUed5A1+8vqS7YlHnnd1VJW Ferw== X-Forwarded-Encrypted: i=1; AJvYcCVFUNgXtNn30TippDWCw6rBYvZkb7rnapBx2u8u/K444m8+RHfbKulkL5agU2TF9cXr/ffeZl2xS1sBAn8=@vger.kernel.org X-Gm-Message-State: AOJu0YyuSERhYao8U3aWToLkfRor56PewcdLuh6CNqelh/Va5KIpMKMi PCidCxmgB/niEqFRlwYvJddT97pL1l9XLBUJgEaR2q1k4uR0pjPQVqzc X-Gm-Gg: ATEYQzyy84Ua+y/9bqb+WAMOUloJdgU06GSvAdBuKQMZTUwXeR0qBxcI4PkycYhUAsG r03TnhvvC8eFlhYaH0HaqLnIkcIxyFvH5IZC38VVNVUmMxwb23WZtvE6Qxnnu/Hg6YsIe5kdJaF wB2IUBmM9mpZR0ijeHu7zGj3EjupN8c1heoE84lT5y9EChB4+OG0AlHN0Ngx3o815o40ufzp0g2 SVh9d3qo9rbz/8s/Qc4wxiuQyot3Ttw3IAYzwe2aVBBrSys3wmQw8Gm0oNkQNyhfcO5HcBPOKYH 2klI+zNxBAJbYFcnQtSD8Nn0N+ETQ76s+DqloqNAWTS1SqmIH8YUG3TuRPXhAWQ23qXMdCiGOS8 F8j5KIMQWamB3gyEw9og2aUTG2BICrF8L6WISYs0Ki3VrhEsS/D+4BiwSNOIdt8u5oM2TCY3gUL hQ9CVvdb/e9Vev3p5n03Wx1EKgNkUL73+kgDTlrb58K1jWxurUT0YaTCSL0yJLxM84pXkklD/j X-Received: by 2002:a05:701b:2403:b0:12a:7f25:44f1 with SMTP id a92af1059eb24-12a7f25472emr1605477c88.34.1774278504870; Mon, 23 Mar 2026 08:08:24 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12a733d199asm9063787c88.4.2026.03.23.08.08.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 08:08:24 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Mon, 23 Mar 2026 08:08:22 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] hwmon: Add support for MPS mp2985 To: wenswang@yeah.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, skhan@linuxfoundation.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org References: <20260323061901.827025-1-wenswang@yeah.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260323061901.827025-1-wenswang@yeah.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/22/26 23:19, wenswang@yeah.net wrote: > From: Wensheng Wang > > Add mp2985 driver in hwmon and add dt-bindings for it. > AI feedback is here: https://sashiko.dev/#/patchset/20260323062104.827263-1-wenswang%40yeah.net Couple of comments: - If the mantissa overflow can not happen, please add a comment into the code explaining the reason. - EINVAL returns need to be explained. They should only be used if the chip can not handle reading unsupported registers, and a comment in the code needs to explain that. - Ignore the concern about the chip being left on page 2 after an error reading MFR_VR_MULTI_CONFIG_R[12] for now. It makes me wonder if pmbus_init_common() should explicitly select page 0 for multi-page chips. - The alignment of + ret = i2c_smbus_read_word_data(client, page == 0 ? + MFR_VR_MULTI_CONFIG_R1 : + MFR_VR_MULTI_CONFIG_R2); still seems odd. Why the large indentation ? Thanks, Guenter