From: "Christian König" <christian.koenig@amd.com>
To: Ruchi Kandoi <kandoiruchi@google.com>,
<gregkh@linuxfoundation.org>, <arve@android.com>,
<riandrews@android.com>, <sumit.semwal@linaro.org>,
<arnd@arndb.de>, <labbott@redhat.com>, <viro@zeniv.linux.org.uk>,
<jlayton@poochiereds.net>, <bfields@fieldses.org>,
<mingo@redhat.com>, <peterz@infradead.org>,
<akpm@linux-foundation.org>, <keescook@chromium.org>,
<mhocko@suse.com>, <oleg@redhat.com>, <john.stultz@linaro.org>,
<mguzik@redhat.com>, <jdanis@google.com>, <adobriyan@gmail.com>,
<ghackmann@google.com>, <kirill.shutemov@linux.intel.com>,
<vbabka@suse.cz>, <dave.hansen@linux.intel.com>,
<dan.j.williams@intel.com>, <hannes@cmpxchg.org>,
<iamjoonsoo.kim@lge.com>, <luto@kernel.org>, <tj@kernel.org>,
<vdavydov.dev@gmail.com>, <ebiederm@xmission.com>,
<linux-kernel@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-fsdevel@vger.kernel.org>,
<linux-mm@kvack.org>
Subject: Re: [RFC 0/6] Module for tracking/accounting shared memory buffers
Date: Wed, 12 Oct 2016 11:09:47 +0200 [thread overview]
Message-ID: <a49e7aa1-d9c6-bb52-36b1-0f7538a8f960@amd.com> (raw)
In-Reply-To: <1476229810-26570-1-git-send-email-kandoiruchi@google.com>
Am 12.10.2016 um 01:50 schrieb Ruchi Kandoi:
> This patchstack adds memtrack hooks into dma-buf and ion. If there's upstream
> interest in memtrack, it can be extended to other memory allocators as well,
> such as GEM implementations.
We have run into similar problems before. Because of this I already
proposed a solution for this quite a while ago, but never pushed on
upstreaming this since it was only done for a special use case.
Instead of keeping track of how much memory a process has bound (which
is very fragile) my solution only added some more debugging info on a
per fd basis (e.g. how much memory is bound to this fd).
This information was then used by the OOM killer (for example) to make a
better decision on which process to reap.
Shouldn't be to hard to expose this through debugfs or maybe a new fcntl
to userspace for debugging.
I haven't looked at the code in detail, but messing with the per process
memory accounting like you did in this proposal is clearly not a good
idea if you ask me.
Regards,
Christian.
next prev parent reply other threads:[~2016-10-12 9:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 23:50 Ruchi Kandoi
2016-10-11 23:50 ` [RFC 1/6] fs: add installed and uninstalled file_operations Ruchi Kandoi
2016-10-11 23:50 ` [RFC 2/6] drivers: misc: add memtrack Ruchi Kandoi
2016-10-11 23:50 ` [RFC 3/6] dma-buf: add memtrack support Ruchi Kandoi
2016-10-11 23:50 ` [RFC 4/6] memtrack: Adds the accounting to keep track of all mmaped/unmapped pages Ruchi Kandoi
2016-10-11 23:50 ` [RFC 5/6] memtrack: Add memtrack accounting for forked processes Ruchi Kandoi
2016-10-11 23:50 ` [RFC 6/6] drivers: staging: ion: add ION_IOC_TAG ioctl Ruchi Kandoi
2016-10-12 3:29 ` Hillf Danton
2016-10-12 0:26 ` [RFC 0/6] Module for tracking/accounting shared memory buffers Al Viro
2016-10-12 1:14 ` Rob Clark
2016-10-12 9:09 ` Christian König [this message]
2016-10-12 17:15 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49e7aa1-d9c6-bb52-36b1-0f7538a8f960@amd.com \
--to=christian.koenig@amd.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=bfields@fieldses.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jdanis@google.com \
--cc=jlayton@poochiereds.net \
--cc=john.stultz@linaro.org \
--cc=kandoiruchi@google.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mguzik@redhat.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®