From: <VishvambarPanth.S@microchip.com>
To: <kuba@kernel.org>
Cc: <Bryan.Whitehead@microchip.com>, <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <UNGLinuxDriver@microchip.com>,
<edumazet@google.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config
Date: Thu, 5 Oct 2023 11:02:43 +0000 [thread overview]
Message-ID: <a49fa745b9bbf05dd6174a176a7749e5a683fe89.camel@microchip.com> (raw)
In-Reply-To: <20231004110031.7e9c32e8@kernel.org>
On Wed, 2023-10-04 at 11:00 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote:
> > + netif_warn(adapter, drv, adapter->netdev,
> > + "rx timestamp = %d is not
> > supported\n",
> > + rx_filter);
>
> I addition to Jake's comments please also drop this warning.
>
Hi Jakub,
Thanks for the comments. Sure, will drop the warning or add it as debug
message.
> > + return -EINVAL;
>
> And make sure this is the correct return code.
> I thought -ERANGE was more appropriate here, but I could be wrong.
Will check and add the appropriate return code in v2 patch.
prev parent reply other threads:[~2023-10-05 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 15:56 Vishvambar Panth S
2023-09-26 23:48 ` Jacob Keller
2023-10-05 10:58 ` VishvambarPanth.S
2023-10-04 18:00 ` Jakub Kicinski
2023-10-05 11:02 ` VishvambarPanth.S [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49fa745b9bbf05dd6174a176a7749e5a683fe89.camel@microchip.com \
--to=vishvambarpanth.s@microchip.com \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome