From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F94C433EF for ; Tue, 16 Nov 2021 09:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0D9A63217 for ; Tue, 16 Nov 2021 09:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233687AbhKPKB3 (ORCPT ); Tue, 16 Nov 2021 05:01:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43435 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233662AbhKPKBX (ORCPT ); Tue, 16 Nov 2021 05:01:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637056706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8EtodayJLE45FsGNYLLJD7khRA7i5A+I61Un2fiL20w=; b=RZCOWd6p8uBv5J0h/RXZlrWIm12XxGChfxP/PygF2tqB4vR9HanUBTWM0yRjg7U2VUdvNC OrRUatB/wCyyxouDlfRsG/6wzGKwW9UPhZYel7qhXTC1eoyiLAaxvJnfFaBJKQY/2SoeQe 8kglWI/WKYNWEz6763YgTN1galISz10= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-8-Vb2RFiUxNBWgY_aRF-3oAw-1; Tue, 16 Nov 2021 04:58:25 -0500 X-MC-Unique: Vb2RFiUxNBWgY_aRF-3oAw-1 Received: by mail-ed1-f71.google.com with SMTP id w4-20020aa7cb44000000b003e7c0f7cfffso4939167edt.2 for ; Tue, 16 Nov 2021 01:58:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8EtodayJLE45FsGNYLLJD7khRA7i5A+I61Un2fiL20w=; b=L7u0GSBkJ6L+o6ySJxpoOYhFoGXX1Rt+FW4JzQDerWGuFyhjzPI9M7wdWDTTj5gxac 0a3Po78HvsCU5YeYc26yWc2YmZsglFLl0dXSBxiMwO2extiRHVhoKsJV8BiAivsbDbli a6eonp3aqbdrqDPshLBzNU5zJ8OxERb9hcf4lyZmz4OF3iV1es55JjNIub/9zX5bBRUS 3ElutwwLTDq8dUZGo2KRW1l8g6SBiIlV49tGgKW/0AiNzz5WX/NAsJFfFXT/HAHmFKBQ LNb00c6EgiSMU11Cbg4SXkhp/G0i4yhy6Kc2PpBYf1veOgtB7H+qmk+KoghkKlx5+9qJ SJdw== X-Gm-Message-State: AOAM532MQUghzfg7YwdqCWdY8efjM1cRH8m6A5g1/qTvgrToY/tYgTCc Axwxk4MjtHL1zBEfoGzx6XaRpJNrYMT6/54i4PvaNB+yEWFWVpHOJueWALfd6M3M95Dhv9gwUV0 wXACUq8I5lEsihlckyWITn7l1 X-Received: by 2002:a05:6402:2693:: with SMTP id w19mr8298008edd.266.1637056704253; Tue, 16 Nov 2021 01:58:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhogYQpO4uRSA3tlOIkQf+tHbNpnLGzqS+aV8+dDAp3RJ5Pft68C+sHOhEp/JWx9+5RKV9Bw== X-Received: by 2002:a05:6402:2693:: with SMTP id w19mr8297991edd.266.1637056704109; Tue, 16 Nov 2021 01:58:24 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id s3sm7790359ejm.49.2021.11.16.01.58.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 01:58:23 -0800 (PST) Message-ID: Date: Tue, 16 Nov 2021 10:58:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] platform/x86: dell-wmi-descriptor: disable by default Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Mark Gross , Mario Limonciello , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com Cc: linux-kernel@vger.kernel.org References: <20211113080551.61860-1-linux@weissschuh.net> From: Hans de Goede In-Reply-To: <20211113080551.61860-1-linux@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/13/21 09:05, Thomas Weißschuh wrote: > dell-wmi-descriptor only provides symbols to other drivers. > These drivers already select dell-wmi-descriptor when needed. > > This fixes an issue where dell-wmi-descriptor is compiled as a module > with localyesconfig on a non-Dell machine. > > Signed-off-by: Thomas Weißschuh Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/dell/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig > index 821aba31821c..dbc71a936339 100644 > --- a/drivers/platform/x86/dell/Kconfig > +++ b/drivers/platform/x86/dell/Kconfig > @@ -187,7 +187,7 @@ config DELL_WMI_AIO > > config DELL_WMI_DESCRIPTOR > tristate > - default m > + default n > depends on ACPI_WMI > > config DELL_WMI_LED > > base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f >