From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Amit Vadhavana <av2082000@gmail.com>,
"Ricardo B . Marliere" <ricardo@marliere.net>
Subject: Re: [PATCH 1/1] slimbus: Fix struct and documentation alignment in stream.c
Date: Fri, 5 Jul 2024 08:55:07 +0100 [thread overview]
Message-ID: <a4b1b2cc-79ab-4e88-a38c-40b89d1c4d69@linaro.org> (raw)
In-Reply-To: <2024070532-romp-clarify-7d2b@gregkh>
On 05/07/2024 08:53, Greg KH wrote:
> On Fri, Jul 05, 2024 at 08:40:40AM +0100, srinivas.kandagatla@linaro.org wrote:
>> From: Amit Vadhavana <av2082000@gmail.com>
>>
>> The placement of the `segdist_codes` array documentation was corrected
>> to conform with kernel documentation guidelines. The `@segdist_codes`
>> was placed incorrectly within the struct `segdist_code` documentation
>> block, which led to a potential misinterpretation of the code structure.
>>
>> The `segdist_codes` array documentation was moved outside the struct
>> block, and a separate comment block was provided for it. This change
>> ensures that clarity and proper alignment with kernel documentation
>> standards are maintained.
>>
>> A kernel-doc warning was addressed:
>> ./drivers/slimbus/stream.c:49: warning: Excess struct member 'segdist_codes' description in 'segdist_code'
>>
>> Signed-off-by: Amit Vadhavana <av2082000@gmail.com>
>> Reviewed-by: Ricardo B. Marliere <ricardo@marliere.net>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/slimbus/stream.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> I don't think this was ment to be sent as part of the fastrpc patch
> series :(
>
> Can you fix this up and resend a v2?
True, this patch ended up in the folder.. did not realize that!
will resend!
thanks,
Srini
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2024-07-05 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 7:40 [PATCH 0/6] misc: fastrpc: patches for v6.11 srinivas.kandagatla
2024-07-05 7:40 ` [PATCH 1/6] misc: fastrpc: Use memdup_user() srinivas.kandagatla
2024-07-05 7:40 ` [PATCH 1/1] slimbus: Fix struct and documentation alignment in stream.c srinivas.kandagatla
2024-07-05 7:53 ` Greg KH
2024-07-05 7:55 ` Srinivas Kandagatla [this message]
2024-07-05 7:40 ` [PATCH 2/6] misc: fastrpc: Add missing dev_err newlines srinivas.kandagatla
2024-07-05 7:40 ` [PATCH 3/6] misc: fastrpc: add missing MODULE_DESCRIPTION() macro srinivas.kandagatla
2024-07-05 7:40 ` [PATCH 4/6] misc: fastrpc: support complete DMA pool access to the DSP srinivas.kandagatla
2024-07-05 7:40 ` [PATCH 5/6] misc: fastrpc: use coherent pool for untranslated Compute Banks srinivas.kandagatla
2024-07-05 7:40 ` [PATCH 6/6] MAINTAINERS: CC dri-devel list on Qualcomm FastRPC patches srinivas.kandagatla
2024-07-05 8:02 [PATCH 0/1] slimbus: patches for 6.11 srinivas.kandagatla
2024-07-05 8:02 ` [PATCH 1/1] slimbus: Fix struct and documentation alignment in stream.c srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b1b2cc-79ab-4e88-a38c-40b89d1c4d69@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=av2082000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo@marliere.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®