From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC6C438024 for ; Thu, 6 Aug 2026 10:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786010891; cv=none; b=db7HE0w0VDCg9tMf0mr65P59Ua2XTL5tU/m+q4jI82evHdmbkYjYAGSh68iUkZoJzdm6grAITuw8vh8wJaBKQ3iMg9VwNeegsOKj3UFpJFytsTfEKgkix88PuCfafStsjeimW4ai4TtG8t6I1fRe8+zRnWTPPRLuqCegcrP9aME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786010891; c=relaxed/simple; bh=iEsjQhRi801AJkEUAaX9s8GzQmbuw9LKcr9UyleNKMU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XASaeSI0Uj09UsAP/M9yGPmGajOjWShdCimUIzOTEBaGU1J3gVGL18CaIJz77YcYroFprjCA1Wnpy8/z2PMT2Ts0lMXLH2DjitGhSqlIC0DcUaP4hRITflN+xxB3yZoILpzNnHKXMqk753R8VrmoKzH+JQ80gqNIUFEE109V438= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aQqpuE65; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OStu+iHc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aQqpuE65"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OStu+iHc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786010884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KhZld27+M+uSfFp/4mUcI1U/RKA6sGB9YBQVMpH+L0A=; b=aQqpuE65T6EJfhifQXSr6PtHR9oC0sTfW70Hl0I94sxHZBSLeczV+dmUp4HMFbWX4xJATQ HeMVB6zk93UVrZvJ7lgtJhZB5FFDYt7JKPV9NxiBHyfFoeqerg45Avy9bZPr/R6eXh4Kei 1wJf8cS8QYhvD5XQeMBHwACcxvzcCvk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-GoW9x47WP22U8eT5Gb4UDg-1; Thu, 06 Aug 2026 06:08:03 -0400 X-MC-Unique: GoW9x47WP22U8eT5Gb4UDg-1 X-Mimecast-MFC-AGG-ID: GoW9x47WP22U8eT5Gb4UDg_1786010882 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-47f83999cceso1590925f8f.3 for ; Thu, 06 Aug 2026 03:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786010882; x=1786615682; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=KhZld27+M+uSfFp/4mUcI1U/RKA6sGB9YBQVMpH+L0A=; b=OStu+iHcCFETz6KOFG98nVlpChzpzpJ4hqSZ8dJcv/4AzXP9clboJmQUEqW4c97lCD UWCUqCj+WG8JJ8qfNTENrytxwBPQxnpdTmcNAv6DQRK/L9w7gTx15PSysk5ty8PA76gZ 2g8CZNDpoLl2hNYgLt3iloNA58wOitMJqW7Xf4UzI2Sl8os4ahjvSWW1AQNhMfvgi4Q2 j88kMrt+7F8wagZPahxw+vnZX+2SwYnFRWqnPmBiao2f8B9bi+152seKlzFmyhPclsyk cv6fcauiL4gf1UPMI8chJj2TPJ+ZQVw6K1aJ10GrZMWNUTpEQbMOhfvFlJf9FO6QvDIR TC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786010882; x=1786615682; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KhZld27+M+uSfFp/4mUcI1U/RKA6sGB9YBQVMpH+L0A=; b=dDz4ULs43zk65TFN1wJ+ess8Y5UM8qmFYY6DA5SiSxr6mE7zPFwKTyeE3wwuOIHlyV ncbX0Zs5nkREZNMZticcJkmI4lhGJthjWvXnrNo5vIsCQztlmKxKimr12ffFzwuarQNY G5B9iXPnJLuE5+snYCYU/ZdJlMykaqZLsrwc4b669t/kJyXNQJrHCG4L0O1DPctD3L91 6BNNIG65/fkKTDQYkL9iWrmulgoT9bAi1tkv56OJd7F2VsmsWDmxOfaTL3qERgOjHkN/ SJ/RPn6EmYs/NOyT/IowsaUPGEWDaB7evlNmhfh2e8OKrqbyMAKNzCAnbhbzgIr1vUQG cRdQ== X-Forwarded-Encrypted: i=1; AHgh+RpP+H2D2JUCGJ8EuRTDJxrLUiem65lCM6c8jdWSshWFvilN4ic/GwF875QcfYAnf4hu7xDCNJihFo6cmJA=@vger.kernel.org X-Gm-Message-State: AOJu0YwpwMg1jN8ewiN++5e4/X/kKRHwANi1y2lGvyZIUvH7kmTMD7Wr rcvJiLpoFMr1VTcUyoN27RvnEJJCUjQP8iZUJA0hKuAL8dj+71erPrlJ8eMA6+nF04pn8iMjwLN Tr3PDeSHxuigQROmy/JAwXQT/rRSKp0lqeYuIvaps783Fd+dtutYLKK9QnfjXpTb9Bw== X-Gm-Gg: AR+sD12gww66Cg5gDHcDWy5OTTkimnuRR145OZB0f5XG4jT2A62qcme6anXSK98m6aQ LJ3wgxbCldyDrBo9pf5comrOuBLoqyNfMwZKK40JVkHHM5AEmV3SmPZSOHQ/chr49HyW6PBm1Ob li755eLndoCJN/StD/rM335n4IJihsAXDQbpIRQgvnXHD+s1AVKwm3pX8urkX4e+kZim+xGrLQk 0MjezJ1whtwEKrvPxWZ+k+sCft9RZXTFXxZmQ1ZUENMvzFJyAlIB+dri+ADi32XKGWh/zr3/c1E 85H5gcHhc32fShWM0nzrwiUHOBljJCV6CtYJCXBgGrmD4MCyCUCfcLEdt7zOsBxMK1DEjADokXb jCzoy+jh6n091f5Wtt229Ufi57hEf/7DYRlc0csxFf1R9DoTdgr6RrkC31OQqJ2ef4JrZpCs3Xn E= X-Received: by 2002:a05:600c:8010:b0:499:521d:bff1 with SMTP id 5b1f17b1804b1-499521dc012mr92037235e9.2.1786010881759; Thu, 06 Aug 2026 03:08:01 -0700 (PDT) X-Received: by 2002:a05:600c:8010:b0:499:521d:bff1 with SMTP id 5b1f17b1804b1-499521dc012mr92036505e9.2.1786010881353; Thu, 06 Aug 2026 03:08:01 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49952d16496sm24832495e9.0.2026.08.06.03.08.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 03:08:00 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 12:07:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 2/3] net: stmmac: fpe: Add missing return in stmmac_fpe_init() To: muhammad.nazim.amirul.nazle.asmade@altera.com, maxime.chevallier@bootlin.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260803032358.16282-1-muhammad.nazim.amirul.nazle.asmade@altera.com> <20260803032358.16282-3-muhammad.nazim.amirul.nazle.asmade@altera.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260803032358.16282-3-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/3/26 5:23 AM, muhammad.nazim.amirul.nazle.asmade@altera.com wrote: > From: Nazim Amirul > > When FPE is not supported by the driver, stmmac_fpe_init() prints a > warning but falls through into the pmac_enabled initialization, which > should only be reached on supported hardware. Add the missing return > to prevent this. > > Signed-off-by: Rohan G Thomas > Signed-off-by: Nazim Amirul > Reviewed-by: Maxime Chevallier > --- > v2: No changes. Collect Reviewed-by from Maxime Chevallier. > > drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c > index 2f880c5e35b0..3436e962a238 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c > @@ -174,8 +174,10 @@ void stmmac_fpe_init(struct stmmac_priv *priv) > &stmmac_mmsv_ops); > > if ((!priv->fpe_cfg.reg || !priv->hw->mac->fpe_map_preemption_class) && > - priv->dma_cap.fpesel) > + priv->dma_cap.fpesel) { Sashiko noted that the above condition does not reach the intended effect: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260803032358.16282-1-muhammad.nazim.amirul.nazle.asmade%40altera.com Also please be aware of net-next commit c82ff94592fb /P