From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbdLJTdy (ORCPT ); Sun, 10 Dec 2017 14:33:54 -0500 Received: from vern.gendns.com ([206.190.152.46]:35718 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbdLJTdw (ORCPT ); Sun, 10 Dec 2017 14:33:52 -0500 Subject: Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels To: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: limor@ladyada.net, Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org References: <1511924469-11448-1-git-send-email-david@lechnology.com> <1511924469-11448-2-git-send-email-david@lechnology.com> <0cade030-030c-f6da-6f79-6fbd520ad753@tronnes.org> From: David Lechner Message-ID: Date: Sun, 10 Dec 2017 13:33:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <0cade030-030c-f6da-6f79-6fbd520ad753@tronnes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2017 03:41 PM, Noralf Trønnes wrote: > > Den 29.11.2017 04.01, skrev David Lechner: >> This adds a new device tree binding for Sitronix ST7735R display panels, >> such as the Adafruit 1.8" TFT. >> >> Signed-off-by: David Lechner >> --- >>   .../bindings/display/sitronix,st7735r.txt          | 35 >> ++++++++++++++++++++++ >>   1 file changed, 35 insertions(+) >>   create mode 100644 >> Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> >> diff --git >> a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> new file mode 100644 >> index 0000000..bbb8ba6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> @@ -0,0 +1,35 @@ >> +Sitronix ST7735R display panels >> + >> +This binding is for display panels using a Sitronix ST7735R >> controller in SPI >> +mode. >> + >> +Required properties: >> +- compatible:    "sitronix,st7735r-jd-t18003-t01" >> +- dc-gpios:    Display data/command selection (D/CX) >> +- reset-gpios:    Reset signal (RSTX) > > I'm wondering if this should be optional. > > Even though the display needs the reset line to be driven, it doesn't > have to be so by a gpio, I believe you can even get away with just > using a resistor as a reset circuit. > > Not terribly important, it's up to you. > It can be made optional later if needed, so I'm going to leave it as-is.