From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: linux-amarula@amarulasolutions.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
Richard Zhu <hongxing.zhu@nxp.com>, Li Jun <jun.li@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mm-evk: add pwm1/backlight support
Date: Wed, 13 Apr 2022 14:27:00 +0200 [thread overview]
Message-ID: <a4b6c158-da56-7879-04a4-558f751cb372@linaro.org> (raw)
In-Reply-To: <20220413115810.GA4713@tom-ThinkPad-T14s-Gen-2i>
On 13/04/2022 13:58, Tommaso Merciai wrote:
>>> + backlight: backlight {
>>> + status = "disabled";
>>
>> Why disabled?
>>
>>> + compatible = "pwm-backlight";
>>> + pwms = <&pwm1 0 5000000>;
>>> + brightness-levels = <0 255>;
>>> + num-interpolated-steps = <255>;
>>> + default-brightness-level = <250>;
>>> + };
>>> +
>>> ir-receiver {
>>> compatible = "gpio-ir-receiver";
>>> gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
>>> @@ -395,6 +404,12 @@ &wdog1 {
>>> status = "okay";
>>> };
>>>
>>> +&pwm1 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_backlight>;
>>> + status = "disabled";
>>
>> Same here.
>>
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
> I think is better to keep disable into .dtsi and enable it at .dts
> level.
> What do you think about?
Why better? This is already board DTSI, not a SoC DTSI. All boards using
it are supposed to have it available, aren't they?
Usually nodes should be disabled in a DTSI if they need some resources
not available in that DTSI. For example if they need some supply. It's
not the case here, right?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-13 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 10:20 Tommaso Merciai
2022-04-13 10:28 ` Krzysztof Kozlowski
2022-04-13 11:58 ` Tommaso Merciai
2022-04-13 12:27 ` Krzysztof Kozlowski [this message]
2022-04-13 12:40 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b6c158-da56-7879-04a4-558f751cb372@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®