From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C55432DE6E3 for ; Mon, 17 Aug 2026 05:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786943184; cv=none; b=QG6eU27pDcrj84Hyeqy/8CwgbksjcIjz9KP0/fGpEtblQfGJEcPuo3fFO/KLJQ5aY8TMwVbWX29xwEZczEEbD3mtiF6a7Jg81DDZ2jri9KKLNAW6w+kVQV2apBz9wq3QCR6TTj7wepckazdASu6XtzUKnQ+AnZAOgOWgRMcNuJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786943184; c=relaxed/simple; bh=o+EwF5sNn/62qlSMhm+//xRPbGNuVP8t8sGE3lVuums=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PngtcJAyrQsdjrPxb8a7o4QSMh08WtU/JYlVnn8WIT1Pqt3dZL4rv/ur+pg4kgpP8XKzBOQUYWSNlM946jIMpnq21UUjvrXPOyAbHxalVfo9dX3lNtrB6VX/XFrZZI0QuI43tTiKk2oaJ5j6TSrfqXNUfFyNIwWhTlTgxizBcTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NDSmM+a1; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NDSmM+a1" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5aeb59d54b1so2957875e87.1 for ; Sun, 16 Aug 2026 22:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786943181; x=1787547981; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B+RYmCe6QLOGqYQGrPMnf2Nsi3pMxXU8BaOAMJ9Mmig=; b=NDSmM+a1zNeDhb2vm2sAD3SKY1LE9kfvo1nG8IKvZPDjHge3t7T7yapkr0Di1W1ZoI oF+wnZwxwRnSscMiqidrbAcRnXi+2Lix0RgAX0Hjuiy1pc2n2zhaYVIs6Vs3ayju2D58 Dmvwp1DF2bouo2+GHsrLgwsgYoK/pi3VE3P5UZRSkZSXkEOpZMC3PDF8HV+RrqSI0d0C fh37nK2/I7Vip/y+3Hd/+tbI2EruKZ1tUW2cF+owb4BXCpf6h0Ny+GzoFIGQcLBKXlg5 hJVa9ZE9uz/sHeSiZXVmGSPL/OndZzAncZxWbrzvv/oO6xK2hn9d7emIcJ5qGR6wEA3X 8qCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786943181; x=1787547981; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B+RYmCe6QLOGqYQGrPMnf2Nsi3pMxXU8BaOAMJ9Mmig=; b=UcjgK1TOuCXMIJJRzjf4mmbOcGzJe2PJ7BzMNqwkVYtmJlHsWiw92Pd7pNMSxUAeGU fUOQVU7tSFxo93kbEfSsNjlNsYvDNNNXyOAT5ccbgJHw2nGVBm4p0n2wf3ltqcSF7mof Pe4qwbiTJZs+osLXtsoTlDNHnZ2fhp4RvyY1XTP9vf70C2QgCwMMPAfTGaTiospDdb+J 6MnDxOVd0+O9vBAH6nXBBqbP4N7exn+U60id2Z0be+EKdHjkRRXg3OxV0h29TRu2kiyJ 1L+KiyLwu1oCxT4fPpUbfUjjAry43bpC1UQI1OCY3EDVpG1MajhPyvuMeBYaGXHELc9P dksQ== X-Forwarded-Encrypted: i=1; AHgh+Ro0DC8nxYTfkvGC5DhoXsx/Gpd3lezmd/o9hg4oVdnY8OE0lB3NEVhFEqjrMJ5sLMer3AkzsOTvITuMM5c=@vger.kernel.org X-Gm-Message-State: AOJu0YyhH1bTzKNjZLxBNS50gFq1HG3V6GUKUmW0Gp9+tvxhhTkGYGZC Rj4GEVB02gyqhrfyCo8/76zdQ2eNEt+PZCoXdohEqc9HdyMwyUWU9+tN X-Gm-Gg: AR+sD12CCpF5o2jtdUWrkDn3Vxtka3DBRUfnwQ81ANn+EBQxisKy+9oacQMPp7GhOWL 1TmbjrW5DUyQ6XzOveDS6Jf6Imf7fP4qOkh8N6VTihDnBTijxOU7Z9L5R/o0ZunGckNSaTp1ZZ0 WYYKgvjLPto8Kjsgj2c/Cf2wb3HxhnNXWhmNH1DSGqyhDiWP68BKp7d54bbeUcYt5iNoihSE03y rGvPnH8huTxGXzxEiEvJkzUf4iRrz+4ZYni3cjoSGPV0mCQe/z0qStxCZqamn4al3KcuxxRUAXV 4ZixQuJIrnnSCKYneIewTe0zRtmEA77a38dbjJH1paJWfQ+vt4FDreFaiKQPoWoaF0nGoprKjvL NGNd/a8cex9wgQdLJfYt91h7uXj8y83Yvf5cmpcEkgc3EANRobtKG1vYBBedjGLdUwww255cNbX P3ueLprpAniWPIjcTzxkA4zHVJruSDWVuFW3HOBwujzB3yK1fRMdSX6vIoMQWgS2/N2dDmlILuv aPxzPY2v3BeuxZ4DxqCRlltHaxpbArwAPIO+8pQh5uPNnlTV3vMNVA= X-Received: by 2002:a05:6512:3b91:b0:5b2:aaa2:1d80 with SMTP id 2adb3069b0e04-5b459149932mr3844377e87.47.1786943180507; Sun, 16 Aug 2026 22:06:20 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b46cfa096asm65020e87.19.2026.08.16.22.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Aug 2026 22:06:19 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 08:06:16 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/12] iio: dac: rohm-bd79703: Do not allow writing SCALE To: Jonathan Cameron , Matti Vaittinen Cc: Matti Vaittinen , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Javier Carrasco , Mehdi Djait , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kalle Niemi , =?UTF-8?Q?Topi_Sonkaj=C3=A4rvi?= References: <20260817023217.2fd9e42c@jic23-huawei> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260817023217.2fd9e42c@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/08/2026 04:32, Jonathan Cameron wrote: > On Mon, 10 Aug 2026 10:51:38 +0300 > Matti Vaittinen wrote: > >> From: Matti Vaittinen >> >> The BD79703 has adds IIO_CHAN_INFO_SCALE in the info_mask_shared_by_type >> so users can read the scale, which depends on the used reference >> voltage. This, however, enables users to try writing the scale as well. >> This isn't really supported but the bd79703_write_raw() does not check >> the mask, and if written scale values pass the validation, the driver >> will proceed writing the DAC value when users writes the scale. >> >> Prevent the unsupported scale setting and return an error. >> >> Signed-off-by: Matti Vaittinen >> Fixes: af6aca656a85 ("iio: dac: Support ROHM BD79703 DAC") > > Applied. > > BTW convention is Fixes goes before SoB. > I did wonder if is documented anywhere and claude sent me > to the tip docs. > https://www.kernel.org/doc/Documentation/process/maintainer-tip.rst > > IIO can follow that. > > Anyhow, I'll swap them around whilst applying. Thanks x2. (Once for pointing it out and once for fixing it!) Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~