From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1278811; Tue, 12 Mar 2024 02:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710210261; cv=none; b=GJJt1RXGbv6SNXBNlb5/6HIpib2y9Q6dxvuOEzLESD/9f1y9YvsBwFcAMjrQVAjlkVoXeGB7DHMMhT+AKBvekBA3KAPx0/zleOLC+PGIJW1A7/LXfaoktuHZUMJnF+JIwxAm3eJm5CMGoLgktXd10aVtM5qWHc85IuQjcD6mkFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710210261; c=relaxed/simple; bh=fG56aufdfltkZYeNBOEgH9TwSlq3RcV6Utjd56I7WFU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PTEmiBcd+Q/grsh4iZv9SfJP2TRLUZMzoID3M4oYLXQ4CavNjm9vXwbH5t6lzCiGwCse5tUGlxKJgQG8Dh0X7zrRqJNYjPIvNkCmXhvO3pDTLZcodFVuX5LPxf5Wq5ZTUbnCR5Hsb7H7K2cOkX+uhoH9RGDtcde5HiCugMRNajw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=nRB0eJ3X; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="nRB0eJ3X" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=9SbrPiGCdQrCt1N5ALQH0ssl1pc2Fp8ln+P1Az4BYwg=; b=nRB0eJ3XHAXgng9YKgOiAiJOkM rS9b+rDCpbQRp67REvX239+NvvQEykGjZeuFuYRSRmq2j6ancaHvad0xHtbI64xxWQ3uS+pk/9lIe vr7Z2RY8bXHkTbJFTz5NBzUO+t3a32gJW6o7+1RwR+qhh5RzS5Ed8UZ4SMo9AoMEOKRLb3e6iiGQ/ NAvC+u6liyvX+KpK0ELcSuqjN1lYrpzIwMlpNJyQUaL4+hASVeeBBTlKfX/s0ZeOTBVRrtmJg5ZCn phzrMhLW4kjtGyVyoOzWckH6oxSuJDfvUvIZmVyPwrmXOtWYVfPs4PqyVXLQ/p/sbnX/XCXH3z2+m rDGf8VQQ==; Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjroP-00000003zcl-2wJh; Tue, 12 Mar 2024 02:24:17 +0000 Message-ID: Date: Mon, 11 Mar 2024 19:24:16 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] EDAC updates for v6.9 Content-Language: en-US To: Linus Torvalds , Borislav Petkov Cc: x86-ml , lkml , linux-edac References: <20240311155651.GAZe8pw0urOnUZj1y_@fat_crate.local> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/11/24 18:12, Linus Torvalds wrote: > On Mon, 11 Mar 2024 at 08:57, Borislav Petkov wrote: >> >> - return topology_die_id(err->cpu) % amd_get_nodes_per_socket(); >> + return topology_amd_node_id(err->cpu) % topology_amd_nodes_per_pkg(); > > Ho humm. Lookie here: > > static inline unsigned int topology_amd_nodes_per_pkg(void) > { return 0; }; > and there's an extra/trailing ';'. > that's the UP case. > > Yeah, I'm assuming nobody tests this for UP, but it's clearly wrong to > potentially do that modulus by zero. > > So I made the merge also change that UP case of > topology_amd_nodes_per_pkg() to return 1. > > Because dammit, not only is a mod-by-zero wrong, a UP system most > definitely has one node per package, not zero. > > Linus > -- #Randy