From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C90B713AD0 for ; Fri, 3 Jan 2025 12:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735908027; cv=none; b=CbeC7gygTiBv3rWbaCE3Vgkq18agLA0+B+0ADnx8lw7fS+rIkHr1ZPOGOebiYvEMkCxQFLpyX5+Lkrt+eJ5wkObKE3WtQNLMEFjPjI2HaZhnU7ZkopjVDziK4DtkAwdjQnf4ZWickZs1ZvbEVivfIhc/YZEowYsADsYIRewzjZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735908027; c=relaxed/simple; bh=ljdmyoS8ljo7bdBKaCGNLGqWx+Plk2o0Lf9P4b0gCWw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kxXTaiepeex9D/wC1vPsyULDDnqk2M5cbz0RxuRtgSY6gvQKl3zLM0x3EAxC8PUMsx3CdRDOfaYXCX189RHWZVFMNuv1ueD5IiKZxqLIBGK4E0TzVGkyc2CK+g8wqqWFYCbCoumtw9XH4mIjI7gogNyiVA7xZfZsBmtYH/zLmYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=jSmqtVAo; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="jSmqtVAo" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2166360285dso170230105ad.1 for ; Fri, 03 Jan 2025 04:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1735908025; x=1736512825; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6avo01D48FNOf2Y5ctDYwfD1XQF4OxyFNKOjDxHKAZc=; b=jSmqtVAoTbO7OYunORLuCukpSmzurf+Qmabj2FbAr8Y2BUw9nU6utHyto4q2U9pNnq k/+Ro93iukXzFxs3npS65wEpFQBWh6KQ7OBJ3k9J/y9nt2LKICrRMy9Rbp9hHCZuxX98 1wNyy2QoxeakrntFcrl2UQXGtzUurb7ryB3orR3KybSzPTUVFiMUmVqXhcq6HH6ldubn qFeFctm3f6tqTgegw3QPhpayozJSCAaFcgn3w+GO80JDA1O+51Lo4KQa3UwQ51Kx7s8b bThwUwdiXNPIML11RqHI/1X4xk3ruW93bmn7RlQQ7KWfjV2uGd1cSiYoLb2w90P3QCh3 T2Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735908025; x=1736512825; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6avo01D48FNOf2Y5ctDYwfD1XQF4OxyFNKOjDxHKAZc=; b=SWOl1WxuAiiXqlmCjjatUYtaCRISgusvJHBJ8Pb1cLCm/ywIXO4rqrJjDjjeEgK82d mDuE3QN5KIfld8yloYl7tlm40MDwWmU1Crce0rxMN5w171/vHAPzgssunWwBtY5AH99x 4wiKweqWimpmNZPYhJCczznrAGPIHFzz49Y/61qJs6JZA9q6lU8FfXv2TuRGBrUTBIeB BE8Ihk5ESXWuGq7aKiYVHvwibxN8oPvwLVjfrdoXZrqeQZ3AOniRApQGMaTA7anK6YX0 OXska5LUK4i8thyIuAeXBcvOdEC5sR1vhLUMjBUdR/88Gg4dinu4qHKx/BxfYZsALcmW M6iw== X-Forwarded-Encrypted: i=1; AJvYcCX/GUFEU/hyEy6UY1iS1VJI+6a+6LPZSOXOO6VsJSXR2FLlgGjzGBgngXvWeK1uj2N3KnpiGjE69KUE6gI=@vger.kernel.org X-Gm-Message-State: AOJu0YxCdU+22XgOV4mI6rvAeZuR1Ye5Xak+60F1lkDkQ4RSlO5ZExU+ jd4tOeJubPWzylbdLGQsbEzh8lreYnHtUWmJroAooLiw7DqJqyqNjmdQVGg+PV8= X-Gm-Gg: ASbGncu2m3Xv3hWT2rT3kzeosGYBFFKTuHkxLn3bAxciRzDg7oXvgpaP33icCV/GciY 8LxVTuRtQOKKGcC0ZI9jTvQ2xT78nGkG2fJ0qsuDWe8lbvJ8ZHycEdvArm1egqo1IQJjLn4RJqL P+7XfhkVJq8THkfr4ISEkJt7qHj6NMMB1YCFznYUzW+bwxN5elIc+UeaRlcpuC9HArq8cJ3NggC uUa8PW9Z3U85ZRavRiO1ONApo7bX49+J2kKcOokPhr265Njw9wfc8vKxdeCcgCNfGHc0QqCmQwB rmtF X-Google-Smtp-Source: AGHT+IGj+GtVbhhfaYb5AseswWXTOsj7MLole6XXxr0se+jCmFvBN90R2SzhvkG6xrwfQ5B9yp5LtQ== X-Received: by 2002:a17:902:db12:b0:215:711d:d59 with SMTP id d9443c01a7336-219e6e85b37mr595077915ad.2.1735908024910; Fri, 03 Jan 2025 04:40:24 -0800 (PST) Received: from [10.255.210.224] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f72d1sm244252185ad.189.2025.01.03.04.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jan 2025 04:40:24 -0800 (PST) Message-ID: Date: Fri, 3 Jan 2025 20:40:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Take the scheduling domain into account in numa balancin To: Peter Zijlstra Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, riel@surriel.com, chengming.zhou@linux.dev, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org References: <20250103065930.413464-1-zhouchuyi@bytedance.com> <20250103113617.GE22934@noisy.programming.kicks-ass.net> From: Chuyi Zhou In-Reply-To: <20250103113617.GE22934@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Peter, 在 2025/1/3 19:36, Peter Zijlstra 写道: > Your $subject and actual patches do not patch. > > Your subject suggests you're taking the scheduling domains into account > for numa balancing, your actual patches are bunch of special case hacks > that totally ignore the actual sched domains The subject is indeed inappropriate, but the issues mentioned in this patchset still exist, right? - We should not consider isolated CPUs in numa_stats. - We should not select isolated CPUs as candidate CPUs. The current patch handle the above cases with hacks because I thought this kind of change is minimal to fix this issue. Perhaps you have a better solution for this issue? If so, please let me know, and I am more than willing to continue addressing this problem. Thanks.