From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED58255F2C for ; Wed, 14 Jan 2026 02:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768356638; cv=none; b=gXZcX+1ec6Z3pBF2HckkYykjRnI6c3R596FN8ZekYTBUWhCnGgoKF2h/yODl4Wg4nLOt4BMv5T0ZCYel1cPI/tthd4ujngcFMHWrhFt/LvCzWZVeivQ4w6MvcZxek002dcg+Hqbl6epJMs9tsqQbFA4zgmSXrea0COR2Vqv2pSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768356638; c=relaxed/simple; bh=lukdp60q/79cHdOhP22/7xnHwu45Fec7j8VbrjOTgi8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=IrkBJq3X9DyqyVIS1+X11MOnfwn5Mbu4ZoR9Z7yTgRIFeg247VOMwuwubsv82lemw72YUlDwZ/VnyFyAf1hbJzQcA460N2bur7SkzscD98UdvnEMrEzu6SlnkKogp5yynJCnksZ6y6d9UNl3fWsRq5Hbya5DnwO4OPNy0UdtBOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=Ha6hc8Be; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="Ha6hc8Be" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1768356634; bh=legPp6d0kYzVtugSXW2QUU3YaU5bsxQJ/YOrcISjRHw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Ha6hc8BeoA/dYMk+iXC8wG2sU2Kcv/BNDLX25BljuDWm1kWboVWq288S978qQnobU mZ4fu7Fc2S5ilVL6udLErBKtcVw9IKJ1+Ti4eT/63zG+VQB8cfMXhDDER2TsYIdJ0c vaitm6RQmP+ODrUzf6SxsKG249IPgffVWywjva1VC8FSVfP182e+Xd7Xasx1vwif04 QF0YVhVm6ZWOjiMvQGUstlKwpNDJFNhCnNnffI/vcXr1lwJ6cj52TVeX/M4tMKDn/T KAbpFWwquZV/lXCQDBeNb7JMcQRJ4W/SIpw7LQaa03QuzDP7aykPwF1R3hD1zxeeZd /iUl6B/dgKgeg== Received: from [192.168.14.220] (unknown [144.6.157.237]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 9D2CA64705; Wed, 14 Jan 2026 10:10:34 +0800 (AWST) Message-ID: Subject: Re: [PATCH] ipmi: ipmb: initialise event handler read bytes From: Matt Johnston To: corey@minyard.net Cc: Andrew Manley , Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Wed, 14 Jan 2026 10:10:34 +0800 In-Reply-To: References: <20260113-ipmb-read-init-v1-1-a9cbce7b94e3@codeconstruct.com.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Corey, On Tue, 2026-01-13 at 10:00 -0600, Corey Minyard wrote: > On Tue, Jan 13, 2026 at 05:41:34PM +0800, Matt Johnston wrote: > > IPMB doesn't use i2c reads, but the handler needs to set a value. > > Otherwise an i2c read will return an uninitialised value from the bus > > driver. >=20 > This is fine, I suppose. It's probably better to do this. >=20 > Are you actually using this code? How was it found? I'm not using IPMB, so haven't tested the patch on hardware. We received a patch for mctp-i2c read handling, that made me notice=C2=A0 the uninitialised value problem there. I had a look over other=C2=A0 i2c_slave_register()=C2=A0kernel users to see if the problem was common (mctp-i2c used ipmi-ipmb as a bit of a reference during development too). https://lore.kernel.org/netdev/20260108101829.1140448-1- zhangjian.3032@bytedance.com/ https://lore.kernel.org/netdev/20260113-mctp-read-fix-v1-1- 70c4b59c741c@codeconstruct.com.au/ Cheers, Matt