From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D42C4363A for ; Fri, 30 Oct 2020 12:22:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B0162076E for ; Fri, 30 Oct 2020 12:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726570AbgJ3MWF (ORCPT ); Fri, 30 Oct 2020 08:22:05 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:42486 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726434AbgJ3MVs (ORCPT ); Fri, 30 Oct 2020 08:21:48 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 2A063182CF669; Fri, 30 Oct 2020 12:21:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fall60_110101e27296 X-Filterd-Recvd-Size: 3079 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Fri, 30 Oct 2020 12:21:45 +0000 (UTC) Message-ID: Subject: Re: [PATCH] checkpatch: improve handling of email comments From: Joe Perches To: Lukas Bulwahn Cc: Dwaipayan Ray , linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, yashsri421@gmail.com Date: Fri, 30 Oct 2020 05:21:44 -0700 In-Reply-To: References: <20201030090704.40533-1-dwaipayanray1@gmail.com> <9d5c8699f94481ab5bf2d37348199ca1d6343c8b.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote: > On Fri, 30 Oct 2020, Joe Perches wrote: > > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > > > checkpatch has limited support for parsing email comments. It only > > > support single name comments or single after address comments. > > > Whereas, RFC 5322 specifies that comments can be inserted in > > > between any tokens of the email fields. > > > > > > Improve comment parsing mechanism in checkpatch. > > > > > > What is handled now: > > > > > > - Multiple name/address comments > > > - Comments anywhere in between name/address > > > - Nested comments like (John (Doe)) > > > > > > A brief analysis of checkpatch output on v5.0..v5.7 showed that > > > after these modifications, the number of BAD_SIGN_OFF warnings > > > came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came > > > down from 2366 to 2330. > > > > > > So, a total of 1556 false positives were resolved in total. > > > > A mere reduction in messages emitted isn't necessarily good. > > > > Agree. That is why I also went through the list of those warnings. So sending me a copy of that list shouldn't be a burden. > > Please send me privately a complete list of these nominally > > false positive messages that are no longer emitted. > > > > I believe one of the relatively common incorrect messages is > > for the cc: where a version number is > > continued on the same line after a #. > > > > CC: stable@vger.kernel.org # for versions x.y.z and above > > > > That was one, another common pattern was just quotes put inconsistently at > different places. Which to me is more an indication that a message _should_ be emitted as many email clients do not like to copy/paste incorrectly formatted email addresses (ie: Missing necessary quotes when the name contains characters like .) and that's a common way to cc a reply to a possible commit message of an email. Perhaps as well the .mailmap mechanism may not cope with these differently formatted email addresses.