From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756168AbdJJMTs (ORCPT ); Tue, 10 Oct 2017 08:19:48 -0400 Received: from mail-he1eur01on0098.outbound.protection.outlook.com ([104.47.0.98]:37478 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751415AbdJJMTp (ORCPT ); Tue, 10 Oct 2017 08:19:45 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] UBSAN: Add __ubsan_handle_type_mismatch_v1 handler To: Prasad Sodagudi , nicolas.iooss_linux@m4x.org, akpm@linux-foundation.org, mingo@kernel.org Cc: linux-kernel@vger.kernel.org References: <4ee8e077-feb4-c2ff-5eca-ef06012d34b3@virtuozzo.com> <1507619163-22943-1-git-send-email-psodagud@codeaurora.org> From: Andrey Ryabinin Message-ID: Date: Tue, 10 Oct 2017 15:22:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507619163-22943-1-git-send-email-psodagud@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: AM5PR0102CA0029.eurprd01.prod.exchangelabs.com (2603:10a6:206::42) To DB6PR08MB2823.eurprd08.prod.outlook.com (2603:10a6:6:1d::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff9e0050-fa83-4940-7b5e-08d50fd92ff3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6PR08MB2823; X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2823;3:DyKMgxS7QTraSsI80QaSlAMhHFVpwj5eQgXj1rmqFmqhQva/w8cTHlVAkSnSzb644mevgW9Z0RwZiuw3Br7OntXUB0hTdhITE3nDwO+XyMUVjDEH07UVyoq7IrFRwRfI04g8GRziP3EC9TrRZm1C2ZXOm2tG5OxsFmL6u3NeUjnSqucbLWbI1hztlSAO+fcnWYPUQa5j84rZsEFFkOKF3A77BC/OemlKwIL+55bcPm5Xj/mE4l28rG1ebu8r8qtx;25:rv9QUizu2yr/2bSHDoSMZoCjCEWrfx3ryPd/6FM1j+ZHS0Hu1czd2SsLNo/uHXExITkwy3CLD6vP/0Khtm+zdcOJoaMEGHKmYgQBoto678q3EjKOsZj+X9MY7WTXWLVZn3OsncO6OoFfkN2esK15F71S224+SmZ8cjf0i36E9Bn/AexrWzCAmQ5SojmHJDTCcuRjsdNavk3P4jgx/5vuMCWoRd1Cjs9O46SsUzk74npF2HEOa8QWtMCskq4NlbowlbeAgmjTM3sgTO9MhBB8z0TfhthGJju9dwaryMfRuU2AT5GHHA87/Mjq4uyRt9k+2DDOS5kJvzjnWGo19wurRQ==;31:jh2eNb1F1VCRQReO9XT1bkfF2Ssg7CSKlJAjoWR4heOxo6asqoDw/6uhzfPd7zxuv1FptwW8oqNetUPFcpDR3I6uBDzQcJJ01Rx8BoI6AAzv8blvkYssRcDlvIaoLftZaQ5cUTDRxLFD5YusLEwdkzbnkQCnKdgfvhFsk21X5jB0Se4wTKmbT6ySPxcm0DjhaEe6GVAkQXE7vU8aS+HpUGu9QLkHuLD4S+IBYeJouD4= X-MS-TrafficTypeDiagnostic: DB6PR08MB2823: X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2823;20:Yrrg+MnHBuXGJ9rO4Qsw6jpFiShoSik8fF+mmHoK4I9OBd8w8NzbjKFyCJtvNACAtuYU7leGbrqOBeaLns4J3HOOBE/4IC96LB4Hbh3qY6K1MHEUl00R8egu7gHeimbyfeZegL7lKd3vPYmYG2MWEOdhu8bxb0QpCWyu3daqSfTI2YjpTU8VpoP33toE0ir2R8ehb5+LeetEntuBrgXhIjAbnSsYlmvyJZaPaqCFf2JjMyQGw6c+/uTRE4IrkHAT5MH0gCd1jmMj5aA0Dy0W04JD6GD6mSshbHGXB6bSGgnP+lLz6qcCTBOK2USjKEqhHJPAn+bhJKSDHYXMWPDB2ux+KBhBxSSEeYFWxgzKYIm3jWOdVRmVY707lzHpHZAlMEdOi2E2Ep1+oQ4tN2zMFZHU6XK6o95KLhC/9Eo0NSw=;4:qVuRe6zpSil4p+nxfcVuwxsaxvzYW2U+4m1WRun1vHEgyjmR+O5OJY1ahzrWJR6B3gXfsvNXSyf1ywz70nNOab4V0Ncai8Lr8Tz/+0vPiDBjHaim/6NdBCX8JSzUAvCkss+HozX+tK+htjV0NdT0jMfaL6SGzj39LQ98W5q9PR3YHrnrWtj9DsSZ7JkgMT0V+GW60vKPfPjX9D/Tq/x7y6J/sRlkfW6ZgFZluaGL/BZ52lWdXHZPpQW6hJt0/pFg X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR08MB2823;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR08MB2823; X-Forefront-PRVS: 04569283F9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(376002)(346002)(377454003)(24454002)(199003)(189002)(81166006)(81156014)(8676002)(478600001)(189998001)(2906002)(23676002)(76176999)(54356999)(25786009)(50986999)(101416001)(305945005)(106356001)(105586002)(6116002)(50466002)(33646002)(68736007)(86362001)(7736002)(3846002)(97736004)(64126003)(229853002)(31686004)(8936002)(77096006)(5660300001)(83506001)(230700001)(31696002)(36756003)(65806001)(6486002)(65826007)(53546010)(6246003)(66066001)(53936002)(65956001)(2950100002)(47776003)(58126008)(16576012)(316002)(16526018)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR08MB2823;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4TUIyODIzOzIzOklZbi9oOE5DbEFodWZQL1FTUysrdW5YSTlN?= =?utf-8?B?RDZ1L2t5WHl0NG42eEU5SFU2NWZCQWZqaHl1UU5lMmwwUmNsdWtnNEVwQTFM?= =?utf-8?B?eDVHMkRXZy9XWDhYWWFnU1VKaGtrSWRXY1g5SFN6Y0Y1dUh5K1ppUERDRkQ0?= =?utf-8?B?Yi96ZCtMalhBZkVJcDdseW5PN3VLdGdQTVQ5M054c1ordTJZdnNyc2FSSmdl?= =?utf-8?B?ZXBGVlhZTUhUazdCWWNoMGR3Q1ptZmI1aDZoV1ZmNTZ2eUF3RVVmd3FtT25i?= =?utf-8?B?M1lLNURrNzVIdE1YelZYQTJnWEppa0p0dzB6VWF5a0VSWHQ5RHVTQUxST2Jl?= =?utf-8?B?MCtpaU9CdytESjdkOFR4Q0dMZlZaUUg0Wk8xU2VWc2VYczhxU1dlaGdNa0w1?= =?utf-8?B?UmwxQTMvNEw2RUJwVlRVZ3luWDE1UkRSMmNjcTE1NTNJcHd3bmNyY0ZUdjkv?= =?utf-8?B?RldyWVFRUEpWa3FmSUU0MXU3RzN1UFBFR0VmYklmbDZlOENucVZLalJuc1Zh?= =?utf-8?B?THYxaUk2ZTFqRXBCRElTRXJ1UzBMYUZSQWVlOWxrODRBSDNyc0xWdkpCeWY5?= =?utf-8?B?OUlDMVZDV0lVNEd2QzArbFRpM0RGL25IZGVmdC9Nb29LWCtjWktnb0wyeTVS?= =?utf-8?B?OHlZQ3paRFFnVW9lRndhRVhPVGFERzkrNXdlZVRmN0dBQmxEUlNkQkh0UHh4?= =?utf-8?B?cmZHNmZoNXI3MVZtYXhOakRBMXpUNlhTaFl5MktEUXV4R1BrdzVKK1U5S3RH?= =?utf-8?B?dW5UNFk1YUZFd1BnSHM2Y01vRTloTzVMcnN6VjVtUU1UbjFKODZvRTVJMkN1?= =?utf-8?B?QlNTT3dta3BhWVdiWmtqZjltMDRlMFRodytuc0paK2RCV2ZFWi9tUWw4dTN3?= =?utf-8?B?OXRySGhveW95UFBxZXpIOXpnZGFKZDZXclNubFIwUnpBbVZmam9jY1JlbEVt?= =?utf-8?B?VnkyVVFOTGV4OUxocGttbnBtZExNN0F1QW5MRENraG94UXMvaFIwQjNvTGtk?= =?utf-8?B?ZDRNa2RQY0JsZFYzT0IvRzhqTlJyaDZlZVhpaExqNUlycis1WVc1ZHA1b3ho?= =?utf-8?B?aG5RZUQyVVVVT3VVcXp4dlVjS0g5LzVTVHF3c050TGp2RENIUmpDejBBWUFF?= =?utf-8?B?VDErUlZWSEsxcjdmbVpndXFoYVJRZkhtcUx6Uy9rZ29Nak5LWS9HVjNMUSt5?= =?utf-8?B?SDNQcVkzdDBVL3NBaUJINFRVSnhRRytwS01pTS9pLzBibERaVDJ4bW5WMUNv?= =?utf-8?B?Sm9jbUxZY0JTMHNiRm1rUFF5SlhNQlhRUmsrTEdrOUtuVUNLVnJxWldxaXk3?= =?utf-8?B?YnpsRFYwOHk3UC9pRTBOQzI5eHJIVzMya0VvZDcrb1RwaHF0azNxbEg2Tkhr?= =?utf-8?B?dEc3MDEwMXVPYU5KdE5qSGY0YUVwS2hjUXpTbmdpN3BsRldlZHFYUHBKMzRX?= =?utf-8?B?eVptbDJhT2Q2aVMxWGZ1V0JLSkN3QWh4b0xFemRmajJ1SjFtdS8yUURGRVlx?= =?utf-8?B?NHp3TWh4QksrMFhwSyttekt3Wmd0YnBQWk1lMVFvSy94QjMweXlaSjFjVXg4?= =?utf-8?B?cjJaRmJ3aHkvNWJyT2dkUHdsbktqUVJMREFOWXVBOXNzOVVoRzFKK1loUm0y?= =?utf-8?B?V0N0dnRjV3M4aWgvOStBVjNiRXJUSWlaRjNrV1FNWDBadmg1OTlRWXo4MTdR?= =?utf-8?B?VUhNbHY2UVEyWjBhTENobDduN296MzBUdzhxb3M3LzZtbGNUUlBDR3E5N09P?= =?utf-8?B?b3FVUzNKV0pqVG9VdERGUT09?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2823;6:0C/h1aH8tSb0qLkF+IfAfWg/s9FTLmeAIe6TOkgoBSztetVxUJpUcCW3nn8AH56gTuGCcSmIGrZLOcJGzyL0ao3OUQFOhbFxhVXWMcY5q6r895hYSXKKn4peiD3b/NpZdBsIKaeTxHrScc34pcbbAED4A/Acpc+Ix00jiwAV41vCABmK6XQAOWs10v808ejJwahK5zWvXs1FZXc5Oqjf/z7GcBry3tGobAmvvVa1eG8whsOeUryVkujtvU39qnvp8tq4R+Mtozge5obMicHsmNgU2ssVuD+F5+7xsYleH6/AFaacby7pH45BH6p32qCjJ7qBXyqNiXkGQYkSEcDK0Q==;5:bolXYQkiyCXfWhqSdnj4zVP7bGecvfztR+fgFlHv/ytXjkOUT914v1ho44T/SuSjlkPjR3BWnBGj08/6yQW7ibA8+FtZ6IvUQWLMCQ7C4l1RU38YKkiVrkM57+Ai3PQmHcasomZOFb2aHnYHL+kYsQ==;24:DMg7iVnSWePregjrl4oY5pXeJl9IK8RuzNXvqzZ1pJ2x6XVDx7SBxY949k/eopen9pyN/dV15rIxAUw7g+Q+/oJ1K3cYjIEP3LjfUXfH/Rc=;7:BbWL+yMNNLEuwLFhu/ZwcFgoFkuhxHqo+9jI8S3N7IbaHZ6ZMMz4votWjWplXJuoUrQ4MtMnKLQOQ4CB42skmRBXmiTM7AuBEVIg5bFHOZMN2xhKh+OOEviXRmUu/aPzAiICdBs/DDa4NKdK0PQ0hamcNPGfcdcThyypaEzAFeO+ZQBbTKY2wgXos2zwfvxEdv8IIfOsg7Afyf4kHY8bEGW3hgfSO/Zx72hImelaCJo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2823;20:b2yTaxMMT1IF2x3UosgbiVrPrUX1EXSw8a+OohtdRnbD/jMnuukuluOVPcWSYLx0UH1yiKuT0ZHUausUihy12K59VS4ZfQm2aK/fUPJL9OQ7kmo7XbXQ5MbULIIMXmdnQ7Kekz9sOsUHNuwrj92qwfUoNTTh0+ERMoUUnpqpPRs= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2017 12:19:42.5067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2823 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/2017 10:06 AM, Prasad Sodagudi wrote: > In LLVM __ubsan_handle_type_mismatch handler is renamed to > __ubsan_handle_type_mismatch_v1. Add support for > __ubsan_handle_type_mismatch_v1 handler to avoid compilation > issues with latest llvm tool chain. Also keeping > __ubsan_handle_type_mismatch handler for backward compatibility. > > Signed-off-by: Prasad Sodagudi > --- NACK. It wasn't *just* the rename, that wouldn't make any sense. It was renamed because of the change in the ABI, which is not reflected in your patch, so it can't work. > lib/ubsan.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/ubsan.c b/lib/ubsan.c > index fb0409d..9baf17d 100644 > --- a/lib/ubsan.c > +++ b/lib/ubsan.c > @@ -328,6 +328,14 @@ void __ubsan_handle_type_mismatch(struct type_mismatch_data *data, > } > EXPORT_SYMBOL(__ubsan_handle_type_mismatch); > > +void __ubsan_handle_type_mismatch_v1(struct type_mismatch_data *data, > + unsigned long ptr) > +{ > + __ubsan_handle_type_mismatch(data, ptr); > +} > +EXPORT_SYMBOL(__ubsan_handle_type_mismatch_v1); > + > + > void __ubsan_handle_nonnull_return(struct nonnull_return_data *data) > { > unsigned long flags; >