From: "Reizer, Eyal" <eyalr@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Eyal Reizer <eyalreizer@gmail.com>,
"bcousson@baylibre.com" <bcousson@baylibre.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Loewy, Chen" <c-loewy@ti.com>
Subject: RE: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support
Date: Mon, 7 May 2018 06:55:03 +0000 [thread overview]
Message-ID: <a4dd3009f0f5492d8756f42c11590423@ti.com> (raw)
In-Reply-To: <20180506165621.GL98604@atomide.com>
Hi Tony,
>
> Yeah my guess is that the reason for the separate GPIO interrupt was
> that on omap3 we did not have SDIO interrupt working for years. This was
> because of the issues related to padconf interrupts for off mode.
>
> We now have Linux generic wakeirq support working with SDIO and it has
> been confirmed to work also for off mode with mwifiex at least. So
> there should be no reason to not also use the SDIO interrupt.
>
There is more to this than just the padconf.
Using in-band interrupt instead of the out of band one requires
Supporting a feature called "Asynchronous interrupts in 4Bit mode"
Which is part of SDIO 3.0 spec:
https://www.sdcard.org/downloads/pls/pdf/index.php?p=PartE1_SDIO_Simplified_Specification_Ver3.00.jpg&f=PartE1_SDIO_Simplified_Specification_Ver3.00.pdf&e=EN_SSE1
Take a look at page 41 at the bottom part of the table.
Wilink8 supports this feature but AFAIK this support is still not part of the
mmc/sdio core in the Linux kernel.
If we want wilink8 to trigger a host wakeup using the in-band interrupt instead
Of the wlan_irq pin we would need to enable/use this feature.
I did use it internally in the past and was able to patch the Ubuntu kernel
(3.5.0 at that time) to use wilink8 in a standard SD Card slot of an Ubuntu Laptop
while removing the use of wlan_irq pin completely.
However this was an experimental patch set written by a third party
that was not up-steamtable at that time.
I do have this patch set somewhere...
It is similar to the following patch which is not upstream as well for some reason:
https://gitlab.com/k2wl/g2_kernel/commit/5c4970fdaa50422d7ea7220efa20fb35148a4bca
It is not the only patch needed, there are a couple of additional patches needed
for fully using it from driver.
I did check latest Linux-next and don't see this support there. Not sure why.
Best Regards,
Eyal
next prev parent reply other threads:[~2018-05-07 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 7:24 Eyal Reizer
2018-05-02 8:30 ` Sekhar Nori
2018-05-02 13:40 ` Reizer, Eyal
2018-05-02 14:51 ` Tony Lindgren
2018-05-03 6:41 ` [EXTERNAL] " Reizer, Eyal
2018-05-03 14:17 ` Tony Lindgren
2018-05-06 7:45 ` Reizer, Eyal
2018-05-06 16:56 ` Tony Lindgren
2018-05-07 6:55 ` Reizer, Eyal [this message]
2018-05-07 15:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4dd3009f0f5492d8756f42c11590423@ti.com \
--to=eyalr@ti.com \
--cc=bcousson@baylibre.com \
--cc=c-loewy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=eyalreizer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®