From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA140219A7A for ; Tue, 17 Mar 2026 22:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786189; cv=none; b=FzLPojijaMtGtB/mVZial/F0Lf9CMZakTPN4vLH6AXqc32wJLA4mxIuu/9BhgrDJ7VibJXl4tv9aDMFNm3WFaqq1skHl1wV90yZoqXacwfjaSbMymqALu4lhDuPV7+vSO5RqNtHOo7yjmtJAIlzMyKJUxCIzrmbuNWPaijAD/+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786189; c=relaxed/simple; bh=Q9LZ07fCCXhRoxjgTndK3nKluanuzYpcsQtLd1ru28I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PMPnRHlI/uwuz5DEV5Bx6+sWoXgjgbQVoyMJrT/VkhUQjncTqWPjbdpIyNHsBDtJtpUXpZq4oJXGOm73FZ18Lf4/jrrxqWBNOsxvAhIeTahLWM7vShMS2JBZiQRFxg5w//mB1giFnSY4njG08+NO6IKwwwKgXKpWBm9odnUnvoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AXqhla5f; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AXqhla5f" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2bea8220c38so152013eec.1 for ; Tue, 17 Mar 2026 15:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773786188; x=1774390988; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=W61FjlgmSjYLAaowkOupK3Ne06cSXA9WNaHsWuJiiT4=; b=AXqhla5fiZJMaqjEf3mdvojCnFxxA8EH+EKHTB4xfkTvnnw9lzu/+DPTplj15AMBOO eU4t8E62U+D+oZFysRXB/0wRw9pn7ne4xgKDbIpbihHLKwowVC8niKYm9Yx/Jqp2vYRc +nd1DKoK8vN1Q1JtNhsERHbMBwizxBo5XVNNf1ZAEIjIeLHlJmtZA6HctkTHtGLDduF2 mXvEtDEZ3vG11beORUb9F2O2fhEO5vdCTlcSltfbP/0iDJZpzHEXMk1atNeerJFroIZp H2FfIEWyFJuIZSmAJMtcTT7YklGbBgiVY4cgVa+ypoc3iJR8UMO17ge37Y7j67FGbwMB qh6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773786188; x=1774390988; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W61FjlgmSjYLAaowkOupK3Ne06cSXA9WNaHsWuJiiT4=; b=SDhCw7EJwWzzsAmJg9TskKv56oZyj+AGXkQXZHiLLBC0C/gLNdGNZaQ2FGx+REE3Hd zScQb4yqWqy8vWUl5GvzuK015tI+C8rohOl/4phPZhF7zdOUmMIS2Mj8QPN+lctozh6D IGVp+GqWtZrr83BNMTL5K1yroPimsAVWphDpQdYlfT8f6ueXK5ms0crXS0EUAMu1jdf2 rM8w6yUkeVficefG1gcrgEyTihIS5w8yoL8TtyDG27PDF1tGFX8xyEQrT1fAti0NYOYj OPb7DSD4aBz/xu4yAh3LkMPH2Q9sZtEpOxMRcHVHBt3X7h3K0ZjTiTav+4w7EpmCFu+T lVTg== X-Forwarded-Encrypted: i=1; AJvYcCUi4h4SQce7XtOVH3OYmUdAdSR5KW/z5kMERAzRl4jtKieaDEUk0FQiUCr+ikYP88swLog4pkCJtHwEx1Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3MJx4i3kSD9ycAWa0qOF3rxoLZ05iylX5ytfQOjsQvxU0HMA0 L+ou9XKxSsv8ByodStKXnoHe5xIc97sDF3PuXG37ZXrUxl/azNc890B2 X-Gm-Gg: ATEYQzymft4JsJQmlUyOKZ80Im3gLMoctmMmIhD6CkuOauzM4LeFKd0TL21w1b3bCpJ 2PndWVvbGWq/4mNsr6+SMr2MLI+cOK4Abkn0CuB0lWGtkjMI8H9piYnQ9pMY0qRHcMbekw+L6vi nQxuLnW8hwi35l+FhLWpSx+2HIdWdiszTf+P7CKR01RXmBlL9a5AgsPztJcOwscuQ/7fBkISuRu fT8VnxsfSyDoU4YuQsHiW5rNVqQAreVey1fX/VRBQ6rTSwxzdSBRyoL9R8HdI/e0+F7pPM8wtRu ZUGvf7XEKi4IGSvY52ECsvF+0GkusCFkkQRl0mcWVu4omI+y02jTmZq9XerlY/xF3pkh7bV/2CQ 2Exiysfp7C/ZrT0UZb4pqoDiLaXVfu2l0JXhDjCj2l4iUkT079g7x++fL8jKie7cl+mkLexGgft 5lMXycmXXkTguBe9+AITpNAK2H3VwVjVqtJoY+ X-Received: by 2002:a05:7301:1285:b0:2be:617:2dec with SMTP id 5a478bee46e88-2c0e503e6dfmr603879eec.17.1773786187847; Tue, 17 Mar 2026 15:23:07 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55a2be4sm1423580eec.22.2026.03.17.15.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 15:23:07 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 17 Mar 2026 15:23:06 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "vasileios.amoiridis@cern.ch" , "leo.yang.sy0@gmail.com" , "wensheng@yeah.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: Re: [PATCH 0/5] hwmon: (pmbus) Fix unchecked error returns in multiple drivers Message-ID: References: <20260317173308.382545-1-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317173308.382545-1-sanman.pradhan@hpe.com> On Tue, Mar 17, 2026 at 05:36:33PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > Several PMBus device drivers use the return value of pmbus_read_word_data() > or pmbus_read_byte_data() in arithmetic, bitwise, or macro operations > without first checking for a negative error code. If the underlying I2C > transaction fails, the negative errno propagates into FIELD_GET(), > FIELD_PREP(), XOR, or DIV_ROUND_CLOSEST operations, silently producing > corrupted sensor or status data instead of reporting the error. > AI review feedback is at https://sashiko.dev/#/patchset/20260317174553.385567-1-sanman.pradhan%40hpe.com One of the drivers (see patch 4 feedback) has an unrelated problem, for which I would appreciate a fix, but patch 5/5 is making a wrong functional change which needs to be fixed. I'll apply patches 1..4 of the series. Thanks, Guenter > Sanman Pradhan (5): > hwmon: (pmbus/hac300s) Add error check for pmbus_read_word_data() > return value > hwmon: (pmbus/mp2975) Add error check for pmbus_read_word_data() > return value > hwmon: (pmbus/mp2869) Check pmbus_read_byte_data() before using its > return value > hwmon: (pmbus/ina233) Add error check for pmbus_read_word_data() > return value > hwmon: (pmbus/isl68137) Fix unchecked return value and use > sysfs_emit() > > drivers/hwmon/pmbus/hac300s.c | 2 ++ > drivers/hwmon/pmbus/ina233.c | 2 ++ > drivers/hwmon/pmbus/isl68137.c | 7 +++++-- > drivers/hwmon/pmbus/mp2869.c | 35 ++++++++++++++++++++-------------- > drivers/hwmon/pmbus/mp2975.c | 2 ++ > 5 files changed, 32 insertions(+), 16 deletions(-) > > -- > 2.34.1 > >