From: Andrew Lunn <andrew@lunn.ch>
To: Steven Price <steven.price@arm.com>
Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Yanteng Si <si.yanteng@linux.dev>, Furong Xu <0x1207@gmail.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 3/3] net: stmmac: Specify hardware capability value when FIFO size isn't specified
Date: Fri, 31 Jan 2025 15:47:45 +0100 [thread overview]
Message-ID: <a4e31542-3534-4856-a90f-e47960ed0907@lunn.ch> (raw)
In-Reply-To: <f343c126-fed9-4209-a18d-61a4e604db2f@arm.com>
> > I'm guessing, but in your setup, i assume the value is never written
> > to a register, hence 0 is O.K. e.g. dwmac1000_dma_operation_mode_rx(),
> > the fifosz value is used to determine if flow control can be used, but
> > is otherwise ignored.
>
> I haven't traced the code, but that fits my assumptions too.
I could probably figure it out using code review, but do you know
which set of DMA operations your hardware uses? A quick look at
dwmac-rk.c i see:
/* If the stmmac is not already selected as gmac4,
* then make sure we fallback to gmac.
*/
if (!plat_dat->has_gmac4)
plat_dat->has_gmac = true;
Which suggests there are two variants of the RockChip MAC.
Andrew
next prev parent reply other threads:[~2025-01-31 14:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 1:38 [PATCH net v4 0/3] Limit devicetree parameters to hardware capability Kunihiko Hayashi
2025-01-27 1:38 ` [PATCH net v4 1/3] net: stmmac: Limit the number of MTL queues " Kunihiko Hayashi
2025-01-27 18:07 ` Yanteng Si
2025-01-27 1:38 ` [PATCH net v4 2/3] net: stmmac: Limit FIFO size by " Kunihiko Hayashi
2025-01-27 18:11 ` Yanteng Si
2025-01-27 1:38 ` [PATCH net v4 3/3] net: stmmac: Specify hardware capability value when FIFO size isn't specified Kunihiko Hayashi
2025-01-27 18:24 ` Yanteng Si
2025-01-31 9:46 ` Steven Price
2025-01-31 14:15 ` Andrew Lunn
2025-01-31 14:33 ` Steven Price
2025-01-31 14:47 ` Andrew Lunn [this message]
2025-01-31 15:03 ` Steven Price
2025-01-31 15:29 ` Andrew Lunn
2025-01-31 15:54 ` Steven Price
2025-01-31 16:07 ` Andrew Lunn
2025-02-01 12:10 ` Xi Ruoyao
2025-02-01 21:03 ` Andrew Lunn
2025-02-01 19:14 ` Guenter Roeck
2025-02-01 19:21 ` Andrew Lunn
2025-02-01 20:25 ` Guenter Roeck
2025-02-01 20:35 ` Russell King (Oracle)
2025-02-01 22:02 ` Guenter Roeck
2025-02-03 2:45 ` Kunihiko Hayashi
2025-02-03 9:23 ` Russell King (Oracle)
2025-02-03 11:32 ` Kunihiko Hayashi
2025-02-03 11:55 ` Kunihiko Hayashi
2025-01-28 12:20 ` [PATCH net v4 0/3] Limit devicetree parameters to hardware capability patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e31542-3534-4856-a90f-e47960ed0907@lunn.ch \
--to=andrew@lunn.ch \
--cc=0x1207@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=si.yanteng@linux.dev \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®