From: Markus Elfring <Markus.Elfring@web.de>
To: Wang YanQing <udknight@gmail.com>, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH v3] checkpatch: add support to check 'Fixes:' tag format
Date: Fri, 1 May 2020 18:08:58 +0200 [thread overview]
Message-ID: <a4e38d72-ae8f-9a20-b7c5-7e6880f6642c@web.de> (raw)
In-Reply-To: <20200501154033.GA25730@udknight>
> The check supports below formats:
I suggest to omit the concrete examples.
I would prefer the explicit wording for the support of (Unicode) ellipses
also in the shown commit titles.
Will the document “submitting-patches.rst” need a corresponding adjustment?
> The check doesn't support below formats:
How do you think about to extend error diagnostics for patch checking?
> Fixes: f2c2e717642c ("usb: gadget: add raw-gadget interface"
Missing closing parenthesis
> Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
Missing enclosing delimiters
> Fixes: 3fd6e7d9a146 (ASoC: tas571x: New driver for TI TAS571x power amplifiers)
> Fixes: 55697cbb44e4 ("arm64: dts: renesas: r8a779{65,80,90}: Add IPMMU devices nodes)
Missing quotation characters
> Fixes: ba35f8588f47 (“ipvlan: Defer multicast / broadcast processing to a work-queue”)
…
> Fixes: 03f6fc6de919 ('ASoC: rt5682: Add the soundwire support')
Would we like to tolerate such quotation character alternatives?
> Fixes: 9b1640686470 ("scsi: lpfc: Fix use-after-free mailbox cmd completion")
How do you think about to tolerate extra white-space characters around
the commit identifier?
> Note: this patch also fixes double quotation mark issue for normal git
> commit description, and now it supports double quotation mark in
> title line, for example:
> Commit e33e2241e272 ("Revert "cfg80211: Use 5MHz bandwidth by default
> when checking usable channels"")
I find that such an example should trigger further software development considerations
for a safe data format description.
> v2:
> 1: Add support for double quotation mark in title line, suggested by Markus Elfring.
I guess that the clarification is still evolving also around this aspect.
Regards,
Markus
prev parent reply other threads:[~2020-05-01 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 15:40 Wang YanQing
2020-05-01 15:57 ` Joe Perches
2020-05-01 16:34 ` Wang YanQing
2020-05-01 16:44 ` Joe Perches
2020-05-01 16:52 ` Markus Elfring
2020-05-01 16:08 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e38d72-ae8f-9a20-b7c5-7e6880f6642c@web.de \
--to=markus.elfring@web.de \
--cc=alexei.starovoitov@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®