mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: John Garry <john.g.garry@oracle.com>,
	linux-perf-users@vger.kernel.org, irogers@google.com,
	renyu.zj@linux.alibaba.com
Cc: Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Nick Forrington <nick.forrington@arm.com>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org
Subject: Re: [PATCH v4 4/6] perf vendor events arm64: Update scale units and descriptions of common topdown metrics
Date: Wed, 9 Aug 2023 13:59:01 +0100	[thread overview]
Message-ID: <a4e55994-aa8e-572a-edb2-ac91046e5d08@arm.com> (raw)
In-Reply-To: <6c8c46f0-b567-68c8-2ce7-3d1a8a21569b@oracle.com>



On 08/08/2023 09:46, John Garry wrote:
> On 07/08/2023 15:20, James Clark wrote:
>> Metrics will be published here [1] going forwards, but they have
>> slightly different scale units. To allow autogenerated metrics to be
>> added more easily, update the scale units to match.
>>
>> The more detailed descriptions have also been taken and added to the
>> common file.
> 
> It's unfortunate that we can't have a concise description - like which
> we have now - and a full description.
> 
>>
> 
> Anyway,
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> 

Yes unfortunately in the source data the metric short description
("title") pretty much just matches the metric name but without
underscores. For that reason we chose not to use it for Perf's short
description otherwise the list command showed a lot of duplication.

  "frontend_bound": {
    "title": "Frontend Bound",
    "description": "This metric is the percentage of...

The PMU events on the other hand do have a short description in the
title field rather than just repeating the name:

  ITLB_WALK": {
    "code": "0x0035",
    "title": "Instruction TLB access with at least one translation table
walk",
    "description": "Counts instruction memory translation table walks
caused by a miss in the L2...

I can raise this internally as it does seem to be a bit of an inconsistency.

James

  reply	other threads:[~2023-08-09 12:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 14:20 [PATCH v4 0/6] perf vendor events arm64: Update N2 and V2 metrics and events using Arm telemetry repo James Clark
2023-08-07 14:20 ` [PATCH v4 1/6] perf: cs-etm: Don't duplicate FIELD_GET() James Clark
2023-08-08  7:36   ` John Garry
2023-08-07 14:20 ` [PATCH v4 2/6] perf arm64: Allow version comparisons of CPU IDs James Clark
2023-08-07 14:20 ` [PATCH v4 3/6] perf test: Add a test for the new Arm CPU ID comparison behavior James Clark
2023-08-07 14:20 ` [PATCH v4 4/6] perf vendor events arm64: Update scale units and descriptions of common topdown metrics James Clark
2023-08-08  8:46   ` John Garry
2023-08-09 12:59     ` James Clark [this message]
2023-08-07 14:20 ` [PATCH v4 5/6] perf vendor events arm64: Update stall_slot workaround for N2 r0p3 James Clark
2023-08-08 10:18   ` John Garry
2023-08-09 13:06     ` James Clark
2023-08-09 13:54       ` John Garry
2023-08-09 15:14         ` James Clark
2023-08-07 14:20 ` [PATCH v4 6/6] perf vendor events arm64: Update N2 and V2 metrics and events using Arm telemetry repo James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4e55994-aa8e-572a-edb2-ac91046e5d08@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=eddyz87@gmail.com \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=nick.forrington@arm.com \
    --cc=peterz@infradead.org \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®