From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C440F2DF71B for ; Thu, 9 Oct 2025 11:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760010215; cv=none; b=cG39w1bygSJT9jrLzyIrOu3auLWCJZR/1CQ0ezhri5gfTAwZvXP56Dz15i0J7tEBx83s9wrJF8UPRmkewIqtCZi0b6LUwT6t2OTtxl/NnHOnapouAw4RwDsRz8yOM+iFmmLHgACpTSeGKzi8xiDS7YAs7N9mbJFNLqsNoOeiKFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760010215; c=relaxed/simple; bh=tmj+vqID2stoZTnrovV4ZydTngVL9314LGt/KjTL3+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lY8A8ML3xc3jP8AMDvBta6/ycH0tUdXbzH6eEUifFO7s2tJrMfAIxdNfZqwfdIMRkMuu7d+CPOBht2s/2/Ai07Mph7hz50dEeqq4TinGVhUuPKFg7JmBfEO300C4Z0M9wSX6mkUV3lcdVoCODh+tGOP5F0KBhgN4bG9eNcotU6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=AbZ19RRZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=KdqOzkuK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=TKWwB8UU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uLhpTnJ8; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="AbZ19RRZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="KdqOzkuK"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="TKWwB8UU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uLhpTnJ8" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E10A31F78B; Thu, 9 Oct 2025 11:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760010212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M+fSniwpzHs25VKtHpH5PnHd4TBNPg09lmllWBQnnco=; b=AbZ19RRZ1Gab04QEHkQPCyOtss3ILjUzWwC/lvzQIk/SFAtOBFIwLADl8BURL0TcEsc6AY hsmvgJyzoMzgHgjHDY7F/+D1oaWWrVoYmJv8qpjLBQTabd1+yBl4uXnkwbSQ++AZHaLsj2 Jl6/ew7yAhr7J27AhoB/SDGv/NEYMOY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760010212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M+fSniwpzHs25VKtHpH5PnHd4TBNPg09lmllWBQnnco=; b=KdqOzkuKiBzOlokeBmqCshd1Bk4JID/z6u6ObLZYXv/4N5bHGqQq3ULNrKSnay7nhSbEwG zeN6flV8ea8/FuCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TKWwB8UU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=uLhpTnJ8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760010211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M+fSniwpzHs25VKtHpH5PnHd4TBNPg09lmllWBQnnco=; b=TKWwB8UUrfInlb7JV6Ue7b6Qa+HmUsNABoZi5KlPU1oWYbba1wOr8D0apRcsmYmFgI4Q1j TfBiSIE6W6XyzyQFcVaEEBiEPPOMpBnLXOGhQ2mhRSQ7RqPDArHU6TaRHOMyM3GEW3Caqg 9T0yI0sCG7Ad+Rbmp4Ff29QEdna2SiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760010211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M+fSniwpzHs25VKtHpH5PnHd4TBNPg09lmllWBQnnco=; b=uLhpTnJ8cNQbj9gep1wfo+f/Uz4hDyqiBjnfAiIXfmGJxtIx0ZPoFxvEhSEKRaQDI33S9n Wd+uNOQVrQxDfQDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A46C613A61; Thu, 9 Oct 2025 11:43:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vlyuJuOf52h8VwAAD6G6ig (envelope-from ); Thu, 09 Oct 2025 11:43:31 +0000 Message-ID: Date: Thu, 9 Oct 2025 13:43:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fbdev: Fix logic error in "offb" name match To: Finn Thain , Simona Vetter , Helge Deller , Javier Martinez Canillas Cc: stable@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FREEMAIL_ENVRCPT(0.00)[gmx.de]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[linux-m68k.org,ffwll.ch,gmx.de,redhat.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email,linux-m68k.org:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Level: X-Rspamd-Queue-Id: E10A31F78B X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -4.51 Am 09.10.25 um 00:56 schrieb Finn Thain: > A regression was reported to me recently whereby /dev/fb0 had disappeared > from a PowerBook G3 Series "Wallstreet". The problem shows up when the > "video=ofonly" parameter is passed to the kernel, which is what the > bootloader does when "no video driver" is selected. The cause of the > problem is the "offb" string comparison, which got mangled when it got > refactored. Fix it. > > Cc: stable@vger.kernel.org > Fixes: 93604a5ade3a ("fbdev: Handle video= parameter in video/cmdline.c") > Reported-and-tested-by: Stan Johnson > Signed-off-by: Finn Thain Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/core/fb_cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/core/fb_cmdline.c b/drivers/video/fbdev/core/fb_cmdline.c > index 4d1634c492ec..594b60424d1c 100644 > --- a/drivers/video/fbdev/core/fb_cmdline.c > +++ b/drivers/video/fbdev/core/fb_cmdline.c > @@ -40,7 +40,7 @@ int fb_get_options(const char *name, char **option) > bool enabled; > > if (name) > - is_of = strncmp(name, "offb", 4); > + is_of = !strncmp(name, "offb", 4); > > enabled = __video_get_options(name, &options, is_of); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)