From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762008AbXHVPxR (ORCPT ); Wed, 22 Aug 2007 11:53:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754871AbXHVPxG (ORCPT ); Wed, 22 Aug 2007 11:53:06 -0400 Received: from wa-out-1112.google.com ([209.85.146.182]:42076 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbXHVPxD (ORCPT ); Wed, 22 Aug 2007 11:53:03 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rU8sWnzaMlxbhACBtw1mBF3VhafeHWzQaFKBTZ1+84p/OTy/B3Rmt8MfLtnQ/uncQ/wmBYIeoLCWNsWtmoA/+OM/6ENW3TgKTSFIQMSedFQPG8WuJQwpQPSOl4/SxtABykzY8wfWgpHMIabBdAnSSJjOk2A5uWc5KB7RtrLDj+w= Message-ID: Date: Wed, 22 Aug 2007 10:53:02 -0500 From: "Eric Van Hensbergen" To: "Willy Tarreau" Subject: Re: [2.6.20.17 review 32/58] fs: 9p/conv.c error path fix Cc: linux-kernel@vger.kernel.org, stable@kernel.org, "Mariusz Kozlowski" , "Andrew Morton" , "Greg Kroah-Hartman" In-Reply-To: <20070822084023.%N@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070822083844.%N@1wt.eu> <20070822084023.%N@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 8/22/07, Willy Tarreau wrote: > When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err)) > and it will not be happy about it. > > Signed-off-by: Mariusz Kozlowski > Cc: Andrew Morton > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Willy Tarreau Acked-by: Eric Van Hensbergen This seems to be in the current code as well, I'll forward-port the patch... -eric