From: Eric Van Hensbergen <ericvh@gmail.com>
To: Abhishek Kulkarni <adkulkar@umail.iu.edu>
Cc: linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] [9P PATCH 1/2] 9p: Fix incorrect parameters to v9fs_file_readn.
Date: Tue, 14 Jul 2009 13:30:33 -0500 [thread overview]
Message-ID: <a4e6962a0907141130h5dedd444i8f1eaf99b20ed34@mail.gmail.com> (raw)
In-Reply-To: <1246474254-10401-1-git-send-email-adkulkar@umail.iu.edu>
applied v9fs-devel
On Wed, Jul 1, 2009 at 1:50 PM, Abhishek Kulkarni<adkulkar@umail.iu.edu> wrote:
> Fix v9fs_vfs_readpage. The offset and size parameters to v9fs_file_readn
> were interchanged and hence passed incorrectly.
>
> Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
> ---
> :100644 100644 6fcb1e7... 9282828... M fs/9p/vfs_addr.c
> fs/9p/vfs_addr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c
> index 6fcb1e7..9282828 100644
> --- a/fs/9p/vfs_addr.c
> +++ b/fs/9p/vfs_addr.c
> @@ -57,7 +57,7 @@ static int v9fs_vfs_readpage(struct file *filp, struct page *page)
> buffer = kmap(page);
> offset = page_offset(page);
>
> - retval = v9fs_file_readn(filp, buffer, NULL, offset, PAGE_CACHE_SIZE);
> + retval = v9fs_file_readn(filp, buffer, NULL, PAGE_CACHE_SIZE, offset);
> if (retval < 0)
> goto done;
>
> --
> 1.6.3.3
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>
prev parent reply other threads:[~2009-07-14 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 18:50 Abhishek Kulkarni
2009-07-01 18:50 ` [9P PATCH 2/2] net/9p: Fix crash due to bad mount parameters Abhishek Kulkarni
2009-07-02 20:18 ` David Miller
2009-07-14 18:30 ` Eric Van Hensbergen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e6962a0907141130h5dedd444i8f1eaf99b20ed34@mail.gmail.com \
--to=ericvh@gmail.com \
--cc=adkulkar@umail.iu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®