From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EC8C3E8C5 for ; Fri, 27 Nov 2020 22:17:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7260222228 for ; Fri, 27 Nov 2020 22:17:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731868AbgK0WRR (ORCPT ); Fri, 27 Nov 2020 17:17:17 -0500 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:59776 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731783AbgK0WLG (ORCPT ); Fri, 27 Nov 2020 17:11:06 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 1FCA218043D23; Fri, 27 Nov 2020 22:10:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: vase42_2916d252738b X-Filterd-Recvd-Size: 2116 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Fri, 27 Nov 2020 22:10:47 +0000 (UTC) Message-ID: Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix From: Joe Perches To: trix@redhat.com, apw@canonical.com, nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com Cc: linux-kernel@vger.kernel.org Date: Fri, 27 Nov 2020 14:10:46 -0800 In-Reply-To: <20201127214316.3045640-1-trix@redhat.com> References: <20201127214316.3045640-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-11-27 at 13:43 -0800, trix@redhat.com wrote: > From: Tom Rix > > From > RFC MAINTAINERS tag for cleanup robot > https://lkml.org/lkml/2020/11/21/190 I think this should be RFC. It looks as as if it's only for subsystems through A > The prefix used by subsystems in their commit log is arbitrary. > To elimitate the time and effort to manually find a reasonable > prefix, store the preferred prefix in the MAINTAINERS file. > > Populate with reasonable prefixes using this algorithm. > What did the maintainers use in their commits? > If there were no maintainers commits then what did everyone > else use in their commits. The algorithm used to produce these prefixes should also be published. > The results were manually reviewed and about 25% were rejected. Because this isn't necessarily the best option. I think an exception mechanism would be better than a specific mechanism added to various entries. >  # check MAINTAINERS entries for the right ordering too > - my $preferred_order = 'MRLSWQBCPTFXNK'; > + my $preferred_order = 'MRLSWQBCPTFXNKD'; >   if ($rawline =~ /^\+[A-Z]:/ && >   $prevrawline =~ /^[\+ ][A-Z]:/) { >   $rawline =~ /^\+([A-Z]):\s*(.*)/; I'd prefer to keep the file and keyword list last.