mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: x86@kernel.org, linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: Len Brown <len.brown@intel.com>
Subject: [PATCH 3/4] x86, idle: make default_idle() static
Date: Fri, 27 Jul 2012 18:42:54 -0400	[thread overview]
Message-ID: <a4eaab6aa17a36fb01bbc2dfb481e8fbc8a5c98d.1343428708.git.len.brown@intel.com> (raw)
In-Reply-To: <1343428975-3897-1-git-send-email-lenb@kernel.org>
In-Reply-To: <06ed885aac76cc68bd1ca1f32c8dcab7bcca1940.1343428708.git.len.brown@intel.com>

From: Len Brown <len.brown@intel.com>

default_idle() was public and exported to modules
for the benefit of APM.  But APM no longer touches
default_idle(), so default_idle() can now be private.

Cc: x86@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
---
 arch/x86/include/asm/processor.h | 1 -
 arch/x86/kernel/process.c        | 5 +----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 39bc577..b02e48c 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -979,7 +979,6 @@ extern bool cpu_has_amd_erratum(const int *);
 extern unsigned long arch_align_stack(unsigned long sp);
 extern void free_init_pages(char *what, unsigned long begin, unsigned long end);
 
-void default_idle(void);
 bool set_pm_idle_to_default(void);
 
 void stop_this_cpu(void *dummy);
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 735279e..165f870 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -479,7 +479,7 @@ void cpu_idle(void)
  * We use this if we don't have any better
  * idle routine..
  */
-void default_idle(void)
+static void default_idle(void)
 {
 	if (hlt_use_halt()) {
 		trace_power_start_rcuidle(POWER_CSTATE, 1, smp_processor_id());
@@ -504,9 +504,6 @@ void default_idle(void)
 		cpu_relax();
 	}
 }
-#ifdef CONFIG_APM_MODULE
-EXPORT_SYMBOL(default_idle);
-#endif
 
 bool set_pm_idle_to_default(void)
 {
-- 
1.7.12.rc0


  parent reply	other threads:[~2012-07-27 22:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 22:42 [0/4] pm_idle, default_idle cleanup Len Brown
2012-07-27 22:42 ` [PATCH 1/4] Revert "x86 idle APM: deprecate CONFIG_APM_CPU_IDLE" to prepare for actual removal Len Brown
2012-07-27 22:42   ` [PATCH 2/4] x86 idle APM: delete apm_cpu_idle() Len Brown
2012-07-28 10:11     ` Alan Cox
2012-07-29  2:21       ` Len Brown
2012-07-27 22:42   ` Len Brown [this message]
     [not found]   ` <0753050fb227e5a19f0df303d1e9bf74534aabcd.1343428708.git.len.brown@intel.com>
2012-08-07 23:26     ` [linux-pm] [PATCH 4/4] PM: cleanup: stop mandating that platforms export (pm_idle)() Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4eaab6aa17a36fb01bbc2dfb481e8fbc8a5c98d.1343428708.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome