From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] spi: cs42l43: Workaround for wrong speaker ID on Dell XPS 13 DX13260
Date: Fri, 25 Sep 2026 16:59:37 +0100 [thread overview]
Message-ID: <a4eb6a0a-ef51-45ce-81c4-b3098c1695e3@opensource.cirrus.com> (raw)
In-Reply-To: <20260919134730.895381-1-rf@opensource.cirrus.com>
On 19/9/26 14:47, Richard Fitzgerald wrote:
> Create an acpi_gpio_mapping so that speaker ID GPIOs can be read directly
> from the ACPI GpioIo() instead of relying on the spk-id-gpios property to
> have the correct number of pins. Change the reading loop to read each pin
> one at a time until it reaches a pin index that doesn't exist.
>
> This fixes problems on Dell XPS 13 DX13260:
Don't merge this.
I've heard there are plans to change the way speaker ID GPIOs are
defined in ACPI for future products. It will make them more compatible
with the "Linux way" and will work with the existing code in the cs42l43
and cs35l56 drivers. But would no longer be the "Windows way" so won't
work with the Windows-style method in this patch.
Which means this Dell model will likely be the only one with speaker ID
defined this particular way so will need to be a model-specific quirk.
prev parent reply other threads:[~2026-09-25 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 13:47 Richard Fitzgerald
2026-09-20 15:14 ` Mark Brown
2026-09-25 13:14 ` Richard Fitzgerald
2026-09-25 14:51 ` Mark Brown
2026-09-25 15:28 ` Richard Fitzgerald
2026-09-25 15:59 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4eb6a0a-ef51-45ce-81c4-b3098c1695e3@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®