From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Kyle Hendry <kylehendrydev@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: noltari@gmail.com, jonas.gorski@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 0/6] net: dsa: b53: mmap: Add bcm63xx EPHY power and reset control
Date: Fri, 27 Jun 2025 16:08:06 -0700 [thread overview]
Message-ID: <a4ee184b-f2f8-4c0b-97c3-c853ac375f63@broadcom.com> (raw)
In-Reply-To: <20250620134132.5195-1-kylehendrydev@gmail.com>
On 6/20/25 06:41, Kyle Hendry wrote:
> Some bcm63268 bootloaders hold the fast ethernet phys in reset
> causing an error when they're probed. The resets are controlled
> by a register in the gpio controller, and would need a minimal
> driver to set. However, that register also controls the
> power states of the EPHYs. I'm trying to implement both
> functionalities at the same time to make sure that they don't
> interfere with eachother. These patches allow control of the
> ephy register from the b53 switch driver.
>
> Is this the right place for this code, or should it be in a
> power domain? Should the resets be handled by a separate reset
> controller?
Good question, it seems like a reset controller might work with one
reset per port being defined? Unfortunately the register in the GPIO
controller is not logically part of a GPIO interface, it's just where it
landed because that was convenient for the designer.
--
Florian
prev parent reply other threads:[~2025-06-27 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 13:41 Kyle Hendry
2025-06-20 13:41 ` [RFC PATCH net-next 1/6] net: dsa: b53: Add phy_enable(), phy_disable() methods Kyle Hendry
2025-06-20 13:41 ` [RFC PATCH net-next 2/6] net: dsa: b53: mmap: Add reference to bcm63xx gpio controller Kyle Hendry
2025-06-20 13:41 ` [RFC PATCH net-next 3/6] dt-bindings: net: dsa: b53: Document brcm,gpio-ctrl property Kyle Hendry
2025-06-27 19:57 ` Rob Herring
2025-06-20 13:41 ` [RFC PATCH net-next 4/6] net: dsa: b53: mmap: Add register layout for bcm63268 Kyle Hendry
2025-06-20 13:41 ` [RFC PATCH net-next 5/6] net: dsa: b53: mmap: Clear resets on bcm63xx EPHYs Kyle Hendry
2025-06-20 13:41 ` [RFC PATCH net-next 6/6] net: dsa: b53: mmap: Implement bcm63xx ephy power control Kyle Hendry
2025-06-27 23:08 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4ee184b-f2f8-4c0b-97c3-c853ac375f63@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jonas.gorski@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kylehendrydev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®