From: David Ahern <dsahern@kernel.org>
To: Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, pabeni@redhat.com,
edumazet@google.com, kuba@kernel.org, a@unstable.cc,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address
Date: Sun, 29 Jan 2023 11:14:34 -0700 [thread overview]
Message-ID: <a4f4392f-cc15-86e0-9b63-12678b65d58f@kernel.org> (raw)
In-Reply-To: <20230127025941.2813766-2-Thomas.Winter@alliedtelesis.co.nz>
A couple of nits.
On 1/26/23 7:59 PM, Thomas Winter wrote:
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index f7a84a4acffc..0065b38fc85b 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3355,7 +3355,7 @@ static void addrconf_addr_gen(struct inet6_dev *idev, bool prefix_route)
> }
> }
>
> -static void addrconf_dev_config(struct net_device *dev)
> +static void addrconf_eth_config(struct net_device *dev)
why the rename of this function? It does more than ethernet config.
> {
> struct inet6_dev *idev;
>
> @@ -3447,6 +3447,30 @@ static void addrconf_gre_config(struct net_device *dev)
> }
> #endif
>
> +static void addrconfig_init_auto_addrs(struct net_device *dev)
this one should be 'addrconf_' to be consistent with related function names.
next prev parent reply other threads:[~2023-01-29 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 2:59 [PATCH v4 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses Thomas Winter
2023-01-27 2:59 ` [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address Thomas Winter
2023-01-29 18:14 ` David Ahern [this message]
2023-01-31 3:32 ` Thomas Winter
2023-01-27 2:59 ` [PATCH v4 2/2] ip/ip6_gre: Fix non-point-to-point tunnel " Thomas Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4f4392f-cc15-86e0-9b63-12678b65d58f@kernel.org \
--to=dsahern@kernel.org \
--cc=Thomas.Winter@alliedtelesis.co.nz \
--cc=a@unstable.cc \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®