mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen: don't use privcmd_call() from xen_mc_flush()
Date: Tue, 7 Aug 2018 10:02:43 -0400	[thread overview]
Message-ID: <a4f76a2a-128f-3e2a-44ee-04d57ab5be12@oracle.com> (raw)
In-Reply-To: <2a9600b0-3b49-7835-a664-9deb30b100a4@suse.com>

On 08/07/2018 09:11 AM, Juergen Gross wrote:
> On 13/06/18 11:58, Juergen Gross wrote:
>> Using privcmd_call() for a singleton multicall seems to be wrong, as
>> privcmd_call() is using stac()/clac() to enable hypervisor access to
>> Linux user space.
>>
>> Add a new xen_single_call() function to be use for that purpose.
>>
>> Reported-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> Boris, any objections?


I think Jan wanted a change in commit message. I can commit with this:

"Using privcmd_call() for a singleton multicall seems to be wrong, as
 privcmd_call() is using stac()/clac() to enable hypervisor access to
 Linux user space.

 Even if currently not a problem (pv domains can't use SMAP while HVM
 and PVH domains can't use multicalls) things might change when
 PVH dom0 support is added to the kernel."


-boris


  reply	other threads:[~2018-08-07 14:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  9:58 Juergen Gross
2018-06-13 10:05 ` [Xen-devel] " Jan Beulich
2018-06-13 10:20   ` Jan Beulich
     [not found]   ` <5B20EFE102000078001CACD4@suse.com>
2018-06-13 11:12     ` Juergen Gross
2018-06-13 12:55       ` Jan Beulich
2018-08-07 13:11 ` Juergen Gross
2018-08-07 14:02   ` Boris Ostrovsky [this message]
2018-08-07 15:17     ` Juergen Gross
2018-08-07 16:42       ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4f76a2a-128f-3e2a-44ee-04d57ab5be12@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®