From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8354F2749F1 for ; Mon, 13 Jul 2026 14:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783953962; cv=none; b=U3rREuRsfI+OI+AwN2miC5dWcpODfc+jgqTgJ0Yd6YtnMu+egT/69wWLByioHh/kg72PuRkuARIYZzmmLHyOlk3iCytCUZgtzSKKbmW7zrl2+06VRltbOW5TTYARHytb8PsSjqvC3JgdAPZau8AjEwpjWS8Gv/3/LcJvj/xqm1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783953962; c=relaxed/simple; bh=ExF1b1v/7B4ILStYP+oAvrb+mkSPom3xyqGuy5ikzME=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gWJpKK9wdYrW5u8SFxTGhi7nxc0ot5kIjl+IXkJpOm3i3QhHtd/UJvuLWIdZRgiL2l5PXhClzyu6503lDtBt6YAt1WyV7f285/Qy99dqyMI9VNBntpiczb2DnWnKGwFSt2ngcguuqrOed4EeE+KwMZNhitltZ7JKGVtgYX8bW5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=EaauNBIQ; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="EaauNBIQ" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-92e6a434cabso188900185a.1 for ; Mon, 13 Jul 2026 07:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1783953960; x=1784558760; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=geaYlJdetK2R3ggTTqwX7fjJrFf1JtF5SD2DZIVT7s0=; b=EaauNBIQ59ixqlmm5QX2LAFBoT+hP6pZcWl5sfi+avWbPKo2Gb2ywtQU2N544UMOUy ywB/snZ9MnumL/olsFfpLrAuLmOkjkh9MV2gRco9Lb2bw2NxYtsrXaJvNADnitirvk9s FunNlleXMVKsUfGFaAtWOOzZ11k4dbuctooGMkpc9beci1ZtHjSpwEoZ1ECEdd/IiyIA aGDz/7K2smd75AjGpFb3JJAP5UO6ooiumoiw5uOPv6nj6lwZ9StwkXMthTMuRlLRBUxP qWFJCnrzGWh4fQ65QvScCcj7VffacSUHRZPfcX97p1ZFcALdXbRNmVGSyQ+Id4zvl+EK gnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783953960; x=1784558760; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=geaYlJdetK2R3ggTTqwX7fjJrFf1JtF5SD2DZIVT7s0=; b=pG5spINGL4LKz8CrqCwAAU59qK6KddwIH2NU/6z/y37n8E851KTOXLWKyvr+QQLFj8 o2uszd+dwG4zvBxmFxcrh+hnqaDw/V/3tZKd3HyiazCwBERsE5Z4LLWMDN52WeeU7XvP VAepJa4m+fgTHtUa9YYf37MktZdmKvsnkVPTs5EsaXHzgB7uZSVezvsFR13WYYLCyRl0 Xvsp+eskI6oajhour8bNxxZcVbvk0pqQlxlbDbB45pxwWI9Rdl+l38O46hOXWPDn4Ehx 8cbG5LVgK6RXgR7uqV72Yil2wrdYKHjthv6hcNOI1f0VxL5GP3OmulcjM4AhAeyrRfkJ ZaWw== X-Forwarded-Encrypted: i=1; AHgh+RqGQV1XxCfB/uo8yDZPF+gpCVfxwJi+zaX+rgYB9/DNqw8RH5k7uCtoOZpa7AFFQMgh8tZUOAEQpPZLxJU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+YJthS3wa2Eb/tVMxMS6gqbCaIXQCNyanlP7we4mpltT2xat3 gn08Ft1Jdra7OPuCmEeJMh226s3lghR60/b9D4akH+iPgn8TvCRPeOohb/NhWKpzyQ== X-Gm-Gg: AfdE7cmgrd4/QvSAH3pApsafyo+WE9ZATsjPdbGK89joCxoHY3DLjsrUFu80yUnZTnG m+lVe1l4WiYdV8U8EkgfEsu5W4f/LSf7rpZIATZmjbwEXo6YUQlkNZgG6KBsepON1Zz2P9Hq8+7 U964CSV82+WvDqGfQYGfxqZmhbNJawVABobVHKOO7Ic98qMdbtZB6hoD/hTSbz5PrnBuWapocPV rphaV40s2O03g4+vGE0Rr82uVe1jxlpZfHx9gCaUeeV+CcUX+d0lq9TZPycr2fEKvJhZfTWSK7r xxw1UNVmgBipiskZsRjVVVYjD9F9Hk2sWalNE21vVMVA2WnPdJYg20Kxv1yrxQlPIPzop9WIRzB jshLI37p7qzOx3ifFoMRhTRD1Y85ai99uyLUD0kFAc8aLMduMwNFR6CLVtb+qfy1hRjLJt8b29r adOvFSG2SwB4ns2uHaEbaIaYAO9wfb8BQ= X-Received: by 2002:a05:620a:29ce:b0:915:a762:2735 with SMTP id af79cd13be357-92ef2b8f6b7mr980588685a.37.1783953960187; Mon, 13 Jul 2026 07:46:00 -0700 (PDT) Received: from rowland.harvard.edu ([140.247.181.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5b8ea22sm1066517985a.15.2026.07.13.07.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 07:45:59 -0700 (PDT) Date: Mon, 13 Jul 2026 10:45:57 -0400 From: Alan Stern To: Daniel Palmer Cc: peter.chen@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] usb: ehci: Add option to override ehci_readl()/ehci_writel() Message-ID: References: <20260713122205.1350933-1-daniel@thingy.jp> <20260713122205.1350933-2-daniel@thingy.jp> <02d6c843-6606-4f67-aef7-3a88846d6388@rowland.harvard.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 13, 2026 at 11:37:19PM +0900, Daniel Palmer wrote: > Hi Alan, > > On Mon, 13 Jul 2026 at 23:21, Alan Stern wrote: > > > +config HAVE_BROKEN_EHCI_HCD > > > + bool > > > > That is not a good choice of name; it's far too generic. EHCI > > controllers can be broken in so many different ways... > > > > How about USB_EHCI_MMIO_OVERRIDES instead? > > Noted. Based on that we'd have a config for each piece that needs to > be overridden so drivers can pick the ones they need? Maybe. What other things will need to be overridden? It's hard to tell what you're planning from just a single sample. Note that some of the things that are already present in the code can be thought of as overrides (although generally not for a broken feature). Alan Stern