From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75923921CE for ; Wed, 10 Jun 2026 08:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781078448; cv=none; b=KxmiU1kdmdWP+5cgbrDYNGCWXXFtIiiZm+uagkzP9rn7lVgIIytLEcuAdbl48cP6FA+cG/R1fXqFP2A6rOVviaX8K6Rkaa8KK4cwcwO85r/OzyrHwzI4C86Nk/bb0PqOvY6k7/icPdeKofsktLoFwbbTtjhcQsk+7La7s3q00w4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781078448; c=relaxed/simple; bh=sDTlRaHIQmiGRIRKko52QvjgdIEtCb1f1T3mtvTcr0A=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=WDJO4JaGh4RANzS9VeE0ouzGfPhSEe/caxzxkjEdKKWPMcfmCPaFoLNegnMVEFnTAKwBbNnoaA35RAaH1Lvjgm1vrueLJHiB7iFUCPRfX4QchE55HS18ChYeKVOfLszkHm6mRtd/ym+U9Q2ilgW8h2wgFcdynVRCwe4CzumEW/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ckxpr5nB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jEj7QZyh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ckxpr5nB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jEj7QZyh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A7ilQB997506 for ; Wed, 10 Jun 2026 08:00:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GQ1qMFZnEcfEmHrQcLlNp7BTXYqqiZIUVAVuFfn+664=; b=ckxpr5nBhlDNqrw6 Ix3YXXxDQm2HrFA0R/TOzjy2eR6EiT/XjnN2B1kJpMbAiMC2/alPoWD90tzwgWgG TTPz2bBq6+GOA4ge5kLclwZqnPaSAL/eqpU6v4oy4jXqUysyW5itT0hFC3jMON9p OgHTjvCKyhG79uFcMurkPvJoq/+LKT9taFpP+wJ4BuWSaLHoEDQ7HLmFOX1M03In kH5dURJw3vD5au66Z25n6ZsYyUBQ/qyxRYthDmf5IC5gClgsbMGLJzidVVRsyaEn QeSWBq8EqbqINK3wemarMgVz8tcrbm3TEZlJUQQ7bDQfjP58BbBIOWJ17471gy8e Wtj4Tw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq10a8qj8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 08:00:44 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51771d41426so122893101cf.2 for ; Wed, 10 Jun 2026 01:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781078444; x=1781683244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=GQ1qMFZnEcfEmHrQcLlNp7BTXYqqiZIUVAVuFfn+664=; b=jEj7QZyh/Ez5qNDvIaOqHUjtZXyeCSCPbFsFwZKn+A2kbJb2b4jEjpERlYyPWDOPBM YlQhDTsQDZvMyaNB9WkZsdPzQ7RVGpvqq/UD3h+w1/+vbPCvpM8j/kMFQgIICYV8DcGr uOhEPteKvtR2lxPpd2FSuePMIe65FjxMi6+ZEOpvAtS+JA9Ig7ppU8KMYVrirAsJc6EE ioTpIFDBs+ALDZ+KMO5CpPJuaiifcvWhyqMqTvc0lfoQIcDktQ3o62kDeiqc5rIMIqV6 SonF1AgQJVCGMbhdliCp1JSsnXS5lybXjbDc29p/Jncoims2AGZnsCinYUFKOCJ6bMW9 OG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781078444; x=1781683244; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GQ1qMFZnEcfEmHrQcLlNp7BTXYqqiZIUVAVuFfn+664=; b=E7pFGLDq28X65/25XNe2syzSP0mhYwXOGQDcMCqqzxN6UJYr4DPH7/OcwayHkNq0Ul gREg6K7NR2iyrH8DblTQKU7llRL/l/E/iRzaQRnmDOfXGx7JAIPWihTEwJ6uTbFMC+jQ IYnqpfkUzmdZljDv8z6ki8+kPLnRD4pO1y59ZaBiiuInz204lIOeOWcJ9MKYUhOy7S0u xnrWVNUNH/Z/NlQOI87/bARoafXvlaXQdwagz8F0pbB10H3gW1Pf6LLP4kPEnGDGFVnB vGIxkPNqaW74oEpwlQRazYekWqKlnrxqG8ZTssaWeYfCYR6s6dCrTB4/L5RpZXp8P9n3 mmCQ== X-Forwarded-Encrypted: i=1; AFNElJ+HXgKWYEGxsl4OWgqoW2R+MF5WhtBwP5p3SFfLRUnAYJad1oV84ynED7tsi7RQOBgiUcMG2qWbQyIThEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5UygTpOLvMNJTXHd2dmhqGh6Pc4AKJlqidiTyDIEDqiXk9clA 2bCbH+SShZB1cr/zLpMxDMu30NBr2AiM/BNSzu9PawemeXCArHry3aZCfu5COsOixf5TH5eM9Pt lH31qkWVBa4SuhEYL5udG65lGb/Hb3vnmpqkRPR1JkGEg/gh7U4uGtRr+RvrTNni/Bav9qFf8SP A= X-Gm-Gg: Acq92OGqgZL1JbiwuEGJTN0KTEbyUXqohy3zLPIJRa7Tezb0lqEQ4XnnzbG340DUu9A naGDPdYH06bt2LhmXFdauGnA508k0G/VzFqnkhONSeX3XuF44R51EcC4lGN1Dt+VH/LpnlYzfZ+ YoAHpIU5DcfT6JxyMoa8hPoFxtTNLSblafwQNg2T5ycGbyn7fZE5PkhaYTJkuA2/wl/lriWfqO/ lfxcmO+VJyFZ1VxHfF8ocYJvfk1E7cm/OxmunBQ9epZwuqeari0tIMm/X6cuPqEdTnSw3nf5GHq +pStvOdceAO0AuFDsEVas1DJ19oXKe2AUhU1f/Ou4KxeQuBTehjId7Lgmac9AT9zjtJY2wfMw7j Aqk5Xn2/2FsvQ7iBNiO1FnLogRN1VFroqA3oGA84eU2XstNby0wSsTRZ/KJHsb1cwdLNGln6+dT zdcjrPVIw1ufxOyf6pAS7NOGVnfAC0DB0v7RvI8aZojsDLwGLK94XuIVt25R+20os6GiaZwuUel Yn+eu1yScczk9eizI/5xvKoqRQ= X-Received: by 2002:a05:622a:345:b0:517:b750:642 with SMTP id d75a77b69052e-517b7500b3dmr184048111cf.47.1781078443720; Wed, 10 Jun 2026 01:00:43 -0700 (PDT) X-Received: by 2002:a05:622a:345:b0:517:b750:642 with SMTP id d75a77b69052e-517b7500b3dmr184047521cf.47.1781078443322; Wed, 10 Jun 2026 01:00:43 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e650287d9sm9700069a12.12.2026.06.10.01.00.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:00:42 -0700 (PDT) Message-ID: Date: Wed, 10 Jun 2026 10:00:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v7 1/2] platform/x86/lenovo: lenovo-ymc: Suppress probe on Yoga Book 9 14IAH10 To: Dave Carey , platform-driver-x86@vger.kernel.org Cc: mpearson-lenovo@squebb.ca, ilpo.jarvinen@linux.intel.com, armin.wolf@outlook.de, linux-kernel@vger.kernel.org References: <20260608215205.678182-1-carvsdriver@gmail.com> <20260609212631.925943-1-carvsdriver@gmail.com> <20260609212631.925943-2-carvsdriver@gmail.com> Content-Language: en-US, nl In-Reply-To: <20260609212631.925943-2-carvsdriver@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GoFyPE1C c=1 sm=1 tr=0 ts=6a2919ac cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=BqHIVXqeafSIuN2z4QsA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: M3LD9VsTTfvrgKyzFo6gy-5kNSZT_dHS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA3NCBTYWx0ZWRfX11NazvQNjd// n1/PX4vrYzxUq7nXusNCiKx1c/SlHjV0HTOt7dpLoHrfWPdeukO4M2EIcPtqYG+Z7j7DPmSn6Q4 faGbyt1naMi783W1gznHgYodlqcZZYgaNJZvaKhp1GzRkidp5i2f+9PogrwsfazDRK8TmeMBT00 mC5YEdjwpyXr6AmjJTQS0Cd1ZJmCZz8y7pKnQRD7nTWTliiiJrol4rqlIZj+W6zCapYm0umCRLm BPpv1o5p2MrStlUOofrXIvDc3wosWT/y4/U1NWij3osNR94ar4Ao6Ewi1lOjFKt/vJyBbOr8iws EwZlyzUOI2LkBRE63kL+In4nqzFzDNRby66UGNcdKK65gzqjMYkNjdBQ23Wbrfoa+Mk/JMuZ6rP Tetu+PfH5rH5gwTwGdn1bhMc3aN3TdK5EtvD4LMM5HzO+lKZ6GVxaJihrL8fJzdcB/K1so3IB51 /cqa59m5pOTwMC6KrHw== X-Proofpoint-GUID: M3LD9VsTTfvrgKyzFo6gy-5kNSZT_dHS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100074 Hi, On 9-Jun-26 23:26, Dave Carey wrote: > The Yoga Book 9 14IAH10 (DMI product name "83KJ") has a dedicated > yb9-kbdock WMI driver that registers an input device reporting > SW_TABLET_MODE to track the detachable Bluetooth keyboard. > > lenovo-ymc also loads on this machine and creates an input node with the > SW_TABLET_MODE capability bit set. For input switches, the presence of > the capability bit has semantic meaning: userspace (e.g. GNOME) reads > the switch state at startup from every node advertising the capability > and does not expect more than one such node. > > Add a DMI match for the Yoga Book 9 14IAH10 to probe() so that > lenovo-ymc returns -ENODEV on this hardware, leaving yb9-kbdock as the > sole SW_TABLET_MODE source. The ymc_ec_trigger EC write, the only > other action taken in response to a YMC event, is guarded by a separate > DMI table that excludes this machine; no other functionality is affected. > > Signed-off-by: Dave Carey Thanks, patch looks good to me: Reviewed-by: Hans de Goede Dave, note it is normal to add received tags like my Reviewed-by above to new version of the series, just above your Signed-off-by. With the exception being to drop Reviewed / Acked tags when there are a lot of changes to patch. Regards, Hans > --- > drivers/platform/x86/lenovo/ymc.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/platform/x86/lenovo/ymc.c b/drivers/platform/x86/lenovo/ymc.c > --- a/drivers/platform/x86/lenovo/ymc.c > +++ b/drivers/platform/x86/lenovo/ymc.c > @@ -23,7 +23,23 @@ module_param(force, bool, 0444); > static bool force; > module_param(force, bool, 0444); > MODULE_PARM_DESC(force, "Force loading on boards without a convertible DMI chassis-type"); > > +static const struct dmi_system_id lenovo_ymc_nosupport_dmi_table[] = { > + { > + /* > + * Yoga Book 9 14IAH10: SW_TABLET_MODE is reported by the > + * yb9-kbdock driver. Suppress lenovo-ymc on this machine to > + * avoid userspace seeing two input nodes that both advertise > + * the SW_TABLET_MODE capability. > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_NAME, "83KJ"), > + }, > + }, > + { } > +}; > + > static const struct dmi_system_id allowed_chasis_types_dmi_table[] = { > { > .matches = { > @@ -100,7 +116,10 @@ static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx) > struct lenovo_ymc_private *priv; > struct input_dev *input_dev; > int err; > > + if (dmi_check_system(lenovo_ymc_nosupport_dmi_table)) > + return -ENODEV; > + > if (!dmi_check_system(allowed_chasis_types_dmi_table)) { > if (force) > dev_info(&wdev->dev, "Force loading Lenovo YMC support\n"); > -- > 2.54.0