From: Javier Martinez Canillas <javierm@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: open list <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] kbuild: quote OBJCOPY var to avoid a pahole call break the build
Date: Wed, 26 May 2021 23:49:58 +0200 [thread overview]
Message-ID: <a5004a7e-14bf-4fb1-beec-9dc19165f2d2@redhat.com> (raw)
In-Reply-To: <CAEf4BzaV0y51EY5JAYZ0dueC2NQihwy+4pTtidSj4KXxGm+fwA@mail.gmail.com>
On 5/26/21 11:02 PM, Andrii Nakryiko wrote:
[snip]
>>
>> BTW, I see similar code in scripts/link-vmlinux.sh too.
>>
>> LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${extra_paholeopt} ${1}
>>
>> Is it OK to leave it unquoted?
>
> You are right, link-vmlinux.sh should be updated accordingly.
>
Good catch. I'll include this in v2 as well.
> Javier, can you please send v2 and cc bpf@vger.kernel.org? Thanks!
>
Sure, thanks!
Best regards,
--
Javier Martinez Canillas
Software Engineer
New Platform Technologies Enablement team
RHEL Engineering
prev parent reply other threads:[~2021-05-26 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 14:23 Javier Martinez Canillas
2021-05-26 16:18 ` Andrii Nakryiko
2021-05-26 18:59 ` Arnaldo Carvalho de Melo
2021-05-26 19:53 ` Masahiro Yamada
2021-05-26 21:02 ` Andrii Nakryiko
2021-05-26 21:49 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5004a7e-14bf-4fb1-beec-9dc19165f2d2@redhat.com \
--to=javierm@redhat.com \
--cc=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®