From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: add core-managed per-client directory in debugfs
Date: Thu, 9 Jan 2025 07:29:44 -0800 [thread overview]
Message-ID: <a519d066-7325-446c-99ab-87f36a26b850@roeck-us.net> (raw)
In-Reply-To: <20250109122112.45810-2-wsa+renesas@sang-engineering.com>
On Thu, Jan 09, 2025 at 01:21:10PM +0100, Wolfram Sang wrote:
> More and more I2C client drivers use debugfs entries and currently they
> need to manage a subdir for their files on their own. This means
> inconsistent naming for these subdirs and they are scattered all over
> the debugfs-tree as well. Not to mention the duplicated code.
>
> Let the I2C core provide and maintain a proper directory per client.
>
> Note: It was considered to save the additional pointer in 'struct
> i2c_client' and only provide a subdir when requested via a helper
> function. When sketching this approach, more and more corner cases
> appeared, though, so the current solution with its simple and unabiguous
> code was chosen.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/i2c/i2c-core-base.c | 4 ++++
> include/linux/i2c.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index b072030a9105..00f171ebc01f 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -1015,6 +1015,8 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf
> if (status)
> goto out_remove_swnode;
>
> + client->debugfs = debugfs_create_dir(dev_name(&client->dev), adap->debugfs);
> +
> dev_dbg(&adap->dev, "client [%s] registered with bus id %s\n",
> client->name, dev_name(&client->dev));
>
> @@ -1058,6 +1060,8 @@ void i2c_unregister_device(struct i2c_client *client)
>
> if (ACPI_COMPANION(&client->dev))
> acpi_device_clear_enumerated(ACPI_COMPANION(&client->dev));
> +
> + debugfs_remove_recursive(client->debugfs);
> device_remove_software_node(&client->dev);
> device_unregister(&client->dev);
> }
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 66fb3d6cf686..36de788dc7fe 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -347,6 +347,7 @@ struct i2c_client {
> i2c_slave_cb_t slave_cb; /* callback for slave mode */
> #endif
> void *devres_group_id; /* ID of probe devres group */
> + struct dentry *debugfs; /* per-client debugfs dir */
> };
> #define to_i2c_client(d) container_of(d, struct i2c_client, dev)
>
> --
> 2.45.2
>
next prev parent reply other threads:[~2025-01-09 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 12:21 [PATCH 0/2] i2c: core-managed per-client directory in debugfs with example Wolfram Sang
2025-01-09 12:21 ` [PATCH 1/2] i2c: add core-managed per-client directory in debugfs Wolfram Sang
2025-01-09 15:29 ` Guenter Roeck [this message]
2025-01-14 11:59 ` Wolfram Sang
2025-01-09 12:21 ` [PATCH 2/2] hwmon: (isl28022) Use per-client debugfs entry Wolfram Sang
2025-01-09 15:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a519d066-7325-446c-99ab-87f36a26b850@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®