From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DAF633A032 for ; Mon, 15 Jun 2026 10:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781520287; cv=none; b=EYgc7vZxx59z2bFeqy5z1z8KNa5vca8SPPx3lWJBEsXTATvHKHxz7F+1FSNqXs86PXCKnhFYGtwviz+z0fgD0GoRXVDJDEUb+qpDbC4yQqITc3UsEOjwbiGROFZnsO5GNV6eC6tuKnFNizlHusHewloxDhlB4r++VMK+LApj8zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781520287; c=relaxed/simple; bh=68/HTyHPR6KVGQpmVIWbzZT7PDEyrxaPs8vAVZF28lA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VrQUEOYZ88+6lkVpkypK2mY5URdFNsWLF/kiI+cGMNbRiXEyn1lCKZjMTkqFDG2xYPQUhxNblSI9FdBVtovEA0GvHbLtvEaYQr4LXEOsyM09B8/Wv67S0DwNkWo4aa77DEaVf7Z/3JA7lqlEasaSKNLHJjQ+Q7I1XymZVT1zpcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Iwx9c5eh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EKxkDM40; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Iwx9c5eh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EKxkDM40" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FAIfKH3900291 for ; Mon, 15 Jun 2026 10:44:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3L1aoItvXKgSKcXjoUT8ZFQKPYF1tzuxSSufM8weEwQ=; b=Iwx9c5ehwf7NA5sY S2UVAgF9R04vz16jNYGptgnaZUIov2r5+bfxWaSSjZcRM5lQsgKkWv4mgcj1D/ro 9LpOTTORjk1pB+ueUvI3S/0pdN2t6uJb2RngR/5EMYZvKz2/KDY48UvIqKuh9Xvz /2mpIep3hNp2XpiNoWqzWLBpvSwveu2V6R0mEQ7spq+py0B5/Lw7HbohEadhUenN DQp3hUUABbecLoTvqNDQuIWxIWwZs95FFpHdM/rS4/g5cKpAJoC2BztxYiNCQDVk pqdBYEGRvCahSEcVtNVAgZMbvzqRjNNT6Q0Vs9rU565iU7sxLvZIc14H+b7NfCke 94Cwdg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eteyd88gk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 10:44:45 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8ccd69b9a10so7636386d6.1 for ; Mon, 15 Jun 2026 03:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781520285; x=1782125085; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3L1aoItvXKgSKcXjoUT8ZFQKPYF1tzuxSSufM8weEwQ=; b=EKxkDM40QleuoNB08yiIJfcycW7QhytnMlJv1NRJSbcihVGyu03CiTVPVbnde5Catx hS5KMu9kBJUqIlQFWzPge/tTWp4KVAHheuoXW+tvtNU31U6+U9diF3iuaPgP/bF2v9Sc lgI4p4T4FQRHW4JIZPgmmg2m6lfYxZJOXeFIY+9qKaipmBEHdL3AjJ7xDOMylIS5N6qe KLF/XVhjoq2oTL2R3j0lD5hL715SKAnLRev4RCdDVjFbopQMibRsNteR+252CqTP39id rATVkFHdJLhC+w5VxmTYeDYwLY00kqVpnMKELPnNx0sViHZQhLDENn00Ul3jx6s2wOja GLJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781520285; x=1782125085; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3L1aoItvXKgSKcXjoUT8ZFQKPYF1tzuxSSufM8weEwQ=; b=iRNqAheN+Rz4S8/13AoJUYkYnUR8oU6NNi5g9Zxm/4YHS7TAtOVRkx6j79DygqO6g0 wM1+FVjaPQS8sFsgNhn5D/NRPhmUKH46SfeJ8cqRr0z4mHu6zBkqzL1+2NEWuBGNOZf+ fVhwqtQ6lEp0kKZY/FYbP6Rq96cpzgv7XTpgX8shULW6WNn3sgkkcc897/C+kKN3rv/3 AsBOT3D8L+Rxq8c/0M9+pxQXtw4ZvF/eYmDWnWr8tJkD6mHW7lpkdC1GfeDN0V6Jeath RyfhgOSPEhdkebxFVVVCwyuxD6dKhKj72FmS3RP1/u6NKrHXoGtd3g929GvIlwfL5OEz BYwQ== X-Forwarded-Encrypted: i=1; AFNElJ/POrRNCUI5vzIcdiMfuRmbY2zrA8X+zgSUwBUOEI1P4ppv4LYZrU3LiUfNC8xiNmTqM9+6un8XcYBi9j0=@vger.kernel.org X-Gm-Message-State: AOJu0YzBnsxHBdjPEeIbtgcg2DgOHsEspZQjXlytzfbrQP3y00kTnokT b7JRBxv4cKzz067GGKAlMbkFbvFmcNPauq4h/jUqT4coMKPNogQpFvV0ZLg8EtgxHdgjXCdBgHP RsyLRiwCJkbJ2/+Xt8r1h4ichMgT1KV/KAw6t5qDwQ0rBxxg82rhcoYri0oUzU4VJv3w= X-Gm-Gg: Acq92OG916YV5DdjEd2r+tctq9CcYfyepRpDx60yyou24fhCadewbahbABc6QDg8alI vFsjn4nAH68P7fI1kk5D+gxq+h1QK6eAsNaUOu1Ym/APyP4C0yDQCIUX/8nGM5c7OXHmsu50YPu 57p+167xYxsOLjza99loiUgERa7naxqgSTbpj7XxKNqoh4XRPtFHF1d/dCp7Tfsp8uGHLQg02jZ 4Q4wiFXhGWlPjF94kn/Ioo6vj+IHkmT18eVqPC1DLdzLODx+6OhD6S+ZJ69oGVNhBzQWWuMlCIP nTxj1ZXvjfmOd1cm0LPT0HOck5cyXylOQQVNTyHSNkb5QIoay1ncTJWgxJzHLiNgdDoM/0rw0a3 e1OOtEF3Kw0fB6faZRkqbn8hqLIiozb3FE8IK9aqrxBUbeg== X-Received: by 2002:a05:620a:2892:b0:8f3:5988:f97c with SMTP id af79cd13be357-9161bc9eeabmr1256415585a.3.1781520284829; Mon, 15 Jun 2026 03:44:44 -0700 (PDT) X-Received: by 2002:a05:620a:2892:b0:8f3:5988:f97c with SMTP id af79cd13be357-9161bc9eeabmr1256412585a.3.1781520284254; Mon, 15 Jun 2026 03:44:44 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8341ba5sm444685566b.42.2026.06.15.03.44.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 03:44:43 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 12:44:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] phy: qcom-qusb2: Fix SM6115 init sequence To: Iskren Chernev , Konrad Dybcio , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Greg Kroah-Hartman , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610-topic-8996_61x5_qusb2phy-v1-0-d7135980e78f@oss.qualcomm.com> <20260610-topic-8996_61x5_qusb2phy-v1-2-d7135980e78f@oss.qualcomm.com> <5b474af3-f651-4a64-a5b9-c18136e589eb@iskren.info> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5b474af3-f651-4a64-a5b9-c18136e589eb@iskren.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: cdg7XsgbfEFdogOUJ4ZHXol-kr7gLewh X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDExMyBTYWx0ZWRfXwNzN35WcRjp/ mAwZa0y8CRMJ852gFi7MvBxpLO3N255E4WJJGxhiiKkGgGl9pa+a5U5/+x1chSPTH8DVPJyNwJ9 65bTdb8EomPyJShhnyMB80HaWtjinCw= X-Authority-Analysis: v=2.4 cv=QrJuG1yd c=1 sm=1 tr=0 ts=6a2fd79d cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=H8nO66aeAAAA:8 a=sh5-wexBAAAA:20 a=EUspDBNiAAAA:8 a=MyJ6PO3ExZ6mTeW_YjAA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=29nWO70QIcuf0NxZitda:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-ORIG-GUID: cdg7XsgbfEFdogOUJ4ZHXol-kr7gLewh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDExMyBTYWx0ZWRfX+Ivf5H6XPP+V mvpG4G8QNRgV2Es4otN6aHFFKdIWSOK8LS11pTBsFjJvMm1b4SAaqJTUHEHIQCaTNSRJWr/cN/e 37WmsXoshmwv/xLBhhnGmzEGCJrLl7tgLsCbErKXh26slvUg3WqvCDP2RxcNQNuyQPjAfqCNpCa Y1ygrJMUHTS7UQM57pMeRUf2H7fFrHGMUx+pwiaq2VN3gVhGLs2WXYu8wlwJy5WS7xVyrSYM3vF 2GBu1/4dtxI3xDocsjEbkPc//oLsXwg/iIQcjCEfEi9vp3EPAG0MNFqJd1kZQeD9k73W7C2ym/z EHP+KUYaa4Z98QvC9JNw0e985rcLJorEqboKlFQAoIq6KR6tCmryKPTydQ/gJJuc+2r7n+3Rckg PHxY4lVIg64cNrmd6wXgQSJ4tYHLGji2K1AGVG3Cdb4cvSJckrMSOHDHcoB20j5fnjGU8zKrbmz RUvfYZ744FGcM5Yty8A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_02,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150113 On 6/14/26 2:29 PM, Iskren Chernev wrote: > > > On 6/10/26 3:04 PM, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> I don't know where the existing one came from, but it's apparently >> wrong, according to both docs and a downstream DT [1]. Fix it up. > > They came from DTB extracted from a running billie2 (OnePlus Nord N100): > [1] https://mainlining.dev/wp-content/uploads/2021/02/03_dtbdump_Qualcomm_Technologies_Inc._Bengal_SoC.dts > > The phone was bough early after launch, so it could have been wrong/updated later. Good to see you're still around! Looks like vendor tuning. I see that even the initial commit for 6115 had the init sequence I posted. And the OnePlus sources have what seems like a project-specific local copy of the DTSI: https://github.com/OnePlusOSS/android_kernel_oneplus_sm4250/blob/oneplus/SM4250_Q_10.0/arch/arm64/boot/dts/vendor/qcom/bengal-usb.dtsi#L145 https://github.com/OnePlusOSS/android_kernel_oneplus_sm4250/blob/oneplus/SM4250_Q_10.0/arch/arm64/boot/dts/vendor/20882/bengal-usb.dtsi#L148 To support that, we should add a new property to override the TUNEx registers - like e.g. qcom,hstx-trim-value that's already consumed Would you like to look into that, or should I take this? Konrad