From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795012264; b=K0HICX9pjPNJIruDE6EYXZGcexeoU3WBhzCRRj42EyUDI2T2jIdd/UfyZESnjoyERORt afKQA1kt0P3dIPOgw0uP6V57MMf4hWjk6GpRBGvF0xC30+W4dYZm1R+Xj1NC5tjceATPT 4zi1rDr2JbBqa02h71jIIY1p6K1gw8OiQRg+hxgDYtUJ/5pVe58vfrX7Q8flxns/Yv1WU MLJahSlkF7X3DwTMkL/kCNCOAmKtxginBS2qnrHjTPyDdsjSbFYICh83c2OYa624ytoRD SnpFpK/Czgl49b12AUJRSB541vteO7SvvfDwnMCLZtv+oK3uOG0thExLBwrr/vZo4Ew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795012264; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Last-TLS-Session-Version; bh=392Hdswd6RPVgoARz97n2rCwM4IdCSNMtjJg6BE/bLM=; b=x+ldTKbXiSs8Cox4Uqz4Er6/WWsgduGRMyXM74IEMI6DoMsB+lTbdsWUTHAJbhAzhsfl tBmKvHGZqR4Ih7s6z12svg8ELq31z3VBmZrPei6MNVff9Nbm1ZyccWoM6m75omvtEhhPh v5YT8ugvA7marTFG0JSH85KtTXVrLPgyGjSkgNCnVgyIEG1VpuC4c8nGgJEwmPrDdkpKE CZnbkAPtZEO+s7uH2he1zvHUIhVHz6Ls67YkYAXCGMmD3RPZChpHi8bKc8hWQPAqDAtL6 QeLvTOohF2bivTIiwWielTGn8WzDZDxjL6R7EE334pQFntInU0G1eFoxIldmiaEW1gg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=Ew2XsXLk; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2FD1606A32C for ; Wed, 18 Nov 2026 14:31:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D2FD1606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=Ew2XsXLk Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 60D444E41636; Wed, 18 Nov 2026 14:31:02 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2C79D5FE9B; Wed, 18 Nov 2026 14:31:02 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5D73911BC1D28; Wed, 18 Nov 2026 15:30:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795012256; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=392Hdswd6RPVgoARz97n2rCwM4IdCSNMtjJg6BE/bLM=; b=Ew2XsXLkqtUOpCPT12pc1hvd84aXYM7wHSOTaA+EnsN0dNFY3Ua2doiE0ZnT3/UMkbkIPE H1jB6j9Php5QHjUMbNW0pUBIx3QVZBlHFCWxIke3VinNVOJhoDfe9aUgbhd75IJfBBU0LN TBNmaFLMOWHoy02XumJqjJNTlxGk8PKr6CUNoLchmsl39lHvnqmF+gQ7aduTJmQ8Bw5AY5 pSb4V4gvxIVY3rGJAAWcyOGqAoyUAnP4MtXuHSASvcjDRxKEzX7iyb4EFmp52iNpahDQvN io7gsIQses3V8zw4i8cjH8zrcQbeXMhat7BBtn62CrJT2tsWaaQZ40jIjx9mRA== Message-ID: Date: Wed, 18 Nov 2026 15:30:50 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/12] drm/vkms: rename VKMS_LUT_SIZE to VKMS_GAMMA_LUT_SIZE To: Leandro Ribeiro Cc: airlied@gmail.com, alex.hung@amd.com, daniel@fooishbar.org, hamohammed.sa@gmail.com, harry.wentland@amd.com, maarten.lankhorst@linux.intel.com, melissa.srw@gmail.com, mripard@kernel.org, pekka.paalanen@collabora.com, robert.mader@collabora.com, simona@ffwll.ch, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20261106201813.129911-1-leandro.ribeiro@collabora.com> <20261106201813.129911-2-leandro.ribeiro@collabora.com> From: Louis Chauvet Content-Language: en-US In-Reply-To: <20261106201813.129911-2-leandro.ribeiro@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 11/6/26 21:18, Leandro Ribeiro wrote: > This is the size of the CRTC gamma LUT size. So let's specify this > in the name. > > Reviewed-by: Robert Mader > Tested-by: Robert Mader > Signed-off-by: Leandro Ribeiro Reviewed-by: Louis Chauvet > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 4 ++-- > drivers/gpu/drm/vkms/vkms_drv.c | 2 +- > drivers/gpu/drm/vkms/vkms_drv.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > index fe17f49305a9..019d7bc90cdc 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -222,13 +222,13 @@ struct vkms_output *vkms_crtc_init(struct drm_device *dev, struct drm_plane *pri > > drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs); > > - ret = drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE); > + ret = drm_mode_crtc_set_gamma_size(crtc, VKMS_GAMMA_LUT_SIZE); > if (ret) { > DRM_ERROR("Failed to set gamma size\n"); > return ERR_PTR(ret); > } > > - drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE); > + drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_GAMMA_LUT_SIZE); > > drm_crtc_attach_background_color_property(crtc); > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index 5a640b531d88..86a8a95694fd 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -113,7 +113,7 @@ static int vkms_atomic_check(struct drm_device *dev, struct drm_atomic_commit *s > continue; > > if (new_crtc_state->gamma_lut->length / sizeof(struct drm_color_lut *) > - > VKMS_LUT_SIZE) > + > VKMS_GAMMA_LUT_SIZE) > return -EINVAL; > } > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index dea6cad3f1b9..34b855431af3 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -25,7 +25,7 @@ > > #define NUM_OVERLAY_PLANES 8 > > -#define VKMS_LUT_SIZE 256 > +#define VKMS_GAMMA_LUT_SIZE 256 > > /** > * struct vkms_frame_info - Structure to store the state of a frame